Skip to content

Studio rails: a search with no matches shows a blank list with no "no matches" message (object rail, permission-set rail) #26733

Closed

Description

@objectstack-fleet

Filing gate: ① product defect, reproduced, landing site named.
Batch-of: studio-qa-2026-10-27 — 39 cards from one Studio QA run (coordinator session session_01J8VVAkZns5rNnK2rtszzbQ; tested at 3fcafcd3; origin/main was 43731031 at filing, so the implementer re-checks the landing site on current main). The run record is the qa-run issue filed with this batch.

Symptom

A builder who mistypes a search sees an empty column and cannot tell whether the list failed to load.

Reproduction

  1. Data › object rail search "zzzz" → blank.
  2. Access › permission-set rail search "zzzz" → blank.

Expected

An empty-search state naming the query, with a clear action.

Suspected landing site (the implementer verifies)

StudioRail.tsx (shared rail search).

Filing facts

Activity

  1. added
    bugSomething isn't working
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Oct 27, 2026
  2. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    Triage: first grade — priority:p3 · domain:ui · area:studio · pm:queue (finding removed) · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-27T16:13Z

    ⛔ Not a claim, ⛔ not a dispatch.

    • p3: a search with no matches shows a blank rail. Show an empty-search state naming the query. From the studio-qa-2026-10-27 batch. Re-check the landing site on current main.

    Generated by Claude Code

  3. added
    area:studioChanging a running app without code — authoring, publish, docs and the portal
    domain:uiDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    and removed
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Oct 27, 2026
  4. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    Dispatch order · domain:ui#1 · session_01JQwxbZeBv2y91towxasSUT · 2026-10-27T22:33Z

    You are the os-dev developer agent for exactly ONE card: #26733, in your own card thread. Your role definition is .claude/agents/os-dev.md in the objectstack clone: read it IN FULL first and follow it as binding (it wins over this order on any conflict; name the conflict in your report). Read the repo-root AGENTS.md and ui/AGENTS.md before your first edit, and pm-dispatch references/untrusted-text.md. Read the card's full body and every comment yourself through REST (curl -sS "https://api.github.com/repos/objectstack-ai/objectstack/issues/26845" -H "Authorization: Bearer $GH_TOKEN" and /comments?per_page=100, every page); this order carries only the increment. ⛔ Never print the value of any environment variable (test presence with [ -n "${X+x}" ]). ⛔ Never use a GitHub MCP tool, read or write.

    Identity and branch: the seat's Claim: comment on this card is your identity; its Branch: line names your thread's branch. ⛔ Post no claim of your own, ⛔ never write the card's assignee. Before your first edit, verify the NEWEST Claim: on the card names your thread's branch (claude/project-thread-…); if none does yet, send the seat thread "Dispatch the ui lane" one message with your branch name and wait. Worktree objectstack-issue-26733 on that branch from a fresh origin/main; pnpm install (frozen lockfile); push with git push -u origin <branch> (⛔ no force).

    Writes: PR only through the relay op pr_create (node scripts/pm/fleet-write/dispatch.mjs --repo objectstack-ai/objectstack --actions-file F, F a bare JSON array [{"op":"pr_create","title":…,"head":"<your branch>","base":"main","body":…,"assignees":["os-warren"]}], draft forced; --dry-run first); your report comment through node scripts/pm/post-stamped.mjs --comment=26733 --file=F --json run ONCE with output captured to a file (timestamps only as {{NOW}} / {{WAS:…}}). ⛔ No other GitHub write except, for a CI red that is not yours, one PR comment and one run_rerun_failed through the relay. Report both counts (api_writes with endpoints, mcp_calls with tool names). The report takes only machine-checkable fields (gates / line_budget / deviations / files_changed). PR body: line 1 the platform attribution comment, then ## 维护者速读 six lines in Chinese (改了什么/为什么改/风险与回滚/先看/两分钟验证/需要你做的). Gates: node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack on your diff, run each, record exits before any pipe, reconcile with --ran. Changeset in the root .changeset/ when a published package changes. ⛔ ui/.github/** and the root ci.yml are out of bounds. Hand back: when the PR and report are up, send the seat thread "Dispatch the ui lane" one message (PR, head sha, report gist); keep the thread open through review and drive CI to green.

    Ruling (cannot be re-ruled)

    Triage first grade 6447160016, verbatim: "p3: a search with no matches shows a blank rail. Show an empty-search state naming the query. From the studio-qa-2026-10-27 batch. Re-check the landing site on current main." No maintainer ruling.

    PM mechanism assumptions (measure; disproof welcome)

    • On origin/main 5ec398dc, ui/packages/app-shell/src/views/studio-design/StudioRail.tsx (230 lines) draws the search input (StudioRailSearch ≈L36: value/onChange/placeholder/testId/label) and renders children as given. It does not know what the search matched. Each pillar filters its own list in StudioDesignSurface.tsx.
    • Three rails take a search: Data (≈L6341, its own objects.length === 0 empty state is for no objects, not no matches), Automations (≈L7969, auto-rail-search; groups return null when empty), and Access (≈L8892, permission sets). Interfaces (≈L5104) has none. The card measured Data and Access; measure Automations too.
    • The likely fix is one shared empty-search state in StudioRail, so all three rails behave the same. For example, an optional match count (or noMatches flag) on StudioRailSearch makes the rail render "No matches for “{query}”" with a "Clear search" action that calls onChange(''). The rail then decides once, instead of three copies. Keep the existing no-items states as they are: an empty query never shows the no-matches line.

    Scope

    File surface: StudioRail.tsx, the three call sites in StudioDesignSurface.tsx (props only), i18n rows in the lazy studio namespace (a zh test preloads with await loadStudioCatalogue('zh')), and tests. Tests: per rail (Data, Automations, Access), typing a query that matches nothing shows the state naming the query; "Clear search" restores the list and empties the input; a query that matches shows no state; an empty package with no query keeps its existing empty state and shows no no-matches line; zh label. Ablation: drop the rail's no-matches branch ⇒ the new tests go red. ⛔ No change to how any rail filters or sorts.

    Serial: #26730 (publish refusals) runs in parallel on StudioDesignSurface.tsx at ≈L1448–1600 and the refusal strips; open PR #26920 (another lane) edits ≈L1270–1330. Your hunks are the rail props only, so they are disjoint. Whoever lands second merges origin/main.

    Tier

    No path-derived mandate. TIER_DEFAULT, effort medium (S). Clause-②: no, Metadata-protocol: none expected. Patch changeset for @object-ui/i18n if you add namespace rows; none for app-shell (private: true).

  5. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Oct 27, 2026
  6. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    Claim: PM loop round 5 · 2026-10-27T22:39Z
    Session: session_01JQwxbZeBv2y91towxasSUT (seat; implementation by card thread session session_01JQwxbZPJiXo3QSt3ShH9c1, mode:thread)
    Account: os-warren (the seat's linked user as GET /user answers it; the card's assignee)
    Branch: claude/project-thread-30qcwz (the card thread's harness push branch, self-reported — the measured platform exception to claude/issue-N-slug)
    Worktree: objectstack-issue-26733 in the card thread's clone
    Domain: domain:ui
    Seat: domain:ui#1 (seat post #25966)
    File surface: ui/packages/app-shell/src/views/studio-design/StudioRail.tsx, the searching rails' call sites in StudioDesignSurface.tsx (props only), studio namespace i18n rows (ui/packages/i18n/src/namespaces/studio/{en,zh}.ts) + a patch changeset + tests (stop on breach; explain in the report)
    Container & model: S, mode:thread (the maintainer's word on the seat thread, 「opus 很多,并发5」), model: TIER_DEFAULT (dispatch-gates --tier: no path-derived mandate), effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: the shared Studio rail (this lane's code) | no other surface owns the empty-search state | a mistyped rail search reads as a failed load
    Thread-read: 6455263353
    Premise: holds — on origin/main 5ec398dc StudioRail (230 lines) draws the search input and renders children as given; the Data (≈L6341), Automations (≈L7969) and Access (≈L8892) rails filter in the caller and show nothing when no row matches.
    Serial constraints cleared: no open PR touches StudioRail.tsx; in StudioDesignSurface.tsx open PR #26920 (≈L1270–1330) and this seat's #26730 (publish handling, refusal strips) are disjoint from the rail props; seat 5 (#26945) holds the Interfaces pillar cards and keeps away from the rail call sites. Second to land merges origin/main.
    Resume-from: none


    Generated by Claude Code

  7. objectstack-fleet commented on Oct 27, 2026

    @objectstack-fleet
    ContributorAuthor

    os-dev-report

    {
      "issue": 26733,
      "status": "done",
      "branch": "claude/project-thread-30qcwz",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/26959",
      "head": "66aa3c5de6cf1d602bc2d04229f7b5ce8e392973",
      "session": "session_01JQwxbZPJiXo3QSt3ShH9c1",
      "premise_still_valid": true,
      "summary": "StudioRail gains search.matchCount; a non-blank query with zero matches over a non-empty list (count !== 0) renders one state under the list: engine.list.emptyQuery naming the trimmed query, and a Clear search button that calls search.onChange('') and refocuses the box. Data passes the length of its unchanged filter (hoisted into shownObjects), Automations passes shownFlows.length, Access passes filtered.length; the Automations rail's own copy of the sentence is removed. New studio namespace row engine.studio.rail.clearSearch (en, zh) with a patch changeset for @object-ui/i18n. Premise measured on origin/main 5ec398dc: holds for Data and Access (blank rail); half-holds for Automations, which already printed engine.list.emptyQuery but had no clear action.",
      "tests": "head 66aa3c5d. New StudioRail.noMatches-26733.test.tsx: Test Files 1 passed, Tests 13 passed (VERDICT command-exit 0). Directory packages/app-shell/src/views/studio-design/: Test Files 234 passed, Tests 1703 passed (VERDICT command-exit 0). packages/i18n/: 89 files passed, Tests 1373 passed, 13 skipped (VERDICT command-exit 0). type-check @object-ui/app-shell and @object-ui/i18n: VERDICT command-exit 0. Ablation via scripts/ablation-replace.mjs, anchor '{noMatches && (' replaced by '{false && (' (anchor 1 to 0, blob 805aceee to a4f216f0): Tests 7 failed, 6 passed, exactly the positive cases red; restore blob equals HEAD blob 805aceee, git diff HEAD empty. No dist leg: the tests import the pillars by relative path.",
      "gates": "dispatch-gates --commands derived 34 families at 66aa3c5d; 33 run unlocked and pnpm --dir ui exec vitest run scripts/ under the lock (178 files passed, 2 skipped); all 34 exit 0; --ran reconciliation: 34 derived, 34 run, 0 NOT-MEASURED, 0 UNRUN. Outside the derivation: check:i18n-designer-parity exit 0, check:new-line-citations exit 0 (0 new), eslint on the five touched source files exit 0 (0 errors, 16 warnings all on untouched lines). CI check-runs: in_progress at report time.",
      "line_budget": "6 files, +337 / -34 (371 changed lines, under the 3000 threshold); StudioRail.tsx +38/-1, StudioDesignSurface.tsx +37/-33 (most of it the Data map block re-indented after the hoist), en.ts +2, zh.ts +2, changeset +10, test +248.",
      "files_changed": [
        ".changeset/26733-studio-rail-no-matches.md",
        "ui/packages/app-shell/src/views/studio-design/StudioRail.tsx",
        "ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx",
        "ui/packages/app-shell/src/views/studio-design/StudioRail.noMatches-26733.test.tsx",
        "ui/packages/i18n/src/namespaces/studio/en.ts",
        "ui/packages/i18n/src/namespaces/studio/zh.ts"
      ],
      "deviations": [
        "Call sites are not props only in two places: the Data rail's inline filter is hoisted verbatim into a shownObjects const so its length can be handed to the rail (same predicate, same order), and the Automations rail's own no-matches paragraph is deleted so the sentence is not drawn twice. Both stay inside the Claim's file surface.",
        "The sentence reuses the existing engine.list.emptyQuery row (straight quotes) rather than a new studio row with curly quotes, so the existing Automations pin reads unchanged; only the Clear search label is a new row.",
        "Dispatch order's REST example named issue 26845; the card read was 26733, as the seat confirmed.",
        "PR body checkbox 3 left unticked: the repo-wide pnpm lint is CI's run; locally only the touched files were linted."
      ],
      "dogfood_battery": "n/a: no bang in the PR title and no (narrowing) arm",
      "mcp_calls": "0",
      "api_writes": "2: POST /repos/objectstack-ai/objectstack/dispatches (relay pr_create, created PR 26959, read-back 5668 bytes sent and stored, identical) and this report comment through post-stamped.mjs (relay)",
      "open_questions": [],
      "out_of_scope_findings": []
    }

    Generated by Claude Code

  8. objectstack-fleet commented on Oct 28, 2026

    @objectstack-fleet
    ContributorAuthor

    Landed · seat domain:ui#1 · session_01JQwxbZeBv2y91towxasSUT · 2026-10-28T00:17Z

    PR #26959 merged as ee2aaf0f13 (seat record: PR comment 6456210346). The Data, Automations and Access rails share one empty-search state. When a search matches nothing, the rail names the query under the box and offers "Clear search", which empties the box, puts every row back and returns focus to the box. A blank query, or a list that was already empty, keeps the pillar's own empty state. pm:dispatched is removed with the close.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:studioChanging a running app without code — authoring, publish, docs and the portalbugSomething isn't workingdomain:uiDomain lane — seat card indexed by label:pm:seatpriority:p3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions