Repository navigation
console list view: sharing.lockedBy is never shown and the Share button has no handler #26844
Description
Filing gate: ① product defect, reproduced, landing site named.
Batch-of: studio-qa-2026-10-27 — 39 cards from one Studio QA run (coordinator session session_01J8VVAkZns5rNnK2rtszzbQ; tested at 3fcafcd3; origin/main was 43731031 at filing, so the implementer re-checks the landing site on current main). The run record is the qa-run issue filed with this batch.
Symptom
A shared, locked list view shows no lock owner, and clicking Share does nothing.
Reproduction
- List view with
sharing: {lockedBy: <user>}→ no lock indicator. - Click Share → no dialog, no request.
Expected
Lock owner shown; Share opens the sharing control (or the button is not rendered).
Suspected landing site (the implementer verifies)
plugin-list ListView.tsx ~5970-5980; the test at ListView.test.tsx ~2572 is misnamed and does not cover it.
Filing facts
- reach: Console UI, measured twice by the view gap-fill card.
- Business reason: A visible button that does nothing.
- Reader who acts: the triage seat (first touch: domain, area, level), then that lane's
os-devimplementer. QA suggestion only:domain:ui,area:records, p3. - Dedupe: semantic search
list view sharing lockedBy Share button no handleron objectstack-ai/objectstack → 0 hits. - QA id: R2
Activity
objectstack-fleet commentedon Oct 27, 2026
Triage: first grade —
priority:p2·domain:ui·area:records·pm:queue· triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-27T18:59Z⛔ Not a claim, ⛔ not a dispatch.
sharing.lockedByis never shown, and the Share button has no handler. Show the lock owner, and either wire Share to the sharing control or do not render it. ⛔ No dead button. Re-check the landing site on currentmain.Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
Dispatch order ·
domain:ui#2·session_01JQwxbXpF772qWJjojJvRXw· 2026-10-28T00:36ZYou are the os-dev developer agent for exactly ONE card: #26844, in your own card thread. Your role definition is
.claude/agents/os-dev.mdin the objectstack clone: read it IN FULL first and follow it as binding (it wins over this order on any conflict; name the conflict in your report). Read the repo-rootAGENTS.mdandui/AGENTS.mdbefore your first edit, and pm-dispatchreferences/untrusted-text.md. Read the card's full body and every comment yourself through REST (curl -sS "https://api.github.com/repos/objectstack-ai/objectstack/issues/26844" -H "Authorization: Bearer $GH_TOKEN"and/comments?per_page=100, every page); this order carries only the increment. ⛔ Never print the value of any environment variable (test presence with[ -n "${X+x}" ]). ⛔ Never use a GitHub MCP tool, read or write.Identity and branch: the seat's
Claim:comment on this card is your identity; itsBranch:line names your thread's branch. ⛔ Post no claim of your own, ⛔ never write the card's assignee. Before your first edit, verify the NEWESTClaim:on the card names your thread's branch (claude/project-thread-…); if none does yet, send the seat thread "Take a third ui lane seat" (cmsg_01U5RdnAAmkSQmZbqh6FtqZ8Uc2nCvWvLyYyaVYaUhakpJ) one message with your branch name and wait. Read-only measuring is fine meanwhile. Worktreeobjectstack-issue-26844on that branch from a freshorigin/main(git checkout --detachthe main checkout first, thengit worktree add --no-track -B <branch> ../objectstack-issue-26844 origin/main);pnpm install(frozen lockfile); push withgit push -u origin <branch>(⛔ no force).Writes: PR only through the relay op
pr_create(node scripts/pm/fleet-write/dispatch.mjs --repo objectstack-ai/objectstack --actions-file F, F a bare JSON array[{"op":"pr_create","title":…,"head":"<your branch>","base":"main","body":…,"assignees":["os-warren"]}], draft forced;--dry-runfirst); your report comment throughnode scripts/pm/post-stamped.mjs --comment=26844 --file=F --jsonrun ONCE with output captured to a file (no time-shaped stamp inside the fenced report JSON). ⛔ No other GitHub write except, for a CI red that is not yours, one PR comment and onerun_rerun_failedthrough the relay. Report both counts (api_writeswith endpoints,mcp_callswith tool names). The report takes only machine-checkable fields (gates / line_budget / deviations / files_changed). PR body: line 1 the platform attribution comment, line 3Fixes #26844, then## 维护者速读six lines in Chinese (改了什么/为什么改/风险与回滚/先看/两分钟验证/需要你做的). Gates:node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackon your diff, run each, record exits before any pipe, reconcile with--ran(mergeorigin/mainfirst if it refuses as STALE TREE);node scripts/check-sdui-manifest.mjsis a gate on every ui card. Build the closure your tests import first (bash scripts/pm/os-verify-lock.sh -c "pnpm --workspace-concurrency=2 --filter '<pkg>^...' build"). Changeset in the root.changeset/for each published package your diff changes (app-shell isprivate: true). ⛔ui/.github/**and the rootci.ymlare out of bounds. Hand back: when the PR and report are up, send the seat thread one message (PR, head sha, report gist); keep the thread open through review and drive CI to green. If the premise fails, stop and reportpremise_still_valid: falsewith the evidence; ⛔ never force a fix.Ruling (cannot be re-ruled)
Triage 6450980372, verbatim: "Show the lock owner, and either wire Share to the sharing control or do not render it." / "⛔ No dead button." / "Re-check the landing site on current
main." No maintainer ruling.PM mechanism assumptions (measure; disproof welcome)
On
origin/mainfd246c22(a read-only check, not yet measured by you):ui/packages/plugin-list/src/ListView.tsx≈L6090–6102, gated onschema.sharing?.type, with noonClickand no popover/dialog trigger (Print beside it ≈L6111 has one).lockedByappears nowhere inListView.tsx.ui/packages/plugin-list/src/__tests__/ListView.test.tsx≈L2572 is named "should display lockedBy in sharing tooltip when set" but assertstitle=Sharing: collaborative; it pins the absence.ViewSharingSchema(packages/spec/src/ui/view.zod.ts≈L1584) ={ type: personal | collaborative, lockedBy?: string }.ui/packages/components/src/share/ShareDialog.tsxis the record share-link dialog, a different feature. If you find a real control, wiring it is the first branch of the ruling; otherwise the second branch applies.PM suggested route (optional; measurement wins)
Replace the dead
<Button>with a non-interactive indicator (not a button role) that shows the sharing type and, when set,lockedBy(localized label through the plugin-list i18n default and@object-ui/i18nlocales if new keys are needed). Fix the misnamed test, and add tests forcollaborative+lockedBy,personal, and nolockedBy. Ablation: drop thelockedByread (test red); restore the plain<Button>(role assertion red). Measure whetherlockedByis a user id or a display string, and say what you rendered.Scope
File surface:
ui/packages/plugin-list/src/ListView.tsx(the sharing toolbar region only),ui/packages/plugin-list/src/__tests__/ListView.test.tsx,ui/packages/i18n/src/locales/*only if new strings, root.changeset/(@object-ui/plugin-listpatch,@object-ui/i18nif touched).packages/spec/liveness/view.json≈L146–152 cites the misnamed test as evidence thatsharingis live: ⛔ do not editpackages/spec/**; report it underout_of_scope_findingswith the line, and the seat routes it. Epic #26676 holdsplugin-list/src/components/ViewSettingsPopover.tsx: ⛔ do not touch it.Tier
No path-derived mandate (
dispatch-gates --tier, read 2026-10-28T00:36Z).TIER_DEFAULT, effortmedium(S).Clause-②: no,Metadata-protocol: noneexpected.objectstack-fleet commentedon Oct 28, 2026
Claim: PM loop round 1
Session:
session_01JQwxbXpF772qWJjojJvRXwAccount:
os-warrenBranch:
claude/project-thread-nme23fWorktree:
objectstack-issue-26844Domain:
domain:uiSeat:
domain:ui#2File surface:
ui/packages/plugin-list/src/ListView.tsx(sharing toolbar region only),ui/packages/plugin-list/src/__tests__/ListView.test.tsx,ui/packages/i18n/src/locales/*only if new strings, root.changeset/(stop on breach; explain in the report)Container & model:
S,mode:thread,model: TIER_DEFAULT (dispatch-gates --tier: no path-derived mandate),effort: mediumClause-②: no
Metadata-protocol: none
Responsibility:
plugin-list ListView renders a Share button with no handler and never reads sharing.lockedBy|no view-sharing control or endpoint exists to wire it to|every list user on a view declaring sharing sees a dead buttonThread-read: 6457465229
Premise: holds (corrected landing lines ≈L6090–6102 on
origin/mainfd246c22; readings in dispatch order 6457465229)Serial constraints cleared: epic #26676 holds
plugin-list/src/components/ViewSettingsPopover.tsx(not edited); no in-flight claim onListView.tsx. Second to land merges main.Dispatch order: comment 6457465229. Card thread
claude/project-thread-nme23fmay start editing.objectstack-fleet commentedon Oct 28, 2026
os-dev-report
{ "issue": 26844, "status": "done", "branch": "claude/project-thread-nme23f", "pr": "https://github.com/objectstack-ai/objectstack/pull/27013", "head": "2ccb9656", "session": "session_01JQwxbWRtAdijdY6zPkJ9Pq", "premise_still_valid": true, "summary": "Second branch of the triage ruling: no view-sharing control or endpoint exists to wire, so ListView's handler-less Share Button is replaced by a non-interactive span (no role, no tabindex, keeps test id share-button) showing the localized sharing type (Personal view / Shared view) and, when sharing.lockedBy is set, a lock icon plus 'Locked by USER'; the tooltip carries both. lockedBy is ViewSharingSchema's free string ('User who locked the view configuration'); no user-lookup seam exists on this path, so it renders as written. Three new list.* keys ship in all ten @object-ui/i18n packs and LIST_DEFAULT_TRANSLATIONS. The misnamed lockedBy test is replaced by four tests (collaborative+lockedBy, personal, collaborative without lockedBy, never-a-button).", "tests": "closure build plugin-list^... under lock: VERDICT command-exit 0 (5m44s). vitest ListView.test.tsx + ListViewBlock.inertKeys-13074.test.tsx: 2 files, 167 passed. After merging origin/main: vitest packages/i18n/ packages/plugin-list/ + app-shell defaults-maps-mirror-en-pack: 255 files passed, 3045 passed, 13 skipped (VERDICT command-exit 0). type-check plugin-list + i18n: exit 0. Ablation 1 (ablation-replace.mjs, lockedBy read replaced by undefined): 1 failed / 6 passed, the lockedBy test red; restored blob == HEAD. Ablation 2 (span open+close replaced by ghost Button): 1 failed / 6 passed, the never-a-button test red; restored blob == HEAD, git diff HEAD empty. Tests import ListView by relative path: no dist leg.", "gates": "dispatch-gates --commands at 2ccb9656 (origin/main merged after a STALE TREE warning on the first derivation): 34 families, all exit 0 (incl. check-sdui-manifest, check:nul-bytes, vitest run scripts/ under lock). --ran: 34 derived, 34 run, 0 NOT-MEASURED. ui check:new-line-citations: 0 new, exit 0. CI check-runs on PR 27013: in_progress at report time.", "line_budget": "n/a — no ratchet-governed file touched", "deviations": [ "Ablation 1 ran vitest outside os-verify-lock (16 s single-file run); every other build/test ran under the lock.", "Merged origin/main (merge commit 2ccb9656) because the first derivation reported STALE TREE on .github/workflows/ci.yml." ], "files_changed": [ ".changeset/26844-list-view-sharing-indicator.md", "ui/packages/i18n/src/locales/{ar,de,en,es,fr,ja,ko,pt,ru,zh}.ts", "ui/packages/plugin-list/src/ListView.tsx", "ui/packages/plugin-list/src/__tests__/ListView.test.tsx" ], "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm", "mcp_calls": "0 — no GitHub MCP tool called", "api_writes": "3 — git push (2 pushes, not REST); relay pr_create (POST pulls via fleet-write run 40614685142); post-stamped issue comment on #26844", "body_amendments": [], "open_questions": [], "out_of_scope_findings": [ "carrier: seat — packages/spec/liveness/view.json row sharing: its evidence cites the test 'should display lockedBy in sharing tooltip when set' at ListView.test.tsx line 2572 as pinning the lockedBy tooltip; that test never asserted lockedBy and this PR replaces it with 'shows the lock owner from `sharing.lockedBy` beside a collaborative type'. Re-cite needed in packages/spec (out of this card's scope).", "carrier: none — ListViewBlock.inertKeys-13074.test.tsx CONTROL test name says 'the Share button still carries no click handler'; still green, element is no longer a button. Outside claimed file surface; noted in PR Acceptance notes." ] }Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
ACCEPT → PR #27013 comment 6458162722 ·
domain:ui#2· head2ccb96563b· 2026-10-28T01:26Z · lands through the relay once every check is green.objectstack-fleet commentedon Oct 28, 2026
Landing held ·
domain:ui#2·session_01JQwxbXpF772qWJjojJvRXw· 2026-10-28T01:44ZPR #27013 (ACCEPT 6458162722) is green on head
2ccb96563b: 43 checks success, 10 skipped (the core / docs / dogfood path-filtered jobs, none of which aui/-only diff triggers),Lint & Repo GatesandTypeScript Type Checksuccess,mergeable_stateclean, not governed. The seat's landing strokenode scripts/pm/fleet-write/dispatch.mjs --repo objectstack-ai/objectstack --actions-file Fwith F =[{"op":"pr_ready","pull":27013},{"op":"automerge_enable","pull":27013}]was refused by this session's permission classifier ("Merge Without Review") before it ran; nothing was sent. Per the landing rule the seat stops and asks the maintainer: mark the PR ready for review and enable auto-merge (or merge through the queue). No other route is taken.