Repository navigation
test(showcase): add the Reports index to the smoke SURFACES, so /reports stops being a standing hand-walk #28653
Description
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
Filing gate: ① a measured coverage gap in a pinned suite. Found while landing #28641 (W3-C1R row 12, QA run #28545).
Reader: domain:devx (or the showcase owner), one PR on examples/app-showcase/e2e/showcase-smoke.spec.ts (SURFACES) plus the checklist item platform-core.nav-surfaces-render (steps[0]/[2]).
Dedupe (open AND closed): "nav_report_index SURFACES" → 3 hits (#28641, #28545, #27377), none proposes the suite edit.
reach: measured from source at f23e051232: examples/app-showcase/src/ui/apps/index.ts serves 50 showcase_app nav leaves; SURFACES holds 49; the one outside it is nav_report_index (/reports).
QA-source: #28545 · platform-core.nav-surfaces-render · steps[0]/[2]
Checklist item priority: P0
type: Bug
Business reason: the P0 smoke is the release's standing evidence. Since #27525 (the console stopped injecting its own "All reports" row), the report index is a served nav leaf like any other, but the pinned suite does not drive it. Every P0 run therefore hand-walks /reports, and a regression there is caught only if the runner remembers to. #28641 names it as the standing hand-walk; this card ends that.
Wanted
- One
SURFACESentry for the Reports index (nav_report_index,…/reports), with the same render checks as every other entry. - In the same PR:
platform-core.nav-surfaces-rendersteps[0] says SURFACES covers all 50 leaves, steps[2] drops the standing hand-walk,revision+1 with one history row. - ⛔ The suite's existing checks are unchanged; no entry is removed.
Activity
objectstack-fleet commentedon Nov 1, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: p2 ·
domain:devx·area:devpath·pm:queue· 2026-11-01T13:01Z⛔ Not a claim.
SURFACES, so every P0 run hand-walks/reports. The P0 smoke is the release's standing evidence, so p2.SURFACESentry plus the checklist item's steps, in one PR.Generated by Claude Code
objectstack-fleet commentedon Nov 1, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
Claim: PM loop round 3
Session:
session_017ihL2gLghEqeDKTbDTC7ZdAccount:
marchtianBranch:
claude/issue-28653-smoke-reports-indexWorktree:
objectstack-issue-28653Domain:
domain:devxSeat:
domain:devx#2File surface:
examples/app-showcase/e2e/showcase-smoke.spec.ts(SURFACES, add one entry) anddocs/qa/platform-checklist/areas/platform-core.json(platform-core.nav-surfaces-rendersteps[0]/[2], revision +1). ⛔ No existing entry or check is removed or weakened.Container & model:
S,mode:subagent,model: default tier,effort: highClause-②: no
Metadata-protocol: none
Responsibility: n/a — test coverage gap, no product code
Thread-read: 6558298284
Premise: holds
Serial constraints cleared: none (no open PR touches these paths at claim time)
objectstack-fleet commentedon Nov 1, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
os-dev-report
{ "issue": 28653, "status": "done", "branch": "claude/issue-28653-smoke-reports-index", "pr": "https://github.com/objectstack-ai/objectstack/pull/28719", "head": "e630e6434b", "session": "session_017ihL2gLghEqeDKTbDTC7Zd", "premise_still_valid": true, "summary": "Added one SURFACES entry ('All reports', base('reports')) for nav_report_index under the same per-surface checks as every other entry; no entry or check changed. platform-core.nav-surfaces-render revision 9 -> 10: steps[0] says SURFACES covers all 50 served showcase_app leaves, steps[2] drops the standing /reports hand-walk, one history row citing #28653. RUNNER.md's whole-run-red count '49 today' moved to 50 in the same PR (declared in-place fix).", "counts": { "source": "e630e6434b", "nav_leaves": 50, "breakdown": "25 pages, 17 objects, 5 reports, 3 dashboards", "surfaces_before": 49, "surfaces_after": 50 }, "live_run": { "prepared": "turbo run build --filter=@objectstack/example-showcase^... then pnpm console:build (lock VERDICT command-exit 0)", "command": "SMOKE_API_URL=http://localhost:PORT (OS-assigned free port) OS_TEST_CHROMIUM_EXECUTABLE_PATH=/opt/pw-browsers/chromium pnpm -C examples/app-showcase test:smoke e2e/showcase-smoke.spec.ts", "before": "base spec e170d42438: 49 passed (2.1m), lock VERDICT command-exit 0", "after": "e630e6434b: 50 passed (2.0m), 'surface renders cleanly: All reports' passed in 2.0s, lock VERDICT command-exit 0", "content_probe": "signed-in probe of .../reports past the boot splash: no pageerror; main lists 4 named reports under Tasks (Hours by Status (Chart), Hours by Status (Summary), Status x Priority (Matrix), Task Overview (Joined))" }, "tests": "pnpm --filter @objectstack/example-showcase run typecheck (tsconfig includes e2e/**/*): lock VERDICT command-exit 0. Live smoke as in live_run.", "gates": "node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at e630e6434b: exit 0, 42 commands for 3 paths; all 42 exit 0 (exit captured before any pipe), incl. pnpm check:platform-checklist :: exit 0. --ran reconciliation: '42 derived famil(ies) accounted for — 42 run, 0 NOT-MEASURED (a DERIVED zero — all 42 recorded an exit code and none of them is 3)'. CI check-runs: in_progress at report time.", "line_budget": "19 changed lines (+15 / -4) over 3 files vs the 3000 human-merge threshold: under", "files_changed": [ "examples/app-showcase/e2e/showcase-smoke.spec.ts", "docs/qa/platform-checklist/areas/platform-core.json", "docs/qa/platform-checklist/RUNNER.md" ], "changeset": "none; label skip-changeset sent with pr_create and read back on the PR (examples/app-showcase is private; docs/qa only)", "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm", "deviations": [ "RUNNER.md line 257 edited outside the claim's named file surface: the one other place that pinned the SURFACES count (49 -> 50), which this change makes false. Same defect class, a one-number edit, no other claim holds it, same checklist gate family. Declared in the PR body.", "PR body ends with the order's '🤖 Generated with [Claude Code]' line; session attribution is in body prose (Session: line), not the session-URL footer form AGENTS.md names for PR bodies." ], "pins_of_49_elsewhere": "one: docs/qa/platform-checklist/RUNNER.md (updated). No test or self-test pins the count; historical 49s (spec boot-splash comment, #21060 comment, history rows 5 and 9) left as measured records.", "mcp_calls": "0", "api_writes": "2 — fleet-write relay pr_create (POST /repos/objectstack-ai/objectstack/dispatches, run 41320246533 success: POST pulls -> #28719, POST issues/28719/labels skip-changeset); this comment via post-stamped.mjs (POST issues/28653/comments). Plus git push of the branch.", "open_questions": [], "out_of_scope_findings": [ "carrier: none · noted, not filed — acceptance[1] (served-nav vs SURFACES diff) still has no automation: the suite never reads meta/app, so a nav leaf added without a SURFACES entry is caught only by the run's hand diff. Recorded in the PR's Acceptance notes." ] }objectstack-fleet commentedon Nov 1, 2026
domain:devx#2 · marchtian · session_017ihL2gLghEqeDKTbDTC7Zd
Landed · 2026-11-01T15:44Z · PR #28719 merged as
4bf48a8cce(reviewed heade630e6434b, seat record ACCEPT 6559874781). The showcase P0 smoke'sSURFACESnow covers all 50 servedshowcase_appnav leaves, including the Reports index (…/reports). The live run went from 49 to 50 passed.platform-core.nav-surfaces-renderrevision 10 drops the standing hand-walk.pm:dispatchedis removed in this stroke.