Skip to content

Skills record-page rule and eval still teach split beside the list as the default Open records choice, which #28915 retires #29110

Closed

Description

@objectstack-fleet

domain:ui#4 · zhuangjianguo · session_01QsR2jR7ZFkpqmm4U8S1f9y

Filing gate: ① defect with a named location in a shipped surface (skills/**), class b, the Skills-docs: follow-up owed line of PR #29108 (#28915) · filed by domain:ui#4 · ⛔ Not a claim.

Business reason. #28915 makes the drawer the default record opener and retires the split pane, leaving the Display menu's Open records with two choices: Drawer and Full page. The shipped objectstack-ui skill still teaches the old model. An agent that reads it tells an author that records open beside the list by default, and offers a choice that no longer exists.

Location (at origin/main).

  • skills/objectstack-ui/rules/record-page.md:48-49: "the Display menu's Open records (split beside the list — the default — or drawer, or full page; …)".
  • skills/objectstack-ui/evals/record-page.json:24: eval 2's expected_output says "Open records: split, drawer or full page".

reach: named producer. The skill ships in skills/** and is read by agents authoring ObjectStack apps.

Wanted.

  1. Rule 6 of record-page.md names the reader's two choices, drawer (the default) and full page, and says that the split pane beside the list is retired.
  2. The expected_output of eval 2 says the same. Its assertions stay valid, or move with it.
  3. No other skill text changes. Run the skill gates the repo runs for skills/**.

Reader. domain:ui or the docs owner of skills/objectstack-ui, size XS. It runs after PR #29108 lands, so the skill never describes a console that is not yet on main.

Dedupe. Searched skills record-page split default (187 hits, all seat posts, epics and #28915 itself; none is a skills follow-up).

Links back: #28915, PR #29108, #26676.


Generated by Claude Code

Activity

  1. added
    documentationImprovements or additions to documentation
    pm:queueReady for the PM dispatch loop
    domain:uiDomain lane — seat card indexed by label:pm:seat
    on Nov 2, 2026
  2. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Nov 2, 2026
  3. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#3 · zhuangjianguo · session_01QsR2jV4dWohojjbTJTQq5m

    Claim: PM loop round 8 · 2026-11-02T10:16Z
    Session: session_01QsR2jT7tQShSRWpBCBAgea (card thread, os-dev); dispatched by seat session session_01QsR2jV4dWohojjbTJTQq5m
    Account: zhuangjianguo
    Branch: claude/project-thread-fvpiv1 (platform-assigned to the card thread; it can push only this branch)
    Worktree: objectstack-issue-29110
    Domain: domain:ui
    Seat: domain:ui#3
    File surface: skills/objectstack-ui/rules/record-page.md and skills/objectstack-ui/evals/record-page.json, plus a changeset or generated index only if a skills gate requires it (stop on breach; explain in the report). Any other skills/** sentence about the retired split pane is named in the report before it is edited.
    Container & model: XS, mode:thread, model: default tier, effort: medium
    Tier: H (governed path skills/**): lands on an authorized approver's approval, not on the seat's ACCEPT.
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — follow-up owed by PR #29108 (Skills-docs line)
    Thread-read: none
    Premise: holds (at origin/main 45e9b2f1: record-page.md:48-49 still reads "Open records (split beside the list — the default — or drawer, or full page …)" and evals/record-page.json:24 eval 2 still reads "Open records: split, drawer or full page"; PR #29108 retired the split pane and landed at 09:19Z as ea150b7f).
    Serial constraints cleared: PR #29108 has landed, as the card requires. No in-flight claim of seats 1-5 names skills/objectstack-ui.

  4. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#3 · zhuangjianguo · session_01QsR2jT7tQShSRWpBCBAgea
    os-dev-report

    {
      "issue": 29110,
      "status": "done",
      "branch": "claude/project-thread-fvpiv1",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/29259",
      "head": "eaef3b02",
      "session": "session_01QsR2jT7tQShSRWpBCBAgea",
      "premise_still_valid": true,
      "summary": "skills/objectstack-ui/rules/record-page.md rule 6 now names Open records as drawer (the default) or full page, for a drawer-mode object, and says the split beside the list is retired; 'the pane's dragged width' became 'the drawer's' (drawer keeps useDrawerResize and maximize on main). Eval 2 expected_output says a pane beside the list is no longer offered, Open records is drawer or full page, nothing is authored, navigation mode page stays; assertions unchanged and still valid. @objectstack/skills patch changeset. Tier H (skills/**).",
      "files_changed": [
        "skills/objectstack-ui/rules/record-page.md",
        "skills/objectstack-ui/evals/record-page.json",
        ".changeset/29110-record-page-skill-split-retired.md"
      ],
      "line_budget": "20 changed lines (+15/-5). record-page.md 65 -> 65 lines, 3981 -> 3982 bytes, 996 -> 996 tokens (ceiling 996, unchanged). Eval fixture 1899 -> 1972 bytes (not ratcheted). Package SKILL.md sum 4550 -> 4550 lines.",
      "skills_grep": "git grep -iE 'split beside|beside the list|Open records|split pane' skills/ at 0c0d3b68: hits only record-page.md:48 and evals/record-page.json:23-24. No other skill text changed.",
      "tests": "text only; no ui test owed. node scripts/check-skills-token-ratchet.mjs exit 0; JSON parse of the eval file ok.",
      "gates": "dispatch-gates --commands: 43 derived on d0c28e8c; --ran: 40 run exit 0, 3 NOT-MEASURED (exit 3 prerequisite: check:dts-closure, check:dual-build-cjs-loads, check:lean-entry-closure need a full pnpm build; diff touches no package code; CI runs them). check:doc-formula-expressions exit 3 then exit 0 after turbo build of formula+lint (lock VERDICT command-exit 0). check-sdui-manifest exit 0. PR-body gates on the final body: closing-keyword-parity 0, changeset-no-major 0, adr-0087-registration 0, partof-closing-keyword 0. Head eaef3b02 = merge of origin/main touching no skills file; token ratchet re-ran 0.",
      "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
      "deviations": [
        "the word 'pane' in rule 6's 'dragged width and maximize' clause changed to 'drawer' (the only pane left after the retirement); named in the PR body",
        "rule 6 says 'the split beside the list is retired' rather than 'the split pane beside the list': the file sits at its 996-token ceiling and the longer wording priced 997"
      ],
      "mcp_calls": "3 — issue_read get, issue_read get_comments, get_session (reads only)",
      "api_writes": "2 — pr_create via fleet-write relay (PR #29259), this os-dev-report comment via post-stamped; plus git push (not REST)",
      "open_questions": [],
      "out_of_scope_findings": []
    }
  5. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#3 · zhuangjianguo · session_01QsR2jV4dWohojjbTJTQq5m

    Landed: PR #29259 merged at 2026-11-02T12:01Z as 5a2bdf9c, queued by the governed approver (os-zhuang) after the contract review PASS and the seat record. Fixes #29110 closed this card; pm:dispatched removed. Nothing left on this card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationdomain:uiDomain lane — seat card indexed by label:pm:seatpriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions