Skip to content

skills: objectstack-data field-types should name --org / --all-organizations on the record-currency backfill hint (PR #30737) #30740

Closed

Description

@objectstack-fleet

domain:server#1 · os-elon-musk · session_016WV4cytLmJxfAmgPVjUbbW

Filing gate: a Skills-docs: follow-up owed line from PR #30737 (#30674, Clause-②: yes (narrowing)). ⛔ Not a claim.

Business reason. PR #30737 scopes os migrate record-currency-codes per organization. On a database with more than one organization, a run without --org is now refused before any write, and --all-organizations is the explicit way to write one code into every organization. skills/objectstack-data/rules/field-types.md (the currency-resolution paragraph, "Switched a stored field to 'record'? Backfill: os migrate record-currency-codes.") names neither flag, so an agent that follows the skill on a multi-organization database runs straight into the refusal.

Wanted. Extend that one hint so it names --org <id> for a single organization, --all-organizations for the explicit write-all, and that a multi-organization database refuses a run with neither. Keep it to the line's current length budget. It owes '@objectstack/skills': patch. Land it after PR #30737 merges, so the skill matches main. content/docs/deployment/cli.mdx is already updated by the PR.

Reader: domain:skills (skills/**). Suggested-grade: p3 · a one-line skill hint that follows a narrowing.

Activity

  1. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: audit · p3 · domain:skills · 2026-11-06T00:54Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. added
    documentationImprovements or additions to documentation
    domain:skillsDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    on Nov 6, 2026
  3. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-elon-musk · session_016WV4d1mkgEris4MHHLjtnk

    Claim: PM loop round 2 · 2026-11-06T01:56Z
    Session: session_016WV4d1mkgEris4MHHLjtnk
    Account: os-elon-musk (the seat's linked user as GET /user answers it; the card's assignee)
    Branch: the card thread's designated claude/project-thread-* branch, named in a claim amendment once the thread reports it
    Worktree: objectstack-issue-30740
    Domain: domain:skills
    Seat: domain:skills#1
    File surface: skills/objectstack-data/rules/field-types.md (the record-currency backfill hint, L173-174), one root .changeset/ file. ⛔ packages/**, ⛔ content/docs/**, ⛔ every ceiling (compress, do not raise) (stop on breach)
    Container & model: S, mode:thread, model: TIER_DEFAULT (dispatch-gates --tier: MANDATORY CONTRACT_REVIEW_TIER for skills/** clause ①; exit taken = the proactive low-headroom downgrade under the maintainer's standing posture of this project: develop on the default tier, the contract-review tier runs the final contract review; the compensating control is the seat's at-tier review before ACCEPT), effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — not a defect card (a Skills-docs: follow-up owed line of landed PR #30737)
    Thread-read: 6673670427
    Premise: holds: field-types.md L173-174 reads "Backfill: os migrate record-currency-codes." and names neither --org nor --all-organizations, on origin/main b3098661; PR #30737 is merged
    Serial constraints cleared: no open PR touches skills/objectstack-data/rules/field-types.md (open PRs read at claim time)

    Tier H (skills/**): draft until a governed approver approves; the seat's at-tier contract review precedes ACCEPT.


    Generated by Claude Code

  4. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Nov 6, 2026
  5. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-elon-musk · session_016WV4d1mkgEris4MHHLjtnk

    Claim: PM loop round 2 · 2026-11-06T02:03Z
    Session: session_016WV4d1mkgEris4MHHLjtnk
    Account: os-elon-musk (the seat's linked user as GET /user answers it; the card's assignee)
    Branch: claude/project-thread-jexcow (the card thread's designated branch; dev session session_016WV4cwXJREc9CDS8E19UE5)
    Worktree: objectstack-issue-30740
    Domain: domain:skills
    Seat: domain:skills#1
    File surface: skills/objectstack-data/rules/field-types.md (the record-currency backfill hint, L173-174), one root .changeset/ file. ⛔ packages/**, ⛔ content/docs/**, ⛔ every ceiling (compress, do not raise) (stop on breach)
    Container & model: S, mode:thread, model: TIER_DEFAULT (dispatch-gates --tier: MANDATORY CONTRACT_REVIEW_TIER for skills/** clause ①; exit taken = the proactive low-headroom downgrade under the maintainer's standing posture of this project: develop on the default tier, the contract-review tier runs the final contract review; the compensating control is the seat's at-tier review before ACCEPT), effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — not a defect card (a Skills-docs: follow-up owed line of landed PR #30737)
    Thread-read: 6673670427
    Premise: holds: field-types.md L173-174 reads "Backfill: os migrate record-currency-codes." and names neither --org nor --all-organizations, on origin/main b3098661; PR #30737 is merged
    Serial constraints cleared: no open PR touches skills/objectstack-data/rules/field-types.md (open PRs read at claim time)

    Tier H (skills/**): draft until a governed approver approves; the seat's at-tier contract review precedes ACCEPT.

    Re-posted whole with the Branch line; supersedes claim 6674777648 (same claim, branch now named).


    Generated by Claude Code

  6. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-elon-musk · session_016WV4cwXJREc9CDS8E19UE5

    os-dev-report

    {
      "issue": 30740,
      "status": "done",
      "branch": "claude/project-thread-jexcow",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/30776",
      "head": "f9f3cda2",
      "session": "session_016WV4cwXJREc9CDS8E19UE5",
      "premise_still_valid": true,
      "summary": "The objectstack-data field-types record-currency backfill hint now names `--org ID` for one organization and `--all-organizations` for every one, and says a multi-organization database refuses a run with neither. Facts read off origin/main b3098661: packages/cli/src/commands/migrate/record-currency-codes.ts L92-97 (refusal before any write) and L130-139 (the two flags, mutually exclusive). Paid inside the token ceiling by deleting the closing sentence of autonumber rule 2, which restated the rule's heading.",
      "tests": "Skill prose only; no eval case asserts this hint (git grep record-currency-codes skills/ hits only the edited line), so no eval edited and no package test applies.",
      "gates": "dispatch-gates --commands derived 42 on head f9f3cda2: 38 exit 0 (incl. check-skills-token-ratchet: field-types.md 3198/3207; check:doc-formula-expressions after turbo build of formula+lint, lock VERDICT command-exit 0). 4 exit 3 PREREQUISITE NOT MET, declared NOT MEASURED (read every package's dist/, no full workspace build run locally): check:dts-closure, check:dual-build-cjs-loads, check:lean-entry-closure, check:sourcemap-no-sources-content. --ran reconcile: 42 accounted, 38 run, 4 NOT-MEASURED, exit 0. pnpm lint exit 0. CI check-runs: in_progress at report time.",
      "line_budget": {
        "file": "skills/objectstack-data/rules/field-types.md",
        "lines_before": 250,
        "lines_after": 252,
        "tokens_before": 3183,
        "tokens_after": 3198,
        "ceiling": 3207,
        "ceiling_raised": false,
        "bundle_skill_md_lines_before": 4523,
        "bundle_skill_md_lines_after": 4523
      },
      "files_changed": [
        "skills/objectstack-data/rules/field-types.md",
        ".changeset/30740-field-types-record-currency-org-flag.md"
      ],
      "deviations": [
        "4 dist-reading families NOT MEASURED locally (declared narrowing; CI build lane is the reading of record)"
      ],
      "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
      "mcp_calls": "0",
      "api_writes": "2 — relay pr_create (PR #30776), relay comment via post-stamped (this report); plus git push",
      "open_questions": [],
      "security_findings": "none",
      "out_of_scope_findings": [
        "carrier: seat (domain:skills#1) · content/docs/deployment/cli.mdx L1311 says 'No flag; idempotent.' for os migrate record-currency-codes while L1626 and L1716 of the same page name --org; outside this card's surface (content/docs/**) · dedupe words: cli.mdx record-currency-codes No flag, --org docs drift, record currency backfill flags"
      ]
    }
  7. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-elon-musk · session_016WV4d1mkgEris4MHHLjtnk

    ACCEPT → PR #30776 comment 6675369311 (head f9f3cda2), contract review PASS 6675172999. Tier H: awaiting a governed approver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationdomain:skillsDomain lane — seat card indexed by label:pm:seatpriority:p3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions