Skip to content

permission: four texts still say allowRestore / allowPurge "return with M2" after #30237 PR 4 corrected the tombstones (migration entry 18, conversion entry 18, ui permission slice, metadata plugin comment) #31508

Open

Description

@objectstack-fleet

domain:server#3 · os-project-manager · session_01FEkQ5pXkgNXVpCn2GZDjyy

Filing gate: ③ stale prose. #30237 PR 4 (PR #31438) corrects the allowRestore / allowPurge tombstone texts under the maintainer's consent (card #30237 comment 6720657486): restore and purge exist (ADR-0148), and their grants are allowRestoreOwnDeleted / manageRecycleBin. Four more texts outside that consent still say the keys "return with M2". The card thread listed them in its round-1 handback.
Reach:

维护者速读

  • 问题: 旧权限键 allowRestore / allowPurge 的墓碑文字已在 PR feat(security): read the recycle bin's grants for restore and purge (#30237 PR 4) #31438 中改成「操作已存在,请改用 allowRestoreOwnDeleted / manageRecycleBin」。另有四处仍写「随 M2 回归」,其中第 18 号转换条目的摘要会由 os migrate meta 打印给作者看。
  • 影响面: 升级旧元数据的作者会读到错误指引;另外两处只是代码注释。
  • 需要您做的: 第 18 号迁移和转换条目是历史版本记录。spec 车道会先判断这类条目能不能改文字,如果需要您同意,会经评估线程问您。

Task

  • Decide whether a released migration or conversion entry's prose may be reworded. Look for an immutability pin or a precedent. If it may, point the summary and the semantic entry at allowRestoreOwnDeleted / manageRecycleBin (ADR-0148) and regenerate the registry. If it may not, record why on this card.
  • Fix the two code comments (metadata plugin.ts, ui permission-slice.ts).
  • Prose only. No accept-set, conversion behaviour or tombstone change.

Clause-②: no · Metadata-protocol: none.

Precondition: PR #31438 merged. Until then this card is pm:blocked.

Suggested-grade: p3.

🤖 Generated with Claude Code

Activity

  1. added
    documentationImprovements or additions to documentation
    domain:specDomain lane — seat card indexed by label:pm:seat
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    on Nov 8, 2026
  2. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#3 · os-project-manager · session_01FEkQ5pXkgNXVpCn2GZDjyy

    Scope addition · 2026-11-08T12:08Z · from the #31438 at-tier delta review (N2). Two more texts still say the keys "stay denied via DESTRUCTIVE_OPERATIONS … RETURN with M2":

    • packages/spec/liveness/permission.json, the dead rows for allowRestore (:94) and allowPurge (:100);
    • the retiredKeyRemedy docblock in packages/lint/src/validate-retired-permission-residue.ts (~:114-119).

    They belong in this card's task list beside the entry-18 texts.

  3. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: audit · p3 · domain:spec · confirmed · 2026-11-08T12:53Z

    ⛔ Not a claim.


    Generated by Claude Code

  4. objectstack-fleet commented on Nov 8, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#3 · os-project-manager · session_01FEkQ5pXkgNXVpCn2GZDjyy

    Unblocked · 2026-11-08T12:57Z · PR #31438 (#30237 PR 4) merged as 6a708214, so the precondition this card waited on is met. pm:blocked → pm:queue for the spec lane.

  5. added
    pm:queueReady for the PM dispatch loop
    and removed
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    on Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationdomain:specDomain lane — seat card indexed by label:pm:seatpm:queueReady for the PM dispatch looppriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions