Skip to content

check:react-declaration-parity 是唯一没接进任何 workflow 的源码审计门禁,且无 MANIFEST 时静默 skip 退出 0 —— 它现在永远不可能红 #4690

New issue
New issue
Closed
#5959
Closed
check:react-declaration-parity 是唯一没接进任何 workflow 的源码审计门禁,且无 MANIFEST 时静默 skip 退出 0 —— 它现在永远不可能红#4690
#5959
Assignees
baozhoutao
Labels
pm:dispatchedDispatched to a dev agent by /pm-dispatchpm:queueReady for the PM dispatch looptoolingFix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface

Description

@os-zhuang
os-zhuang
opened on Aug 2, 2026

在 #4688(双源 C11)跑源码审计组时顺手发现,与该簇无关,按第十条军规立此单记录,未开工。

现象

check:generated 把 8 个「无生成物的纯源码审计」列为 deliberately-not-run。逐个核对它们在 CI 里的落点:

门禁 接进的 workflow
check:liveness spec-liveness-check.yml
check:empty-state spec-liveness-check.yml
check:variant-docs lint.yml + spec-liveness-check.yml
check:strictness-ledger lint.yml + spec-liveness-check.yml
check:exported-any lint.yml
check:dual-source-exports lint.yml
check:skill-examples lint.yml
check:react-declaration-parity 无 —— 不在任何 workflow 里

复现:

$ grep -rl "check:react-declaration-parity" .github/workflows/
# (无输出)

而且即便有人手工跑,不带 MANIFEST 时它也不做任何事:

$ pnpm --filter @objectstack/spec check:react-declaration-parity
⚠ react-blocks declaration parity: manifest unavailable (set MANIFEST=…) — skipping.
$ echo $?
0

两件事叠起来:这个门禁当前不存在任何一条能让它变红的路径。 没接 CI,手工跑又默认 skip 并退出 0。

为什么值得单独记一笔

  1. AGENTS.md 里专门有一段讲这个门禁的历史 —— 它原名 check:react-conformance,声称能确认组件「ACTUALLY implement」spec props,而它根本做不到;kind:'react' 页面上 record:* 四个 block 全部失效——契约 publish 的 objectName/recordId 渲染器根本不读（#4340 后续） #4413 就这样让 4 个 dead block 从它的绿灯里过去了,check-react-blocks-conformance 比的是两份声明，不是声明↔实现——#4413 全程它都是绿的（Prime Directive #10 落在门禁自己身上） #4472 才改名并重新定范围。文档的结论是「The gate is still worth having(spec-only / registry-only / missing 是真信号)」。既然值得有,它就该真的会红。

  2. 这正好撞在 AGENTS.md「Route & surface ownership」第 3 条上:Absence must be loud —— 「a verifier that silently degrades (reusing a stale build, skipping a check it could not run) is worse than no verifier, because it reports success. Prefer failing to falling back.」跳过 + 退出 0 就是这条描述的那个反面样本。

  3. 它和已知的门禁洞(spec 门禁盲区:可作者化 key 的「默认值 / 约束」变更不被任何 gate、tombstone 或 conversion 记录(#4650 / #4659 同族) #4666 默认值/约束不被记录、authorable-surface 的 tombstone 门禁可被手编基线绕过 —— 删掉基线行就删掉了证据(#4638 / #4643 已两次这样过绿) #4650 手编基线、build-schemas.ts 检查 (b) 用叶名匹配 conversion surface —— 无关簇的 .type 就能让一个 tombstone 冒充「已登记迁移」 #4659 绿≠登记正确、packages/spec 的「编译期 pin」是失效的:tsconfig 排除了 *.test.ts,vitest 也不做类型检查 #4642 编译期 pin 空转)是同一族但不同的问题:那些是「门禁看不见某类变化」,这个是「门禁根本没被调用」。检索 open issue 未见重复。

可能的处置方向(留给维护者定,未做取舍)

  • 接进 lint.yml,并让缺 MANIFEST 时报错退出非 0,而不是 skip —— 符合「Prefer failing to falling back」。
  • 或者:如果 manifest 在本仓天然拿不到(它来自 sibling repo objectui 的 registry config),那"接不进 CI"本身才是根因,需要先决定 manifest 从哪来;在那之前至少让 check:generated 把它标成「结构上无法运行」而不是与其余 7 个并列的「deliberately not run」,后者读起来像是有人跑。

关联

#4472(改名 + 重定范围)、#4413(4 个 dead block 从绿灯过)、#4203 / #4232(未分类脚本导致的门禁休眠先例)、#4688(发现时的上下文)

Generated by Claude Code

Activity

  1. os-zhuang
    added
    toolingFix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface
    pm:queueReady for the PM dispatch loop
    domain:devxDomain lane — seat card indexed by label:pm:seat
    on Aug 3, 2026
  2. xuyushun441-sys
    added
    domain:specDomain lane — seat card indexed by label:pm:seat
    and removed
    domain:devxDomain lane — seat card indexed by label:pm:seat
    on Aug 3, 2026

  3. xuyushun441-sys commented on Aug 3, 2026

    @xuyushun441-sys
    xuyushun441-sys
    on Aug 3, 2026 – with Claude
    Collaborator

    改标:domain:devx → domain:spec(按锚定规则,落点在 packages/spec)

    domain:* 的锚定规则(#4824 刚落地的 Domain lanes 一节)是:

    an issue's domain:* label is the domain of the package the fix lands in, decided at triage by reading the code — never guessed from the issue's title vocabulary.

    本条读起来像 devx(「门禁没接线」是典型的工具面话题),但落点全部在 packages/spec:

    • 脚本定义:packages/spec/package.json:217 → "check:react-declaration-parity": "tsx scripts/check-react-blocks-declaration-parity.ts"(即 packages/spec/scripts/);
    • baseline:packages/spec/react-declaration-parity.baseline.json;
    • 修复要动的两处(接进 workflow、去掉「无 MANIFEST 时静默 skip 退出 0」)也都以这两个文件为中心。

    按域表 packages/spec 及其生成物 = domain:spec,归 spec 车道会话(session_0176qgxgCXTJCUv4YFLtusP9)。这与 #4775 那个反例同形:话题像 A、落点在 B,按话题打标就会把单路由给一个不在那个包里的 PM。

    改标不是认领(「Labeling ≠ claiming」)—— 本会话不认领本条,也不派发。spec 车道会话可从自己的 backlog 扫描里接。

    顺带一句给接手方,与本条主旨直接相关:本 issue 已经被当成反面教材引用了两次 —— #4804 与 #4777 的验收条款里都写着「一个只在当前 main 上绿的门禁,无法证明它抓得到东西,参见 #4690」。也就是说这条门禁的失效形态已经变成了别人写验收标准时的参照物。修它的时候值得连带把「这个门禁能红」本身做成可验证的(在已知违规的 commit 上必须报出来),否则修完还是同一个问题。

    Generated by Claude Code

  4. xuyushun441-sys
    added
    domain:spec-tooling
    and removed
    domain:specDomain lane — seat card indexed by label:pm:seat
    on Aug 4, 2026
  5. akarma-synetal
    added 7 commits that reference this issue on Aug 4, 2026

    feat(devx): gate the "startup registry verdict" class — read the regi…

    799d098

    fix(devx): `check:i18n` fails on an undeclared authoring key, not jus…

    f4847a6

    fix(scripts): check:doc-authoring 覆盖 .claude 语料,worktrees 进 SKIP_PATHS (

    3edff5c

    fix(tooling): derive the docs-audit scope from the filesystem instead…

    6bc93dc

    fix(tooling): fail check-doc-authoring by name when a declared ROOT i…

    bf973ae

    chore(ci): gate job-level `if:` reads of needs.*.outputs.* on naming …

    a3d9c67

    fix(ci): Check Changeset 实时读 skip-changeset 标签,首个 run 不再永久红 (objectst…

    a9c7e6b

  6. 56 remaining items

  7. akarma-synetal
    added 9 commits that reference this issue on Sep 17, 2026

    fix(pm): H19 judges a `Blocked-by:` block against the body's target s…

    2070a1d

    fix(devx): pin `Governed Surface Queue Guard` as the seventh REQUIRED…

    08a363a

    fix(pm): check-governed-merges binds the rearm plan its INCOMPLETE ba…

    3aaea38

    fix(scripts): refuse a PR that modifies or deletes a changeset it did…

    0ffb496

    fix(pm): bind H31's carrier pair through the closing keyword (objects…

    ecf91cb

    fix(pm): judge a review of record's `Served-tier:` line on every pair…

    fd12471

    fix(agents,gates): the merge queue blocks on seven contexts, and a se…

    1297178

    fix(settings,pm): deny the MCP enqueue class — enable/disable_pr_auto…

    ceb6b5f

    fix(devx): both `--self-test` harnesses measure the host bash instead…

    bdd0570
  8. akarma-synetal
    added 6 commits that reference this issue on Sep 28, 2026

    fix(pm): declare ISSUE_BODY_LIMIT from a measurement, in the unit the…

    8904880

    fix(scripts): check-bash32-floor refuses a census with a hole in it i…

    a2cf0f1

    fix(scripts): make the Check Changeset refusal say which refusal it is (

    c9a0902

    fix(scripts): derive check-changeset-no-major's level headline from t…

    5d0ee8f

    fix(scripts): give every throwaway-repo git child an environment of i…

    c229223

    fix(ci): derive a gate's population through composite actions, not ju…

    c334ba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

pm:dispatchedDispatched to a dev agent by /pm-dispatchpm:queueReady for the PM dispatch looptoolingFix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions