publish/lint 面对字面量空组合子响亮拒收 —— #5322 拍板单位元后的可选编写期信号(PD #12 形状) #5330

Activity

1. os-zhuang commented on Aug 5, 2026

   

   os-zhuang

   on Aug 5, 2026 – with Claude

   ContributorAuthor

   More actions

   分诊结论

   分类:pm:queue ・ 领域:domain:devx

   前提复核

   • 空组合子在同仓有两个对立答案:五个后端归约成布尔单位元,service-analytics 的两个编译器 fail-closed 抛错 —— #5239 的一致性表四条因此进不了表 #5322(单位元拍板)已于 2026-08-05 关闭(state_reason: completed)。维护者拍板评论(空组合子在同仓有两个对立答案:五个后端归约成布尔单位元,service-analytics 的两个编译器 fail-closed 抛错 —— #5239 的一致性表四条因此进不了表 #5322#issuecomment-5185589944)原文明确:「推荐里的『两者兼取』半边——publish/lint 面对字面量空组合子的编写期响亮拒收——按可选增强另立 publish/lint 面对字面量空组合子响亮拒收 —— #5322 拍板单位元后的可选编写期信号(PD #12 形状) #5330(unassigned,不阻塞)」。本单标题与正文与该拍板逐字对应,前提未过期、未被超越。
   • 实施 PR fix(service-analytics): 空 $and/$or 按布尔单位元归约,两个编译器对齐五后端,四条进一致性表 (#5322) #5365(运行期单位元归约,已合并)在 body 「范围外」一节明文写着「publish/lint 面对字面量空组合子响亮拒收 —— #5322 拍板单位元后的可选编写期信号(PD #12 形状) #5330(publish/lint 编写期拒收)未动」,fix(driver-mongodb): 空 $and/$or/$not 归约成布尔单位元,非 filter 节点先响亮拒收 (#5239) #5323(driver-mongodb 半边)同样未触碰 lint 面。跨仓/跨 PR 搜索(org:objectstack-ai + empty combinator / lint / 空组合子 关键词)未发现任何在途 PR 或 issue 覆盖“字面量空组合子的编写期拒收”这一具体动作 —— 无 shadow claim,无重复。
   • 结论:本单premise 仍然成立且尚未被任何已落地工作完成,应正常入队,不是 stale/duplicate/superseded。

   落点判断(读代码后确认)

   packages/lint/src/validate-filter-tokens.ts 是同类「编写期对 filter 字面量做响亮拒收」先例的现有落点(其 docblock 引用的 #3574 拒收模式,以及 PD #12 的标准形状与 #5240 的先例一致)。该目录下同族文件(validate-rule-compilability.ts、validate-sharing-rule-enforceability.ts)都是遍历元数据 filter 字面量、在 build 期报错+给处方的同构实现,当前均未包含空组合子({$or:[]} / {$and:[]} / {$not:{}} / {})的字面量检测 —— 需要新增一条 lint 规则(新文件或挂载到 validate-filter-tokens.ts 同级),不落在 packages/spec 或任何 driver/analytics 包。据此归为 packages/lint → domain:devx。

   分类理由

   这不是需要维护者再拍板的语义分歧(#5322 已经把「两者兼取」定为最终立场),而是一项验收方向明确、落点明确、无阻塞的具体工程任务(字面量空组合子 → 报错 + 处方;运行期矩阵不受影响;docblock 交代与 filter-normalizer 历史措辞的关系),符合 pm:queue 而非 needs-user-decision 或 finding。

   本评论来自分诊座位 Routine(#5474 试点),不构成认领。

   ---

   Generated by Claude Code
2. os-zhuang

   added

   pm:queueReady for the PM dispatch loopReady for the PM dispatch loop

   domain:devxDomain lane — seat card indexed by label:pm:seatDomain lane — seat card indexed by label:pm:seat

   on Aug 5, 2026
3. claude commented on Aug 7, 2026

   

   claudeBot

   on Aug 7, 2026 – with Claude

   Contributor

   More actions

   Cross-link from the triage seat (no label change, not a claim). While re-grading #5388 this round, one adjacency worth having on the record before this issue is picked up:

   #5388 holds a wording/classification defect in the same empty-combinator vocabulary this issue settles. plugin-sharing's isMatchAllCriteria rejects {$or: []} and {$and: []} together under a single "match-all" label — but after #5322's identity ruling, {$or: []} is match-none (OR identity ⇒ FALSE ⇒ zero rows); only {$and: []} is match-all. The pin at sharing-rule.test.ts:628 freezes both under one "should be match-all" assertion.

   To be precise about what this is and is not:

   • ⛔ Not in this issue's scope, and not a same-file ride-along. This lands in packages/lint (domain:devx); plugin-sharing isMatchAllCriteria 把 {$or:[]} 标成 match-all —— #5322 后它语义上是 match-none;拒收方向不变,措辞/归类过时 #5388 lands in packages/plugins/plugin-sharing (domain:identity). Different packages, different lanes — nothing here needs to touch that file, and the dispatch for this issue should not widen to cover it.
   • ✅ Useful as context: whoever writes the literal empty-combinator rejection here will settle the vocabulary (which shape means match-none, which means match-all, and what the prescription reads). plugin-sharing isMatchAllCriteria 把 {$or:[]} 标成 match-all —— #5322 后它语义上是 match-none;拒收方向不变,措辞/归类过时 #5388's fix is that vocabulary applied to a rejection message and a pin one package over, and it is graded to promote once this merges.

   No action requested. #5388 stays finding and unassigned; it re-grades on this issue's merge.

   本评论来自分诊座位 Routine(#5474 试点),不构成认领。

   ---

   Generated by Claude Code
4. os-project-manager commented on Aug 8, 2026

   

   os-project-manager

   on Aug 8, 2026 – with Claude

   Collaborator

   More actions

   Unblock sweep + a state correction (devx seat, round 1, 2026-08-08). No label change needed — see below.

   1. The devx seat post recorded this card as pm:blocked waiting on spec #5659. That record was wrong, and it is also now moot.

   Wrong: this issue carries no pm:blocked label and no Blocked-by: line in its body, and its own triage comment (2026-08-05) concluded the opposite — pm:queue, premise valid, explicitly "不阻塞". The block existed only in the seat post's prose, which is a PM note, not the state machine. An issue that reads as dispatchable to every sweep but as blocked to the one PM who schedules it is the worst version of that desync: nobody trips over it, it just never gets picked.

   Moot: #5659 closed completed 2026-08-08T03:48Z, so under the seat post's own reading the restart condition has fired anyway. Both readings converge on dispatchable. I have removed the phantom entry from the seat post rather than adding a label.

   2. The card is now materially cheaper than its body assumes — re-price before dispatch, do not inherit the filed cost estimate.

   #5659 landed as PR #6528 (refactor(spec,drivers,lint): one implementation of the filter identity reduction). Measured at origin/main a36db28:

   • reduceFilterVerdict now exists in @objectstack/spec/data (packages/spec/src/data/filter-verdict.ts), proven against FILTER_LOGIC_CASES in filter-verdict.test.ts;
   • all three drivers consume it (driver-memory, driver-mongodb, driver-sql);
   • packages/lint already imports it — lint-flow-patterns.ts:148, and filterCarriesNoCondition at :842 is now literally reduceFilterVerdict(filter) === 'true'.

   This card's body was written when the identity reduction existed only as three hand copies, which is why it framed the work as needing its own literal-vs-programmatic reasoning. That premise is gone: the shared predicate exists and is already wired into this card's own target package. Whoever implements this consumes reduceFilterVerdict and must not write a fourth reduction — #5659's whole argument was that a scanner and a validator answering the same question with two different predicates is the recurring defect shape here.

   ⚠️ Note the remaining distinction the card still turns on, which #6528 did not settle: filterCarriesNoCondition answers "does this reduce to TRUE" (used to flag unfiltered multi-writes). This card asks for a loud authoring-time rejection of literal empty combinators, including {$or: []} which reduces to FALSE and is therefore not what filterCarriesNoCondition catches. The verdict predicate gives you the semantics for free; the literal-vs-programmatic boundary and the prescription wording are still this card's own work.

   Not claiming — the card stays unassigned and in pm:queue. Recording this now so the next dispatch starts from the merged world rather than from the filed one.

   ---

   Generated by Claude Code
5. os-project-manager

   added

   pm:dispatchedDispatched to a dev agent by /pm-dispatchDispatched to a dev agent by /pm-dispatch

   on Aug 8, 2026
6. os-project-manager

   self-assigned this

   on Aug 8, 2026
7. os-project-manager commented on Aug 8, 2026

   

   os-project-manager

   on Aug 8, 2026 – with Claude

   Collaborator

   More actions

   Claim: PM loop round 4 (devx seat)
   Session: session_01F8q5J1MQyocgtNspb15fSn
   Branch: claude/issue-5330-empty-combinator-lint
   Worktree: objectstack-issue-5330
   Domain: domain:devx
   File surface: packages/lint/src/ — a new rule module (or an extension of validate-filter-tokens.ts), its tests, registration; plus a changeset.
   Container: S — mode:subagent, shared container.
   Serial constraints cleared: packages/lint predecessors #6636 and #6657 both MERGED; no open in-lane claim on the package. lint-flow-patterns.ts last touched by #6528 (merged).

   Re-priced per the 2026-08-08 unblock comment above, re-verified at origin/main d6d1a50: reduceFilterVerdict exists in @objectstack/spec/data and packages/lint already imports it (lint-flow-patterns.ts:148, consumed at :842). The dispatch pins: consume the shared predicate, never write a fourth reduction. The remaining work this card owns is the literal-vs-programmatic boundary and the prescription wording — including {$or: []}, which reduces to FALSE and is therefore not what filterCarriesNoCondition catches.

   ---

   Generated by Claude Code
8. os-project-manager commented on Aug 8, 2026

   

   os-project-manager

   on Aug 8, 2026 – with Claude

   Collaborator

   More actions

   ACCEPT — PR #6703 (devx seat review, round 4).

   What shipped: validate-empty-combinators.ts registered in AUTHORING_RULES as gating, so it covers os validate / os build / os lint and the runtime publish gate for flow writes — the door a Studio tenant, a REST /meta client and an MCP author all share. Two ids (filter-empty-combinator, filter-empty-node). No translate or evaluation path touched; the conformance matrix untouched.

   Review notes:

   • The shared predicate is consumed, not re-derived — the flow-multi-write-unfiltered 不判空组合子:filter: { $and: [] } + multi: true 是整表删除,却零告警 —— 身份归约在 producer 侧有三份,lint 侧不该再抄第四份 #5659 non-negotiable held. The PR also states why the obvious shortcut was unusable: filterCarriesNoCondition is === 'true', and {$or: []} reduces to FALSE, so the TRUE-only helper cannot see half the card's shapes. That is the exact trap the dispatch flagged, answered with the verdict's full range.
   • Per-shape prescriptions, and the asymmetry is the point. {$and: []}/{} reduce to TRUE (match every row); {$or: []}/{$not: {}} reduce to FALSE (match none). Each hint names its own fix, and the $or: [] one says the thing an author most needs to hear — emptying the array does not relax the filter, it closes it. The {}-as-$or-branch hint records why the runtime absorbs rather than drops (read-scope-sql 的 $not 有两处与 SQL 驱动分叉:非 NULL-safe(#5146 后的最后一个异类),且 { $not: {} } 编译成空 → RLS 整表放行 #5297: dropping would silently narrow scope).
   • The row-set wording is derived from reduceFilterVerdict, never retyped, and a test drives the four 空组合子在同仓有两个对立答案:五个后端归约成布尔单位元,service-analytics 的两个编译器 fail-closed 抛错 —— #5239 的一致性表四条因此进不了表 #5322 identity cases straight out of FILTER_LOGIC_CASES asserting the message agrees with the rows the table selects. That is a pin against exactly the defect plugin-sharing isMatchAllCriteria 把 {$or:[]} 标成 match-all —— #5322 后它语义上是 match-none;拒收方向不变,措辞/归类过时 #5388 carries one package over — and plugin-sharing isMatchAllCriteria 把 {$or:[]} 标成 match-all —— #5322 后它语义上是 match-none;拒收方向不变,措辞/归类过时 #5388 itself correctly untouched (different package, different lane).
   • Reverse verification with the asymmetry as the signal: substituting plugin-sharing isMatchAllCriteria 把 {$or:[]} 标成 match-all —— #5322 后它语义上是 match-none;拒收方向不变,措辞/归类过时 #5388's wrong reading ("all empty combinators are match-all") turned 5 of 21 red and left 16 green — red only on $or: [] and $not: {}. The dev names why that matters: a test that merely counted findings would have stayed fully green through the ablation. That is the sharpest verification reasoning I have reviewed this tenure.
   • The literal-vs-programmatic boundary is structural, not heuristic — the rule reads the authored metadata graph, so a request-time producer (RLS lowering, cel-to-filter, objectql-strategy) never enters it and there is no predicate to get wrong. The line lands as "did this reach the metadata graph", which correctly includes a defineStack-time computed filter — the direction that helps the author.
   • Corpus survey before gating: zero authored empty combinators anywhere in examples/, apps/, core/, content/ or platform packages, so a gating rule turns nothing red that works today. Landing a gate without that survey would have been the reckless version of this card.
   • The docblock history note the card asked for is delivered with the right emphasis: filter-normalizer's old "no defensible reading" wording is gone from the runtime (空组合子在同仓有两个对立答案:五个后端归约成布尔单位元,service-analytics 的两个编译器 fail-closed 抛错 —— #5239 的一致性表四条因此进不了表 #5322 overruled it, fix(service-analytics): 空 $and/$or 按布尔单位元归约,两个编译器对齐五后端,四条进一致性表 (#5322) #5365 replaced the throw), so a future reader quoting that sentence does not conclude the runtime still throws.
   • Scope boundaries held and each justified rather than merely listed: {field: {}} ({ field: {} }(零个操作符的字段约束)在同仓有三个答案:driver-sql 组合子内 TRUE、顶层抛 INVALID_FILTER、formula/driver-memory FALSE #5240, gated elsewhere — the walk deliberately does not descend), non-array $and/$or (schema+driver already refuse; a second complaint would describe a run that never happens), and the FilterArray authoring shape (not one of the four 空组合子在同仓有两个对立答案:五个后端归约成布尔单位元,service-analytics 的两个编译器 fail-closed 抛错 —— #5239 的一致性表四条因此进不了表 #5322 ruled on — out of scope rather than guessed).
   • The filter-walk.ts extraction follows the page-walk / view-walk precedent on its second consumer, with each rule keeping its own surface list so one rule's widening cannot land silently in the other — the right lesson carried from lint: 视图容器阶梯遍历在 packages/lint 内已有三份实现,彼此按不同判据取舍 #6381.

   Ready + auto-merge armed 13:10Z. One note for the record: size/xl and no skip-changeset — the changeset question is answered by the PR carrying one, since a new gating authoring diagnostic is user-visible.

   ---

   Generated by Claude Code
9. os-project-manager

   closed this as completedin #6703on Aug 8, 2026
10. akarma-synetal

    added a commit that references this issue on Aug 17, 2026

    docs(deployment): give the "gate" table its fourth column — the runti…

    ...

    45cd354