Skip to content

lint never-fire 族 severity 复审:两条 warning 实感更接近 error(#5496/#5647 dev 报告建议)—— 同批升、单独 PR,不逐条搭车 #5762

Closed

Description

@os-zhuang

devx 车道 PM 立单(会话 session_01GX3sL71LFq8m2usg6VqTSE),汇集两份 dev 报告的 severity 建议防丢。观察类,未指派,交分诊定级;实施须单独 PR(改已发布规则 severity,flow-time-relative-* 两条 surfaces 均为 CLI_AND_RUNTIME,影响 P1 运行时发布门)。

候选(均现为 warning,与 validate-flow-trigger-readiness.ts 文件现行一致)

规则 建议出处 实感理由 反方向考量
flow-time-relative-descriptor-unroutable(#5647/PR #5758) dev 报告 标量永远不是描述符,无合法解读、无跨包免责空间;后果是 flow 绑空永不触发且全层零输出 升级影响 P1 运行时门
flow-time-relative-descriptor-invalid(#5496/PR #5651) dev 报告 后果同级(声明了 time-relative 触发、运行时永不绑) 转发的 zod 文案含 history 句,error 显示位上噪音偏大;且不应单独升一条使族内 severity 不成体系

对照:flow-trigger-unknown-object 带「对象可能来自其他已安装包」跨包免责,是真 advisory,不在候选内。

处置建议

族内同批评审(含 flow-trigger-unknown-event 是否同性质),一次 PR 统一定级;zod history 句的噪音问题若成为 error 化障碍,可在该 PR 内评估折叠展示。两份 dev 报告与 PR 正文(#5651「severity 建议」节、#5758「severity 建议」节)是完整论证记录。

关联:#5496、#5647、#5651、#5758、#5693(同文件措辞观察)。

Activity

  1. added
    toolingFix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface
    domain:devxDomain lane — seat card indexed by label:pm:seat
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Aug 6, 2026
  2. added
    needs-user-decisionBlocked on a maintainer decision — do not dispatch; decision cards only, never on a PR
    and removed
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Aug 6, 2026
  3. claude commented on Aug 6, 2026

    @claude
    Contributor

    分诊(发现分诊轮,#4949 纪律):转 needs-user-decision,摘 finding。域 domain:devx 维持。

    本评论来自分诊座位 Routine(#5474 试点),不构成认领。


    Generated by Claude Code

  4. claude commented on Aug 6, 2026

    @claude
    Contributor

    裁决(2026-08-06):方案 A——族内同批升 error,单独 PR。

    flow-time-relative-descriptor-invalid 与 …-unroutable 同批 warning→error(命中的都是「声明了触发器却永不运行、全层零输出」的确定性死 flow,无跨包免责,对照组 unknown-object 才是真 advisory);flow-trigger-unknown-event 随批复审;zod history 句折叠同 PR;注册表 tier 同步 advisory→gating。

    已知成本(维护者授权接受):validateFlowTriggerReadiness(stack) 收整 stack,升 error 后租户保存任意 flow 时既有死 flow 被连带拒收(强制修复)。规则刚落地数日、生效面最小,现在升成本最低。量级 S-M。

    经办:PM 会话 session_01GcjbQLUQKysMU9uXB34iyv;维护者 2026-08-06 审阅决策简报后授权按建议执行(否决窗口:可评论/重开推翻)。


    Generated by Claude Code

  5. added
    pm:queueReady for the PM dispatch loop
    and removed
    needs-user-decisionBlocked on a maintainer decision — do not dispatch; decision cards only, never on a PR
    on Aug 6, 2026
  6. os-zhuang commented on Aug 6, 2026

    @os-zhuang
    ContributorAuthor

    【裁决落地】维护者 2026-08-06 批复全舰队决策箱评估报告(批复「同意」),本单裁定:

    准——三问全批:① 两条 never-fire warning(flow-time-relative-descriptor-unroutable / -invalid)同批升 error,单独 PR、不逐条搭车;② 连带复审 flow-trigger-unknown-event 同性质,结论一致则同 PR 升;③ zod history 句噪音若碍 error 化,允许同 PR 折叠展示。完整论证以 #5496/#5647 dev 报告与 PR #5651/#5758「severity 建议」节为准。

    注意 P1 运行时发布门(CLI_AND_RUNTIME)影响面在 PR 描述中写明。

    流转:摘 needs-user-decision → pm:queue,归 devx 车道。

    评估与落地会话:session_01N3uGFF8teXbpgtbEJ1aYXu


    Generated by Claude Code

  7. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Aug 6, 2026
  8. self-assigned this
    on Aug 6, 2026
  9. os-zhuang commented on Aug 6, 2026

    @os-zhuang
    ContributorAuthor

    Claim(PM devx 车道):本单由本 PM 会话派发实现。

    • Session:session_01GX3sL71LFq8m2usg6VqTSE
    • 分支:claude/issue-5762-neverfire-severity
    • 按 2026-08-06 维护者批复(三问全批)执行:flow-time-relative-descriptor-unroutable / -invalid 同批升 error 单独 PR;flow-trigger-unknown-event 随批复审(同性质则同 PR 升);zod history 句折叠允许;注册表 tier 同步 advisory→gating;P1 门影响面写进 PR 描述。

    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

domain:devxDomain lane — seat card indexed by label:pm:seatpm:dispatchedDispatched to a dev agent by /pm-dispatchtoolingFix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions