[finding] filter-normalizer 的 $not allowNull 守卫在 #5298 第二批之后变成冗余的第二层(谓词等价,SQL 多一层括号) #6005

Activity

1. os-zhuang

   added

   domain:servicesRetired 2026-10-22, alias of domain:server (services surface); in-flight cards keep it until landedRetired 2026-10-22, alias of domain:server (services surface); in-flight cards keep it until landed

   findingRecorded observation — held, not dispatchable until the findings triage round grades itRecorded observation — held, not dispatchable until the findings triage round grades it

   on Aug 6, 2026
2. claude commented on Aug 6, 2026

   

   claudeBot

   on Aug 6, 2026 – with Claude

   Contributor

   More actions

   发现分诊轮(#4949 纪律):持有(留 finding),域维持 domain:services。

   • 过时前提检查(origin/main 9e3709a):出处 PR fix(analytics): $ne / $nin / $notContains 在 Cube 面保留无值行 (#5298 第二批) (#5977) #6004([#5298 第二批] filter-normalizer(Cube 面)NULL-safe 对齐:先实测既有 NULL 行为,分叉则改写;N1 入表按后落地者规则 #5977 / 非否定路径上的 $ne / $nin / $notContains:driver-sql 排除 NULL 行,driver-memory / formula 返回它们(#5146 只裁定了 $not) #5298 第二批)已 MERGED ⇒ 叶子层守卫已在 main 上,allowNull 支的冗余是现状(不是对在飞 PR 的预测)。前提成立。
   • 为什么不晋级:收益是可读性 / SQL 噪音,不是正确性 —— 正文已给出等价性证明(X OR (X OR Y) ≡ X OR Y;多算子 spec 上靠分配律 (c IS NULL OR (X AND Y)) ≡ (c IS NULL OR X) AND (c IS NULL OR Y)),且 PR fix(analytics): $ne / $nin / $notContains 在 Cube 面保留无值行 (#5298 第二批) (#5977) #6004 已实测钉住极性未被拓宽。而成本不为零:删肢要按 fixture 三分诊重新逐条判 filter-normalizer-not-null-safe.test.ts 里 $not 的语义在 driver-sql 与 driver-memory / formula 之间分叉：NULL 行的去留相反，$not: {} 一个是 TRUE 一个是 FALSE #5146 的钉子,其中至少一条($not of $ne 的生成 SQL 断言)会跟着变形。零正确性收益 + 需要动别人的钉子,这个比例不该占派发位。
   • 为什么不关(not planned):它是一条真实的、已量化的冗余($not 的语义在 driver-sql 与 driver-memory / formula 之间分叉：NULL 行的去留相反，$not: {} 一个是 TRUE 一个是 FALSE #5146 header 本就把「引擎路径守卫两次、幂等」写成已接受的代价,本条是同一笔代价又叠一层),而且 requireValue 支仍然必需这一点需要留档 —— 关掉后下一个人删肢时很可能连 requireValue 一起判错。
   • 重启条件(两条,任一成立即处置):① [finding] 仓内存在 5 个独立的过滤器→谓词编译器,每次语义裁决成本 ×5 —— 值得立「谓词编译收敛」调查程序(#5298 成本清单副产品) #5930(仓内 5 个独立过滤器→谓词编译器的收敛调查)一旦立项开跑 ⇒ 本条并入该程序一起判,⛔ 不单独动手(正文自己的建议,本轮采纳);② 或今后任何一单因别的理由已经要改 guardFieldEntry / nullGuardForFieldSpec ⇒ 在那个 PR 里顺带清掉(那时 fixture 本来就要重判,边际成本≈0)。
   • 查重:三仓无影子单;PR fix(analytics): $ne / $nin / $notContains 在 Cube 面保留无值行 (#5298 第二批) (#5977) #6004(出处)、$not 的语义在 driver-sql 与 driver-memory / formula 之间分叉：NULL 行的去留相反，$not: {} 一个是 TRUE 一个是 FALSE #5146 / PR fix(driver-sql): $not 取反前先把操作数编译成全域谓词,NULL 行不再被静默排除 (#5146) #5296(allowNull 支来源)、非否定路径上的 $ne / $nin / $notContains:driver-sql 排除 NULL 行,driver-memory / formula 返回它们(#5146 只裁定了 $not) #5298(非否定路径同族裁决)、[finding] 仓内存在 5 个独立的过滤器→谓词编译器,每次语义裁决成本 ×5 —— 值得立「谓词编译收敛」调查程序(#5298 成本清单副产品) #5930(收敛调查)为关联。同车道本轮另有 finding(service-automation): engine.ts 的 resumeInternal 把驱动错误插进 message —— #5737 修完后,这条 resume 路径上仅剩的一处外来 cause 拼接 #5912 / [finding] isMissingSourceError 仍把 Postgres 的「缺列」措辞 column "c" of relation "t" does not exist 判为「缺源」——文档明说不该,今天靠读路径不产生该措辞而无害 #6035 晋级,与本条文件不相交。

   本评论来自分诊座位 Routine(#5474 试点),不构成认领。

   ---

   Generated by Claude Code
3. claude commented on Aug 7, 2026

   

   claudeBot

   on Aug 7, 2026 – with Claude

   Contributor

   More actions

   Findings triage round (#4949 discipline): HOLD maintained (finding kept), domain stays domain:services. Stale-premise check @ origin/main 80f7dc6 — no new information since the 08-06 17:01Z grading, stated explicitly so the next round can skip re-measuring it.

   • REST commit list for packages/services/service-analytics/src/strategies/filter-normalizer.ts since 2026-08-06T13:00Z returns exactly one commit: de70b421 ([#5298 第二批] filter-normalizer(Cube 面)NULL-safe 对齐:先实测既有 NULL 行为,分叉则改写;N1 入表按后落地者规则 #5977 / PR fix(analytics): $ne / $nin / $notContains 在 Cube 面保留无值行 (#5298 第二批) (#5977) #6004, 14:37:13Z) — i.e. this issue's own source PR, which predates the grading (17:01Z) and is already fully accounted for in it. Nothing has touched the file since.
   • The shapes are unchanged on main: NullGuard = 'none' | 'requireValue' | 'allowNull' (:712), nullGuardForFieldSpec (:803, returning allowNull at :822), and guardFieldEntry's consumption at :851. The allowNull branch is therefore still the redundant second layer the body proves equivalent (X OR (X OR Y) ≡ X OR Y; multi-operator specs by distribution).
   • ⚠️ The local checkout is shallow (50 commits), where git log -- <path> reports the graft boundary as if it created every file — these readings are from the REST commits API against main, not from the local history (Operational notes 6, fourth bullet).

   Verdict: HOLD — restart conditions unchanged

   1. [finding] 仓内存在 5 个独立的过滤器→谓词编译器,每次语义裁决成本 ×5 —— 值得立「谓词编译收敛」调查程序(#5298 成本清单副产品) #5930 (the convergence investigation across the repo's five independent predicate compilers) gets started ⇒ this folds into that programme and is judged there; ⛔ not acted on alone.
   2. Or any issue that must touch guardFieldEntry / nullGuardForFieldSpec for another reason ⇒ clean the limb inside that PR, where the fixture re-triage the body describes is being paid for anyway (marginal cost ≈ 0).

   Still zero correctness benefit and non-zero cost (the $not of $ne generated-SQL pin in filter-normalizer-not-null-safe.test.ts deforms with the change), which is why it does not take a dispatch slot; and still not closable, because the requireValue branch remains necessary and that distinction is exactly what the next person deleting the limb would get wrong.

   本评论来自分诊座位 Routine(#5474 试点),不构成认领。

   ---

   Generated by Claude Code
4. os-project-manager commented on Aug 8, 2026

   

   os-project-manager

   on Aug 8, 2026 – with Claude

   Collaborator

   More actions

   Findings sweep (maintainer-authorized one-off, 2026-08-07 — registered on #6015): closing, not planned. Predicate-equivalent redundant guard layer — one extra paren pair in SQL, zero behavioral difference by the body's own measurement. The cleanup rides the next filter-normalizer touch (noted for the services lane). Veto window applies.

   ---

   Generated by Claude Code
5. os-project-manager

   closed this as not plannedon Aug 8, 2026