[finding][objectql] lifecycle-service 还有两条 #4747 未覆盖的破坏性操作腿:abort 抬起后仍发 reclaimSpace(VACUUM)与 rotateShards(DROP 分片)—— 探针实测,当前不可达 #6412

Activity

1. baozhoutao

   added

   findingRecorded observation — held, not dispatchable until the findings triage round grades itRecorded observation — held, not dispatchable until the findings triage round grades it

   on Aug 7, 2026
2. claude

   added

   domain:engine-core

   pm:queueReady for the PM dispatch loopReady for the PM dispatch loop

   and removed

   findingRecorded observation — held, not dispatchable until the findings triage round grades itRecorded observation — held, not dispatchable until the findings triage round grades it

   on Aug 7, 2026
3. claude commented on Aug 7, 2026

   

   claudeBot

   on Aug 7, 2026 – with Claude

   Contributor

   More actions

   Findings triage — PROMOTE. finding → pm:queue; domain:engine-core applied (this card had no domain:* at all, so it was invisible to lane selection as well as to the queue).

   Stale-premise check — both limbs verbatim on origin/main, at the paths as re-verified (the file is packages/objectql/src/lifecycle/lifecycle-service.ts, not .../services/...):

   • :616 await driver.reclaimSpace!(); — inside for (const driver of reclaimable), reached straight after the object loop, with no abort read between the loop exit and the call.
   • :852 const res = await driver.rotateShards(obj, this.now()); — guarded only by lc.storage?.strategy === 'rotation', driver capability and supportsRotation !== false. No abort conjunct.

   The parent is finished, which is what makes this promotable rather than a wait: #5966 closed via PR #6397, merged 17:15:25Z — six minutes before this card was filed. So the fix shape is not a proposal, it is a landed pattern with a reviewed comment idiom to copy.

   Why promote instead of hold, given both limbs are unreachable today. Reachability is the wrong axis here, because #4747 is a discipline the repo already adopted, not a bug report — "no destructive operation after the abort bit is up". Under an adopted invariant, a known-but-unreachable limb is not a dormant defect; it is an enforcement gap that survives every green run, and today's unreachability is an accident of the current corpus (storage.strategy: 'rotation' appears only in tests and spec fixtures; the reclaimSpace path needs abort to land inside the last declared object's reap). Neither guarantee is asserted anywhere, so nothing fails when they stop being true. The prior limbs (PR #5956, PR #6397) were fixed on exactly this reasoning; leaving 2 of N unfixed leaves the invariant partially enforced, which is the state that produces the next incident. There is no design question left to settle, and the probe evidence is concrete rather than argued: reclaims === ['vacuum'] and drops === ['DROP shard'] were both observed, not inferred.

   Scope for the implementing seat, stated tightly: the two named call sites, the same predicate-conjunct + comment idiom as PR #6397, and the same test shape. Explicitly out of scope: the :1134 fallback DELETE N+1 (already folded into #5756), and the rotation-without-ttl path (the body correctly grades it benign — nobody read the bit there).

   Dedup — the filing dev swept all three repos on reclaimSpace / rotateShards / teardown with zero hits, and this card is named as the single entry point. Re-checked against open cards in the lifecycle/objectql area at this round: nothing else claims these two limbs.

   本评论来自分诊座位 Routine（#5474 试点），不构成认领。

   ---

   Generated by Claude Code
4. baozhoutao

   added

   pm:dispatchedDispatched to a dev agent by /pm-dispatchDispatched to a dev agent by /pm-dispatch

   and removed

   pm:queueReady for the PM dispatch loopReady for the PM dispatch loop

   on Aug 8, 2026
5. baozhoutao

   self-assigned this

   on Aug 8, 2026
6. baozhoutao commented on Aug 8, 2026

   

   baozhoutao

   on Aug 8, 2026 – with Claude

   ContributorAuthor

   More actions

   认领(engine-core 席 #6019,会话 session_019Q7oc7ASjh8yxyS3Yz78We,第 19 轮):

   • 分支:claude/issue-6412-lifecycle-abort-legs;工作树:../objectstack-6412
   • 文件面:packages/objectql/src/lifecycle/lifecycle-service.ts(仅 :616 reclaimSpace 与 :852 rotateShards 两处调用点,内容定位)+ 测试 + changeset。与在飞面零交集(engine.ts 链当前空)。
   • 执行口径:按分诊 22:54Z 晋级评论 —— 每个 os migrate 子命令关停时，悬空引用巡检都会把 sys_metadata / sys_view_definition 报成 unreadableObjects（连接已关闭） #4747 不变量的执行缺口,修法 = PR fix(objectql): archive 冷侧 keep prune 尊重 #4747 的 teardown abort 位 #6397 已评审的合取项 + 注释口径 + 测试形状,逐字复制范式不发明新形。⛔ 范围外::1134 兜底 DELETE N+1(已并 finding(objectql): reap 的每轮上限是「按 (对象, where 作用域)」计的 —— N 个租户覆写把一轮的实际预算变成 (N+1) × 10000 行 #5756)、rotation-无-ttl 路(分诊已裁良性)。
   • 标签对:pm:queue → pm:dispatched 同步落。

   ---

   Generated by Claude Code
7. baozhoutao

   closed this as completedin #6503on Aug 8, 2026