Repository navigation
ObjectMap 把 schema.filter 当地图配置的容器读(getMapConfig 读 filter.map / filter.map.style):filter 是过滤器,不是配置槽 #7138
Description
发现于 objectstack#7121 的实施过程(objectui 分支 claude/issue-7121-datasource-remaining-blocks,基线 5bfaabde0)。观察类:今天没有用户会踩到(它要求作者用一个未文档化的 legacy 形状),但它是一处「宽容消费者」缺陷,而且与刚接上的 per-element 绑定有明确的相互作用,所以按 Prime Directive #10 如实记录。
事实
packages/plugin-map/src/ObjectMap.tsx 的 getMapConfig():
const style: string | undefined =
(schema as any).style || (schema as any).mapStyle
|| (schema.filter as any)?.map?.style || (schema as any).map?.style; // ← 第 143-145 行
// …
if (schema.filter && typeof schema.filter === 'object' && 'map' in schema.filter) {
config = (schema.filter as any).map as MapConfig; // ← 第 163-164 行
}即:任何 filter 对象都会被探一次 map 键,命中就把它当地图配置(经纬度字段、标题字段、zoom、style)使用。
而 filter 在同一个组件里的另一个身份是查询过滤器(第 412-414 行 $filter: schema.filter),object-map 注册处声明的配置输入是 { name: 'map', type: 'object' } —— 也就是说规范的书写位置是 schema.map,filter.map 是一条早于该 input 的遗留读法。
为什么现在记录
objectstack#7121 把 dataSource 绑定接到了 object-map,filter 是它映射的键之一(该块确有 $filter 读点)。于是:
- 绑定/view 带来的 filter 与作者写的
schema.filter会经mergeFilterNodes合成成and节点 → 合成后的对象上没有map键 → 用 legacy 形状写地图配置的页面会静默回落到默认地图配置(默认经纬度字段名),标记全部消失。 - 没有发生合成时(只有作者自己的 filter,或压根没有 filter),
schema.filter原样透传,legacy 读法照旧生效 —— 所以这不是回归,是两条本就互斥的语义第一次撞上。
#7121 已在映射旁把这条注意写进注释,并不依赖 legacy 形状;这里只登记根因。
建议范围
把 getMapConfig 里读 schema.filter.map / schema.filter.map.style 的两处删掉,只保留声明过的 schema.map(及顶层 locationField/latitudeField 那一支与 style/mapStyle)。若仓外仍有 legacy 页面,先做一轮 grep;真需要过渡就在删除前加一条明确的 deprecation 警告,而不是继续无声接受 —— 「声明的是 map、消费的是 filter.map」正是 AI 生成的 metadata 最容易分叉的地方。
顺带:同文件对 filter 的这种重载会让「filter 到底是什么」在一个 block 内有两种答案,契约优先的方向是消费端不再宽容,由 producer/schema 负责。
Activity
claude commentedon Aug 9, 2026
Findings triage — PROMOTED
finding→pm:queue(routingrepo:objectuialready in place; labels updated in the same pass).origin/main@0cbdca8: both legacy reads are live —(schema.filter as any)?.map?.styleatpackages/plugin-map/src/ObjectMap.tsx:145and the'map' in schema.filterconfig probe at:163-164. The declared input remains{ name: 'map', type: 'object' }at theobject-mapregistration. PageComponentSchema.dataSource 在剩余 object-bound public block 上仍无人消费:object-gantt / object-timeline / object-map / object-pivot / object-master-detail-form / embeddable-form(按 spec 写仍渲染出空) #7121's dataSource binding work has landed, so the collision the card predicts (mergedandfilter nodes carry nomapkey ⇒ legacy-shaped pages silently lose their map config) is now the live semantics, not a future one.examples/+ showcase fixtures for anyfilter: { map:shape; if live usage turns up, stop and flag back to triage instead of silently breaking it (the card's own suggested deprecation route would then need a call). Include thefilter.map.stylehalf at:145in the same deletion.target:v17: not applied — reachable only via an undocumented legacy authoring shape; no released-surface user hits it today.ObjectMap.tsx's config resolution; PageComponentSchema.dataSource 在剩余 object-bound public block 上仍无人消费:object-gantt / object-timeline / object-map / object-pivot / object-master-detail-form / embeddable-form(按 spec 写仍渲染出空) #7121 recorded the interaction in a code comment but deliberately left the root cause to this card.本评论来自分诊座位 Routine（#5474 试点），不构成认领。
Generated by Claude Code
os-zhuang commentedon Aug 10, 2026
Migrated to objectstack-ai/objectui#4034 under #7167 (file-at-destination ruling, maintainer 2026-08-10). Native GitHub issue transfer is not available to this session's credential, so the card was recreated at the destination; this thread stays as the authoritative history and is linked from the new card. Closing as not planned here — moved, not rejected.
Generated by Claude Code
fix(plugin-map): read map config from the declared `map` input only, …