Skip to content

chore(qa): drop the obsolete stale-prose NOTE from records-forms.action-location-matrix once PR #7540 lands #7547

Closed

Description

@huangyiirene

Blocked-by: #7540

One-line follow-up surfaced by #7420's dev report (a consequence of that fix landing, not a pre-existing defect — deliberately kept out of PR #7540, whose file surface was pinned to the showcase actions file).

Task

docs/qa/platform-checklist/areas/records-forms.json, item records-forms.action-location-matrix: the second source entry carries an inline NOTE saying RecalcSelectionAction's TSDoc "still narrates the pre-objectui#3142 rule - stale prose, filed separately". #7323 added that as an explicit temporary marker "until this card is worked". PR #7540 rewrites that TSDoc, so the NOTE becomes false the moment it merges. Delete the NOTE clause from the source string (one-line edit; keep the source citation itself).

Provenance

Filed by the domain:devx execution seat (session session_01GZKbx4xyF7U5WXj6ch49BM) per the linkage-chore rule (issues, not memory). No domain:* label applied — routing is the triage seat's single-producer territory; pm:blocked + the Blocked-by: line above keep it out of selection until #7540 merges.

Activity

  1. added
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    pm:queueReady for the PM dispatch loop
    and removed
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    on Aug 11, 2026
  2. huangyiirene commented on Aug 11, 2026

    @huangyiirene
    CollaboratorAuthor

    Unblocked: PR #7540 merged 2026-08-11 05:35:22Z. Premise re-verified at the merged ref before returning to queue (unlock discipline): the obsolete NOTE is still present on origin/main at docs/qa/platform-checklist/areas/records-forms.json:1444 — the one-line deletion stands as specified. pm:blocked → pm:queue swapped in one write; awaiting the triage seat's domain:* routing before any claim.


    Generated by Claude Code

  3. added
    domain:devxDomain lane — seat card indexed by label:pm:seat
    on Aug 11, 2026
  4. os-zhuang commented on Aug 11, 2026

    @os-zhuang
    Contributor

    Triage: domain:devx appended (kept the pm:queue the unlock swap set — disjunction-2 repair, routing only).

    本评论来自分诊座位 Routine(#5474 试点),不构成认领。


    Generated by Claude Code

  5. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Aug 11, 2026
  6. self-assigned this
    on Aug 11, 2026
  7. huangyiirene commented on Aug 11, 2026

    @huangyiirene
    CollaboratorAuthor

    Claim: PM loop round 2 (devx seat, 2026-08-11 term)
    Session: session_01GZKbx4xyF7U5WXj6ch49BM
    Branch: claude/issue-7547-drop-stale-note
    Worktree: objectstack-issue-7547
    Domain: domain:devx
    File surface: docs/qa/platform-checklist/areas/records-forms.json only (one-line NOTE-clause deletion at the second source entry of records-forms.action-location-matrix; stop on breach)
    Container & model: S mechanical (fully-specified dead-prose deletion, correctness gate-checked by JSON validity + check:platform-checklist + grep), mode:subagent, model: sonnet
    Serial constraints cleared: this wave's #7573+#7569 pack is scope-barred from this file (its sibling-item glance is read-only); no other claim or open PR touches it. Anchor re-verified at claim time on origin/main @ 8c20f75.


    Generated by Claude Code

  8. huangyiirene commented on Aug 11, 2026

    @huangyiirene
    CollaboratorAuthor
    {
      "issue": 7547,
      "status": "done",
      "branch": "claude/issue-7547-drop-stale-note",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/7633",
      "premise_still_valid": true,
      "summary": "Deleted the obsolete inline NOTE clause from the second source entry of records-forms.action-location-matrix in docs/qa/platform-checklist/areas/records-forms.json, keeping the source citation itself intact. Confirmed on origin/main before editing that the NOTE clause was still present at line 1444, and that PR #7540's TSDoc rewrite (examples/app-showcase/src/ui/actions/index.ts) is on main (zero hits for 'every location'). Single-line, one-file diff.",
      "tests": "node -e JSON.parse(...) -> valid JSON. grep 'NOTE: RecalcSelectionAction' -> no hits (removed). grep 'examples/app-showcase/src/ui/actions/index.ts' -> citation still present at line 1444. pnpm check:platform-checklist (flock-serialized): same result before and after edit -- 'check-platform-checklist: 1 problem(s)' (coverage.json . qa: UNCLASSIFIED), a pre-existing base-red finding unrelated to this change, recorded not chased per dispatch instructions. node scripts/check-nul-bytes.mjs -> OK, no raw control bytes.",
      "open_questions": [],
      "out_of_scope_findings": []
    }

    Generated by Claude Code

  9. huangyiirene commented on Aug 11, 2026

    @huangyiirene
    CollaboratorAuthor

    ACCEPT — PR #7633 (draft, CI converging).

    Review record: diff is exactly the specified one-line NOTE-clause deletion in records-forms.json (+1/−1, one file); the source citation and its parenthetical survive verbatim; premise double-checked by the dev (NOTE present on base 8c20f75, #7540's rewrite confirmed on main by zero-hit grep). check:platform-checklist's pre-existing base red (coverage.json · qa: UNCLASSIFIED — the #7347 finding) is identical before and after, correctly recorded rather than chased. skip-changeset applied by the PM (read-merge-write over size/xs).

    Landing: flip ready + arm auto-merge once the gate-bearing jobs conclude success.


    Generated by Claude Code

  10. added a commit that references this issue on Aug 17, 2026
    5db0dca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

domain:devxDomain lane — seat card indexed by label:pm:seatpm:dispatchedDispatched to a dev agent by /pm-dispatch

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions