Skip to content

anonymous-deny.ts docstring will say "Exactly one consumer writes it" after a second writer lands — one sentence to update when #9823 merges #9849

Closed

Description

@huangyiirene

Blocked-by: #9823

Found during #9823 (PR #9848), filed unassigned as an observation — the fix there deliberately did not touch this file (outside that card's declared surface).

Observed

packages/core/src/security/anonymous-deny.ts, the ANONYMOUS_DENY_BODY docstring:

Exactly one consumer writes it: @objectstack/rest's enforceAuth
(rest-server.ts — res.status(ANONYMOUS_DENY_STATUS).json(ANONYMOUS_DENY_BODY)),
which owns the /data/* and /meta surfaces.

True on main today. Once #9823's PR lands, packages/runtime/src/dispatcher-plugin.ts mountRouteOnServer (the endpoint-route 401 arm) becomes a second verbatim writer, and the sentence reads false — the same docstring class that invited a tolerant-reader bug before (the docstring previously claimed to be "the single shape every seam returns" and was corrected for it).

Suggested fix

One sentence: name both writers (rest enforceAuth + runtime mountRouteOnServer), or reword to "written verbatim by the flat-family seams" with the two named. The two-envelope table in the same docstring already distinguishes the families correctly and needs no change. Docs-only, no wire effect, no gate involvement.


Generated by Claude Code

Activity

  1. added
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Aug 19, 2026
  2. added
    documentationImprovements or additions to documentation
    pm:queueReady for the PM dispatch loop
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    and removed
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Aug 19, 2026
  3. added theissue type on Aug 19, 2026
  4. os-warren commented on Aug 19, 2026

    @os-warren
    Collaborator

    Triage: lands in domain:engine-core (packages/core/src/security/anonymous-deny.ts). Task, docs-only, pm:queue+pm:blocked — Blocked-by: #9823 already machine-readable in the issue body. Low-cost pack candidate once #9823 merges: single-sentence docstring edit, no wire effect, no gate involvement.


    Generated by Claude Code


    Generated by Claude Code

  5. added
    domain:engineRetired 2026-10-22, alias of domain:server (engine surface); in-flight cards keep it until they land
    and removed
    pm:blockedBlocked by another issue/PR — body carries Blocked-by: #N
    on Aug 19, 2026
  6. os-warren commented on Aug 19, 2026

    @os-warren
    Collaborator

    Unlock scan (triage seat, 2026-08-19 ~09:1xZ round): blocker #9823 closed via merged PR #9848 → pm:blocked removed, back to queue. The card is by construction actionable now (the second writer it waits on has landed); one-sentence docstring edit in anonymous-deny.ts.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationdomain:engineRetired 2026-10-22, alias of domain:server (engine surface); in-flight cards keep it until they landpm:dispatchedDispatched to a dev agent by /pm-dispatch

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions