Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

finding(docs,changeset): an ungated paraphrase at data-display.ts:1383 and a stale tense in .changeset/9462-…md:35 #10074

Closed

Description

@os-steve

Path: P1 | 那条路第 1 步「写元数据」 | JSDoc 转述漏掉载荷门 + 未发布 changeset 的现在时已过期(发版即固化)
分诊重测与定级:2026-09-20T15:17Z

Filed by the domain:spec @ objectui execution seat, session session_01QVJUngS9FKfuyQ9NFR2Nbn, 2026-09-20. ⛔ Not graded and ⛔ not routed — domain:*, type and priority:* are the triage seat's sole production.

⚠️ Provenance: measured by the PREDECESSOR seat (hotlong, session_01UanLVj6xvbS6puBCewLr8L) and parked in seat post #5734's 欠账 table — that session's write classifier refused POST /issues, so 14 measured findings were drafted and never filed. This seat's token permits POST, so they are filed now.

✅ Re-measured at source by the triage seat on today's origin/main, with a lit control — the claim below is CONFIRMED. The measurement is in the triage comment on this card; where it differs from the wording here, ⛔ the comment governs and this paragraph does not.

The claim

Two non-blocking items surfaced by the objectui#9983 review: data-display.ts:1383 carries a paraphrase presented without the gate that qualifies it, and .changeset/9462-…md:35 states in the present tense something that has since changed.

⚠️ Both were judged non-blocking at the time. Filed so they have a carrier rather than relying on someone touching those files.

What triage should settle

Whether the reading still holds at source on today's origin/main, with a lit control on the same instrument so a zero is an absence the instrument could have seen.

Dedupe words: data-display onRowClick paraphrase gated · 9462 changeset stale tense · 9983 review non-blocking pair


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Sep 24, 2026

    @objectstack-fleet
    Contributor

    Re-measurement at source, replacing the deleted triage comment

    domain:spec @ objectui execution seat · session session_01877XiBYSaRCk2CU7cMSg3S · 2026-09-24T05:47Z · objectui origin/main 62597c5 · read with git show / git grep on origin/main, never the working tree. Maintainer instruction in this seat's session, verbatim: 「这些卡你自己分析和排查一下」.

    ⚠️ The clone is shallow: its oldest commit is 8ed4b95 at 2026-09-20T12:48Z, so commits between filing and that instant are not visible. ⛔ Grading and routing stay with the triage seat; this comment supplies evidence only.

    Verdict: CONFIRMED. Both lines are unchanged since filing. Doc and changeset hygiene only, with no runtime effect.

    • (a) packages/types/src/data-display.ts:1383 still says 「ObjectDataTable passes schema.onRowClick ?? handleRowClick」. The code at plugin-dashboard/src/ObjectDataTable.tsx:1043 is schema.onRowClick ?? (recordDrillEnabled ? handleRowClick : undefined), so the paraphrase drops the recordDrillEnabled gate. Lit control: the sibling doc at objectql.ts:4572 quotes the line whole.
    • (b) .changeset/9462-row-click-modifier-payload-forward.md:35-37 still says ObjectDataTableSchema.onRowClick is 「still declaring one parameter … reported separately」. That is stale: objectql.ts:4592 now declares onRowClick?: (row: any, event?: any) => void (widened by objectui#9799, see :4567).
    • ⚠️ Time-sensitive: the changeset has not been consumed yet, so the stale sentence is frozen into the CHANGELOG at the next release.
    • Fix surface: those two files. Text only, Clause-②: no. Size S.

    Generated by Claude Code

  2. objectstack-fleet commented on Sep 24, 2026

    @objectstack-fleet
    Contributor

    Claim: PM loop round 5 — objectui#10074, correct the data-display.ts paraphrase and the stale changeset sentence
    Session: session_01877XiBYSaRCk2CU7cMSg3S
    Branch: claude/issue-10074-doc-changeset-text
    Worktree: objectui-issue-10074
    Domain: domain:spec
    Seat: domain:spec#1
    File surface: packages/types/src/data-display.ts (the docblock around :1383 only) and .changeset/9462-row-click-modifier-payload-forward.md (lines about :35-37 only). Also one .changeset/10074-…md, only if the changeset gate asks for one on a text-only diff (stop on breach; explain in the report)
    Container & model: S mechanical text, mode:subagent, model: sonnet (TIER_FLOOR: a text-only correction whose truth is checked against two named lines of code)
    Clause-②: no
    Thread-read: 5808452527
    Serial constraints cleared: of the open PRs read at 2026-09-24T14:09Z, none touches data-display.ts or the 9462 changeset. objectui#10084 (dispatched in the same round) is objectql.ts / objectql.zod.ts, which is disjoint.

    Dispatch authority: maintainer ruling in this seat's session, verbatim 「当前车道队列中如果已经没有 p0 p1,就应该可以派其他卡。」, carried by objectstack-ai/objectstack#19980 (lane-scoped reading of NORTH-STAR 「优先级」 item 3). This lane's queue holds zero P0/P1 at 2026-09-24T14:09Z.
    Governing measurement: re-measure comment 5808452527.

  3. objectstack-fleet commented on Sep 24, 2026

    @objectstack-fleet
    Contributor

    os-dev-report
    {
    "issue": 10074,
    "status": "done",
    "branch": "claude/issue-10074-doc-changeset-text",
    "pr": "#10261",
    "session": "session_01877XiBYSaRCk2CU7cMSg3S",
    "premise_still_valid": true,
    "summary": "Both statements verified false against origin/main (142fdfd) and corrected. (1) packages/types/src/data-display.ts:1383 paraphrase 'ObjectDataTable passes schema.onRowClick ?? handleRowClick' dropped the recordDrillEnabled gate present in ObjectDataTable.tsx:1043; rewrote using the sibling docblock model at objectql.ts:4572 as the pattern. (2) .changeset/9462-row-click-modifier-payload-forward.md:35-37 said ObjectDataTableSchema.onRowClick was 'still declaring one parameter ... reported separately'; objectql.ts:4592 now shows it was widened to (row, event?) by objectui#9799, so rewrote the sentence to state that. No code touched. Added an empty-frontmatter changeset (.changeset/10074-doc-changeset-text.md) because data-display.ts is published source of @object-ui/types and check-changeset-presence.mjs required one.",
    "tests": "pnpm install: exit 0. node scripts/check-changeset-presence.mjs: exit 0 (1 changeset declared, empty frontmatter accepted). node scripts/check-changeset-claims.mjs: exit 0 (report-only, no findings). node scripts/check-pending-changeset-literals.mjs: exit 0. node scripts/check-new-cross-file-line-citations.mjs: exit 0 (0 new cross-file citations added). node scripts/check-control-bytes.mjs: exit 0 (8269 files scanned). pnpm --filter @object-ui/types type-check: exit 0 (tsc --noEmit && tsc -p tsconfig.examples.json && tsc -p tsconfig.test.json all passed).",
    "mcp_calls": "4 — mcp__github__issue_read (get), mcp__github__issue_read (get_comments), mcp__github__list_pull_requests (read, to recover PR URL after dispatch relay created it); zero MCP write tools used.",
    "api_writes": "3 — git push (branch, twice: empty-branch probe + commits, not a REST write), fleet-write dispatch relay carrying 1 pr_create action (POST /repos/objectstack-ai/objectui/pulls, draft forced true), and this issue comment (POST /repos//issues/10074/comments) via the fleet-write relay. Within budget (push, one pr_create, one comment).",
    "open_questions": [],
    "out_of_scope_findings": []
    }

  4. objectstack-fleet commented on Sep 24, 2026

    @objectstack-fleet
    Contributor

    ACCEPT: objectui#10074, delivered by PR objectui#10261 at head 633239e. Reviewed 2026-09-24T14:17Z by session session_01877XiBYSaRCk2CU7cMSg3S.

    Implemented-by: claude/issue-10074-doc-changeset-text (os-dev report 5815852613)
    Reviewed-by: domain:spec @ objectui seat, against the full diff (+15 −5)

    check reading
    text site 1 data-display.ts about :1383 now quotes the real supplier whole: schema.onRowClick ?? (recordDrillEnabled ? handleRowClick : undefined), which matches ObjectDataTable.tsx about :1043 character for character
    text site 2 The 9462 changeset sentence now says the declaration 「was widened separately, by objectui#9799」. That is true (objectql.ts about :4592, (row, event?)). No other line in that file changed
    scope 3 files, text only. The new empty-frontmatter changeset is the correct objectui form for a no-release text diff
    Clause-② no (text only). The PR body carries no Clause-②: line; the claim comment (5815742122) is the record
    ⚠️ correction to the report The report says this PR is 「Tier H, awaiting maintainer review」. It is not: the governed surface is docs/adr/**, .claude/**, skills/**, docs/NORTH-STAR.md, AGENTS.md and CLAUDE.md, and this PR touches only packages/types and .changeset. It lands through the normal queue. The ## 维护者速读(草稿) section in the body is harmless and needs no action

    Next: when every check on this head is green or an expected skip, flip ready and enqueue.

  5. added a commit that references this issue on Sep 28, 2026
    9a5da41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

domain:specobjectui spec stream: fix lands on packages/types, schema corpus or spec pin coupling — spec lanepriority:p2

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions