Repository navigation
finding(app-shell): the page designer's PagePreview decides "record page" from draft.pageType, the alias PageSchema refuses #10482
Description
Filing-gate category: ② a renderer reading a key the contract refuses (class b). Reader: triage first (route and grade), then the seat that claims it. The site is packages/app-shell/src/views/metadata-admin/previews/PagePreview.tsx, isRecordPage: draft.pageType === 'record'.
Filed by the domain:ui execution seat (seat 1, session session_01BA3nKVUwKQJf8DBxrSVtNC) from the os-dev-report of objectui#9674 (PR objectui#10480). ⛔ Not graded and not routed: domain:*, priority:* and type are the triage seat's.
Fact
PageSchemadeclarespageTypeas an ALIAS oftypeand refuses it: the installed 17.4.0 dist answersunrecognized_keys ['pageType']with "Did you meanpageType→type?".PagePreview'sisRecordPagereadsdraft.pageType === 'record'to decide whether to bind a sample record in the preview.- This read is LIVE, per the dev's trace:
ResourceEditPage'sJsonSourceEditoronChange →handleDraftChange→setDraft, with no schema gate, anddraft={draft}is passed to the preview. A designer draft carryingpageType: 'record'gets a record preview although the draft can never be saved. A draft with the validtype: 'record'(and nopageType) does not. - PR objectui#10480 moved the runtime (
usePageAssignment) and the nav picker totypealone, and left this read in place with a comment, because it is live. So the designer preview and the runtime now disagree on what a record page is.
Grading notes (for triage, not a grade)
- The shape of the fix: read
type, the one discriminator, as the runtime does. A draft carryingpageTypegets the spec's refusal, not a working preview. ⛔ No consumer-side alias for a refused key. - Seam:
spec:PageSchemaaliases (pageType→type) →renderer:PagePreview isRecordPage.
Dedupe
REST page walk over the 1000 most recently updated objectui items (oldest updated_at 2026-09-18). PagePreview near pageType ⇒ only PR objectui#10480. isRecordPage ⇒ 0. Must-hit control pageType ⇒ 4 hits.
Dedupe words: PagePreview pageType · isRecordPage pageType draft · designer draft refused alias pageType
Generated by Claude Code
Activity
objectstack-fleet commentedon Sep 25, 2026
Path: changing a running app without code | studio-authoring.record-page-roundtrip | P1
Triage: first grade —
bug·priority:p3·domain:ui·area:studio·pm:queue(findingremoved — graded)Triage: lands in
packages/app-shell/src/views/metadata-admin/previews/PagePreview.tsx(pageType === 'record'on objectuiorigin/maind999617) ⇒domain:ui; rationale: the designer preview decides "record page" frompageType, the aliasPageSchemarefuses, while the runtime readstypealone; preview-only, and the draft can never be saved ⇒ p3.Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) ·
session_01CRZSc7dU8oDStbTbSwhuZe· 2026-09-25T06:55Z. ⛔ Not a claim, ⛔ not a dispatch. Read: this card and its full thread, and objectuiorigin/maind999617. Dedupe by this seat over 739 objectui cards (open, plus closed since 2026-09-18):isRecordPage→ 1 hit (this card).Execution note: read
type, the one discriminator; ⛔ no consumer-side alias for a refused key. Related, not serial: objectstack-ai/objectstack#20101 (the server servingtype's declared default).objectstack-fleet commentedon Sep 25, 2026
Claim: PM loop round 3 —
domain:uiexecution seat 5Session:
session_01KUxVUa7e39aNjhkKi1gsoyBranch:
claude/issue-10482-page-preview-reads-typeWorktree:
objectui-issue-10482Domain:
domain:uiSeat:
domain:ui#5File surface:
packages/app-shell/src/views/metadata-admin/previews/PagePreview.tsx(isRecordPageonly), a pin beside the existingPagePreviewtests, and one.changeset/10482-…md(stop on breach; explain in the report)Container & model:
S,mode:subagent,model: opus(default judgement tier).dispatch-gates --tier: 「no path-derived mandate … floor sonnet · default opus · ceiling fable」.Clause-②: no
Thread-read: 5828249870
Serial constraints cleared: no open PR's file list names
PagePreview.tsx, and no livepm:dispatchedclaim does. Open-PR file lists re-read in this act, at objectuiorigin/mainfee1da5.Clause-②: no: the designer preview readstype, the one discriminator the runtime already reads; no schema, export or accept set moves.Scope
The triage (
5828249870): 「readtype, the one discriminator; ⛔ no consumer-side alias for a refused key.」pageType: 'record'and notypegets a record preview today, and a draft withtype: 'record'does not.isRecordPagereadsdraft.type === 'record'alone, asusePageAssignmentdoes after PR objectui#10480. ⛔ NopageTypefallback.type: 'record'binds the sample record;pageType: 'record'alone does not. Lit control: atype: 'app'draft stays unbound.⇒
Fixes #10482.domain:uiseat 5 ·session_01KUxVUa7e39aNjhkKi1gsoy· claim · 2026-09-25T08:46Zobjectstack-fleet commentedon Sep 25, 2026
os-dev-report⚠️ comment block describing it are removed, replaced by a 2-line comment (reads
{
"issue": 10482,
"status": "done",
"branch": "claude/issue-10482-page-preview-reads-type",
"pr": "#10569",
"session": "session_01KUxVUa7e39aNjhkKi1gsoy — subagent run under the PM session (Claude-Session trailer on the three authored commits; the merge commit 3e86cb9 carries none)",
"premise_still_valid": true,
"summary": "isRecordPage in packages/app-shell/src/views/metadata-admin/previews/PagePreview.tsx now reads
typealone: the|| pageType === recordleg and the 8-linetypealone as the runtime does;pageTypeis an alias PageSchema refuses). NopageTypefallback anywhere. | Files: PagePreview.tsx +3/-11; new previews/tests/page-preview-record-type-10482.test.tsx +142; new .changeset/10482-page-preview-reads-type.md +13 (patch, @object-ui/app-shell). Commits: f800c38 (pin), 1e97a27 (fix + changeset), ae914a8 (pin stubs typed without any), 3e86cb9 (merge of origin/main 4f74cd5). Draft PR 10569, assignee os-tesla. | Base: worktree cut at origin/main 4a7ef0d (dispatch named fee1da5; origin/main had moved); H1 site and comment block held at 4a7ef0d as described. | H2 measured: git grep -n pageType over packages/app-shell/src/views/metadata-admin/ at 4a7ef0d = 10 lines in 3 files; the only reader is isRecordPage (5 lines in PagePreview.tsx); nav-target.ts 1 hit is a comment stating pageType is not read; nav-target.test.ts 4 hits pin that. Zero out-of-scope readers. | H3 partially falsified: page-tabs-item-value-8278.test.tsx does not mount PagePreview; the mount harness followed is previews/PagePreview.expandFls-7429.test.tsx (fetch stub + @object-ui/react mock spreading importOriginal). Pin placed at previews/tests/page-preview-record-type-10482.test.tsx as named. | Deviation from the claim text: its reproduction clause says a type:record draft does not get a record preview on base; measured false — on 4a7ef0d type:record already binds (the lit control passes on both sides). Red on base is the alias cases only. | Pin shape widened beyond the 3 named cases: 5 tests = spec-parse of fixtures (lit parses; alias refused with code unrecognized_keys naming pageType), lit type:record, pageType-only, type:app + pageType:record (alias contradicting type), type:app control. | Spec re-measured from installed @objectstack/spec 17.4.0 dist/ui PageSchema.safeParse: type:record success=true; +pageType:record success=false unrecognized_keys [pageType] with a Did-you-mean pageType to type message; pageType only success=false same key; control nonsense key success=false unrecognized_keys [zzzNotAKey]; type:app success=true. | Writes: pr_create was refused twice by write-pace (exit 10, shared 40/h token budget full, nothing sent); third attempt landed. Commit trailers use the model-free pair from objectstack AGENTS.md (Claude-Session + Co-authored-by Claude), not the harness reminder model-named Co-Authored-By. dispatch-gates.mjs not run (objectui tree; gate list hand-derived and re-derived). CI at report time on 3e86cb9: 42 check-runs, 21 success, 3 skipped, 18 in_progress, 0 failed.","tests": "Pin red on base: commit f800c38 (pin over unchanged base PagePreview)
pnpm exec vitest run packages/app-shell/src/views/metadata-admin/previews/__tests__/page-preview-record-type-10482.test.tsx→ Tests 2 failed | 3 passed (5), VERDICT command-exit 1 (failing: pageType-only and type:app+pageType:record, each fetched 2 URLs). | Pin green on fix: 1e97a27 same command → Tests 5 passed (5), VERDICT command-exit 0. | Final-pin red/green re-run at 3e86cb9 (trap EXIT INT TERM, absolute paths): PagePreview.tsx swapped to base blob 63d7deb (disk hash == base blob, pageType-leg grep count 1) → Tests 2 failed | 3 passed (5), exit 1; restored with git checkout HEAD -- path, disk hash == HEAD blob c077276, git diff HEAD empty, pageType-leg count 0 → Tests 5 passed (5), exit 0. Subject imported relatively from src, no dist in the path. | Directory suitepnpm exec vitest run packages/app-shell/src/views/metadata-admin/: at 1e97a27 Test Files 300 passed (300), Tests 3422 passed | 1 skipped, exit 0; at 3e86cb9 Test Files 302 passed (302), Tests 3428 passed | 1 skipped (3429), exit 0. |pnpm exec turbo run type-check --filter @object-ui/app-shell --concurrency=2at 3e86cb9: Tasks 30 successful, 30 total, exit 0; echoed scripttsc --noEmit && tsc -p tsconfig.test.json;tsc -p tsconfig.test.json --listFilesOnlylists the new pin 1 time. | eslint plain form on the 2 changed source files at 3e86cb9: exit 0, 0 errors; PagePreview.tsx 15 warnings (no-explicit-any, react-hooks/set-state-in-effect), base blob via --stdin also 15; pin 0 warnings. Narrowing evidence: population = app-shell lint scripteslint ., both files present in --format json (2 results, none ignored); invariance = eslint.config.js has 0 hits for parserOptions/projectService/project:/TypeChecked (control languageOptions 1 hit) and 0 eslint-rules/*.js read the filesystem, so no type-aware or cross-file judgement of untouched files. Repo-wide pnpm lint is CI. | Named gates at 3e86cb9, all exit 0: check:control-bytes, check:test-path-roots, check:vi-mock-specifiers, check:vi-mock-inherit, check:vi-mock-override-shape, check:new-line-citations (0 new citations), check:changeset-claims, check:pending-changeset-literals, node scripts/check-changeset-presence.mjs (1 released package, 1 changeset). | Re-derived from the diff, all exit 0 at 3e86cb9: check-changeset-no-major, check-changeset-fixed, check-changeset-overwrite, check-type-check-coverage, check-lint-coverage, check:metadata-write-doors, check:handler-key-reads, check:self-import, check:unreferenced-sources, check:spec-symbols. check-governed-queue-guard --test on the 3 paths: NOT GOVERNED. | NOT MEASURED locally: full pnpm test and pnpm lint (CI).","mcp_calls": "0 — no MCP GitHub tool called",
"api_writes": "3 — (1) pr_create via fleet-write relay: POST /repos/objectstack-ai/objectstack/dispatches → POST /repos/objectstack-ai/objectui/pulls (draft, PR 10569); (2) label-write --assign os-tesla via relay → POST /repos//issues/10569/assignees, read back matches; (3) this os-dev-report comment via post-stamped → POST /repos//issues/10482/comments. Two earlier pr_create attempts were refused locally by write-pace before any request (exit 10). git push of the branch is not a REST write.",
"open_questions": [],
"out_of_scope_findings": []
}
Generated by Claude Code
objectstack-fleet commentedon Sep 25, 2026
✅ ACCEPT: objectui#10569 at
3e86cb9domain:uiseat 5,session_01KUxVUa7e39aNjhkKi1gsoy, 2026-09-25T09:49Z. Checked against the diff and CI, not against the report's own account.PagePreview'sisRecordPagereads(draft as { type?: string })?.type === 'record'alone; thepageTypeleg is gone, and ⛔ no consumer-side alias was introduced anywhere (git grep pageTypeovermetadata-admin/finds no reader). The preview now agrees with the runtime resolverusePageAssignment, which readstypealone since objectui#9674. The falsetype: 'record'draft got no record preview. The dev measured it false: on the base thetypeleg already bound, and only the alias cases were red. The ask is unchanged; the alias leg was the defectpage-preview-record-type-10482.test.tsx:type: 'record'binds (lit control);pageTypealone andtype: 'app'+pageType: 'record'fetch nothing and bind nothing (both red at the base);type: 'app'stays unbound; and aPageSchema.safeParserow measures the refusal the fixtures rely on. No existing pin editedCONTRACT_REVIEW_TIERon this head, record5830355218on the PR. The seat read the reviewer transcript: every turn was at tier'@object-ui/app-shell': patch; all four changeset sentences read true3e86cb9: 40 success, 3 skipped by design, 0 redFixes #10482State
readyand auto-merge (squash) go through the relay opspr_ready+automerge_enablein this act.objectstack-fleet commentedon Sep 25, 2026
Landed: PR objectui#10569 merged as
90dbd1dthrough the merge queuedomain:uiseat 5,session_01KUxVUa7e39aNjhkKi1gsoy, 2026-09-25T10:09Z. Verified by content on objectuiorigin/maina506001, not by the sha:PagePreview.tsxcarriesisRecordPage = (draft as { type?: string })?.type === 'record';(1), and thepageType === 'record'leg is gone (0)..changeset/10482-page-preview-reads-type.mdis present.The card closed
completedthroughFixes #10482.pm:dispatchedis removed in the same stroke.fix(app-shell): PagePreview decides "record page" from `type` alone —…