Repository navigation
studio(data): the field inspector shows the source label while canvas and grid show the translated label, with no hint that a translation overrides it #11782
Description
Filing gate ② — a product decision only the maintainer can make.
Who acts on it: objectui triage → the Studio / app-shell owner. ⛔ Not a claim. Found in a manual browser QA pass of Studio on 2026-10-07; filed one card per finding on the maintainer's word: 「你发现的问题全部提交 issue」, and on the one-card-per-finding question 「覆盖规则，逐条立卡」.
Maintainer quick-read
Should the field inspector tell the author when a translation overrides the label they are editing?
What prompted it
showcase showcase_account.tax_id: the canvas and grid show "Tax ID" (from the en translation bundle), the inspector's Label shows the source label "Tax ID (EIN)". Nothing on screen explains the difference.
Options
- A — a hint under Label: "Shown as Tax ID in en (translation)" with a link to the translation.
- B — show the effective label as the field's title and the source label as the editable value.
- C — status quo.
Environment
objectstack 879bd38c · examples/app-showcase booted with objectstack dev --ui --seed-admin on an isolated port and SQLite file · objectui 179f6fe9 (HEAD; the framework pin .objectui-sha is a58626c8) served by the console's Vite dev server, perf numbers from a vite build of the same commit · Chromium 141 at 1440×900 · signed in as the seeded platform admin admin@objectos.ai unless stated.
Duplicate check
- Semantic issue search on objectstack-ai/objectui (open and closed), field inspector label translation override source label mismatch: 8 hits (0 open, 8 closed).
- Related, not the same defect:
- finding(app-shell): the machine-name chip is unconditional in every non-English panel — its "label already spells the name" predicate cannot hold once the label is translated #8231 (closed) — label-vs-translation display logic in inspectors; neighbouring
- finding(app-shell): Studio's nav-item inspector shows a locale-map label as "[object Object]", and one keystroke writes a plain string over the whole map #11148 (closed) — inspector label vs translated label family, nav surface
- Positive control in the same run: related lists action id refusal notice shown to end users on objectstack-ai/objectui returned related lists: an action id the related object does not define draws a refusal notice above the list for whoever opens the record — an authoring fault shown to end users; scope it to authors/admins #11768: yes.
Dedupe words: field label translation override inspector · source label vs translated label
Filed by Claude Code (session session_01D76mrPJrSSdaKRxR2rvrMG) from that QA pass.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 7, 2026
Path: write metadata — the author sees which label users get | 缺项 | P3
Triage: first grade,
enhancement·priority:p3·domain:ui·area:i18n·pm:queue. Filed as ②, but routed as a UX defect: no contract or product question is openTriage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-10-07T16:12Z. ⛔ Not a claim, ⛔ not a dispatch.Triage: lands in the Studio field inspector's label input ⇒
domain:ui; rationale: a Studio or console surface in objectui. Filed from the Studio browser QA pass of 2026-10-07 (objectstack879bd38c, objectui179f6fe9).Clause-②: no. Patch changeset in objectui.objectstack-fleet commentedon Oct 8, 2026
Claim: PM loop round 3
Session:
session_01CGZy1BGCjdN5cXqL9cnvB8Account:
os-support-aiBranch:
claude/issue-11782-label-translation-hintWorktree:
objectui-issue-11782Domain:
domain:uiSeat:
domain:ui#3File surface (on
59ce048), underpackages/app-shell/src/views/metadata-admin/:inspectors/ObjectFieldInspector.tsx: the Basic section's Label input only (field-label-input, about:902–:927), a hint line under it;designer.field.*rows ofi18n.ts(en and zh) for the hint;.changeset/11782-*.md.⛔ Not on it:
studio-design/StudioDesignSurface.tsx(seat 2's objectui#11781 holds the Data pillar's field-inspector mount at about:4500–:4530); how translations resolve (@object-ui/i18n,packages/i18n/**); the Translations editor itself. If the inspector cannot reach the effective label without a change to its mount or to a published package, the dev reports it before opening the PR (stop on breach; explain in the report).Container & model:
M,mode:subagent,model: opus(dispatch-gates --tier --repo objectstack-ai/objectui: no path-derived mandate; default tier)Clause-②: no
Responsibility:
objectui app-shell: Studio's field inspector edits the source label and never says that a translation overrides it, so the canvas and grid read "Tax ID" while the input reads "Tax ID (EIN)" | the platform path: the console already resolves a field's translated label (@object-ui/i18n's useObjectLabel), so the inspector can show that effective label beside the source it edits | every author editing a field label in Studio for an app that ships a translation bundle, starting with the showcase's showcase_account.tax_idThread-read: 6041923394
Serial constraints cleared: seat 1's objectui#11783 (
ObjectFieldInspector.tsx) merged as57dbe34. No in-flight claim in the lane namesObjectFieldInspector.tsx, and no open objectui PR touches it (read 2026-10-08T01:30Z). Seat 2's objectui#11781 holdsStudioDesignSurface.tsx's field-inspector mount, which is off this surface. No otherarea:i18ncard is in flight.Why
Clause-②: no: a hint inside@object-ui/app-shell, with rows in the designer's own string table, which is not a published language pack. A published export, prop, type member or language-pack key is a stop: the dev reports it before opening the PR, and the seat amends this line.Generated by Claude Code
objectstack-fleet commentedon Oct 8, 2026
os-dev-report
{
"issue": 11782,
"status": "done",
"branch": "claude/issue-11782-label-translation-hint",
"pr": "#11859",
"session": "session_01CGZy1BGCjdN5cXqL9cnvB8 (subagent mode, the parent's id)",
"premise_still_valid": true,
"summary": "Studio's field inspector now shows a muted line under the Label input, for example 'Shown as “Tax ID” in en: the app’s translation bundle overrides this label.', when a translation overrides the label being edited. The line appears whenever the translated label differs from the input's current value. The input still edits and commits the source label, and translation resolution is untouched. The effective label is read through the same resolver the Data pillar's grid (ObjectGrid resolveFieldLabel) and form canvas (ObjectFormDesigner fieldLabelOf) use, which is useSafeFieldLabel().fieldLabel from @object-ui/i18n, with an empty fallback so an empty answer means no translation. The language named is the resolver's i18next language. Zone 2 hypothesis 3 is falsified: the designer's locale prop collapses every non-zh language to en-US, so the two are not the same value. There is no link: Studio has no Translations pillar, and the translation editor's base path and item name are not reachable from the inspector without a new prop on the mount in StudioDesignSurface.tsx (off surface). The PR body says why.",
"tests": "Final head bc2bf4c, after merging origin/main 5aa7f55; all heavy runs went through os-verify-lock. (1) pnpm --filter '@object-ui/app-shell^...' run build: exit 0 (at 2ec68bc). After the merge, pnpm --filter @object-ui/data-objectstack run build: exit 0 (REBUILD_OK). (2) pnpm --filter @object-ui/app-shell type-check, which echoes 'tsc --noEmit && tsc -p tsconfig.test.json': exit 0 (TYPECHECK_OK). tsc -p tsconfig.test.json --listFilesOnly lists the new test file, with ObjectFieldInspector.test.tsx as the control. (3) pnpm exec vitest run --maxWorkers=2 over 211 files: 'Test Files 211 passed (211)', 'Tests 2707 passed | 1 skipped (2708)', VERDICT command-exit 0. The 211 files are the whole metadata-admin/inspectors/ directory, every app-shell test importing the metadata-admin string table, the DataPillar/Studio tests that mount the field inspector, apps/console's preview-samples-designer-options test, and the test files the merge brought in. The pre-merge run of the same 205-file set at 2ec68bc: 205 passed, 2634 tests passed, 1 skipped. (4) New pin file ObjectFieldInspector.labelTranslation-11782.test.tsx: 7 passed. Ablation through ../objectstack scripts/ablation-replace.mjs (wrap mode): the anchor was the hint guard 'if (!translated || translated === sourceLabel) return null;', replaced by 'return null; // ABLATION-11782'. The anchor went from 1 hit to 0 and the replacement from 0 to 1. The blob went from 432eb3a6763b to bc44e7122d62, and an on-disk grep found the marker once. The run was red: 'Tests 4 failed | 3 passed (7)' (the four hint pins red, the three controls green). The restore was proven: blob after restore 432eb3a6763b == blob at HEAD, git diff HEAD empty, git status clean. There was no dist leg, because the test imports the inspector from src through a relative path. Real browser: the preview gallery (apps/console vite :5297, ?only=object), Chromium /opt/pw-browsers/chromium at 1440x900, with an app bundle installed by addResourceBundle on the provider's own i18next instance. Before: no hint. After: 'Shown as “Order Total” in en: …'. With the input set to the translation: no hint. With the input changed again: the hint came back. On an untranslated field: no hint. With &locale=zh-CN: '在 en 中显示为“Order Total”：…'. No page errors. The showcase Studio reading is NOT MEASURED (see deviations).",
"mcp_calls": "0 — no MCP GitHub tool was called",
"api_writes": "3 REST writes through the fleet-write relay: (1) pr_create, POST /repos/objectstack-ai/objectui/pulls, request fw-20261008T022514Z-7c41e2, run 37717776709; read-back said 9599 bytes sent and stored, identical. (2) label-write --assign os-support-ai, POST /repos//issues/11859/assignees, request fw-20261008T022605Z-912665, run 37717848611; read-back said MATCHES. (3) This os-dev-report comment, POST /repos//issues/11782/comments. git push ran 3 times (the empty-branch probe, 2ec68bc, bc2bf4c) and is not a REST write. No label writes: the labels tests and 'package: app-shell' on the PR are labeler.yml's.",
"open_questions": [],
"out_of_scope_findings": [
"carrier: none · noted in the PR's Acceptance notes, not filed: the inspector's header title and Remove button still name the source label (def.label). This PR only touches the Label input, which is the claim's surface.",
"carrier: none · noted, not filed: InspectorTextField has no description slot, so the hint is not tied to the input through aria-describedby. Fixing it means editing inspectors/_shared.tsx, which is off the surface (accessibility polish).",
"carrier: none · noted, not filed: in the preview gallery (dev harness), react-i18next's module-level getI18n() instance is not the instance the tree renders with. A bundle added there never reached the hint; one added to the I18nextProvider's i18n prop did. Unverified guess: StrictMode runs the provider's useMemo twice and the gallery's inline config makes each run call createI18n. Zero pull: dev harness only."
],
"gates": [
{
"command": "pnpm --filter '@object-ui/app-shell^...' run build",
"exit": 0,
"verdict": "os-verify-lock VERDICT command-exit 0 (at 2ec68bc)"
},
{
"command": "pnpm --filter @object-ui/data-objectstack run build",
"exit": 0,
"verdict": "REBUILD_OK (at bc2bf4c)"
},
{
"command": "pnpm --filter @object-ui/app-shell type-check",
"exit": 0,
"verdict": "TYPECHECK_OK; os-verify-lock VERDICT command-exit 0 (at bc2bf4c)"
},
{
"command": "pnpm exec vitest run --maxWorkers=2 [211 files]",
"exit": 0,
"verdict": "Test Files 211 passed (211); Tests 2707 passed | 1 skipped (2708) (at bc2bf4c)"
},
{
"command": "pnpm exec vitest run packages/app-shell/",
"exit": null,
"verdict": "NOT MEASURED: I stopped my own run after 10m33s under the lock with no result read, because another seat was queued; this is a declared narrowing and the full package run is CI's"
},
{
"command": "pnpm exec eslint [3 touched files]",
"exit": 0,
"verdict": "0 errors, 11 warnings, all existing no-explicit-any; the diff adds no any"
},
{
"command": "pnpm check:control-bytes",
"exit": 0,
"verdict": "check-control-bytes: OK"
},
{
"command": "pnpm check:test-path-roots",
"exit": 0,
"verdict": "check-test-path-roots: OK"
},
{
"command": "pnpm check:changeset-claims",
"exit": 0,
"verdict": "No pending changeset names a file this change touches."
},
{
"command": "pnpm check:pending-changeset-literals",
"exit": 0,
"verdict": "No test source names a pending changeset."
},
{
"command": "pnpm check:i18n-keys",
"exit": 0,
"verdict": "Every in-scope call-site key resolves against the en pack"
},
{
"command": "pnpm check:i18n-drift",
"exit": 0,
"verdict": "No designer-table en value changed in this range."
},
{
"command": "pnpm check:i18n-dead-keys",
"exit": 0,
"verdict": "report-only; designer.field.labelTranslated not among the candidates"
},
{
"command": "pnpm check:i18n-designer-parity",
"exit": 0,
"verdict": "Every en row has a zh row, and every shared row carries the same placeholders."
},
{
"command": "pnpm check:new-line-citations",
"exit": 0,
"verdict": "VERDICT new-cross-file-line-citations: 0 new citation(s)"
},
{
"command": "node scripts/check-changeset-presence.mjs",
"exit": 0,
"verdict": "3 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)"
},
{
"command": "CI on bc2bf4c (one read, no wait)",
"exit": null,
"verdict": "in_progress: 42 check runs, 21 success, 3 skipped, 18 in progress, 0 failed"
}
],
"deviations": [
"Declared narrowing: the full app-shell package (1085 test files) was not measured locally. The 211-file set above is what ran, and CI runs the full package.",
"The real-browser reading is the console preview gallery with a bundle installed in the live page. It is not Studio against the showcase backend: the ../objectstack checkout has no install or build, and building the showcase backend on the shared box was out of proportion for a p3 hint. The showcase showcase_account.tax_id reading is NOT MEASURED.",
"pnpm install in the new worktree was started with & and finished (EXIT=0 in its log) before anything used the tree.",
"The merge commit of origin/main was amended once, before its first push, to carry the model-free trailer pair. No pushed history was rewritten.",
"An env | grep for the fleet transport variables also matched the fleet App credential variable and echoed its value into this session's tool output. It was not written to any file, to GitHub or to this report. The seat should judge whether rotation is warranted."
],
"files_changed": [
"packages/app-shell/src/views/metadata-admin/inspectors/ObjectFieldInspector.tsx",
"packages/app-shell/src/views/metadata-admin/i18n.ts",
"packages/app-shell/src/views/metadata-admin/inspectors/ObjectFieldInspector.labelTranslation-11782.test.tsx",
".changeset/11782-label-translation-hint.md"
],
"line_budget": "not applicable (no skills/** surface)"
}
Generated by Claude Code
objectstack-fleet commentedon Oct 8, 2026
ACCEPT —
domain:uiseat 3,session_01CGZy1BGCjdN5cXqL9cnvB8, 2026-10-08T02:42Z. PR objectui#11859, headbc2bf4c.PR shape: draft against
main, with5aa7f55merged in (no rebase).mainhas since moved (82500a7,9b530d8), andgit merge-treeof it and this head is clean; the queue tests that merge. First lineFixes #11782, no other closing keyword.Clause-②: noat line start. The three commits carry only the model-free trailer pair. Assigned toos-support-ai.Scope: 4 files, +222/−0, on the claim's surface (
6050311093):ObjectFieldInspector.tsx: oneLabelTranslationHintmounted right under the Label input; the input and its commit path are untouched;designer.field.labelTranslatedrow ini18n.ts, en and zh;patchon@object-ui/app-shell).StudioDesignSurface.tsxandpackages/i18n/**are untouched. Nothing is added to the package entry. No governed path.Diff read (the seat's own):
useSafeFieldLabel().fieldLabel(object, field, ''), the same resolverObjectFormDesigner(the form canvas) uses. With''as the fallback, an empty answer means no translation exists. The seat readresolveinpackages/i18n/src/useObjectLabel.ts: it returns the fallback when no app namespace has the key.def.label.language, not the designer'slocaleprop. The dev measured that the prop collapses every non-zh language toen-US, which falsifies the brief's Zone 2 Add public roadmap, VitePress documentation site, and GitHub Pages deployment #3. The changeset says this.Ruling honoured (triage
6041923394): "under the label input, show the effective translated label for the active locale with a pointer to the translation bundle, when a translation overrides it" and "⛔ No change to how translations resolve". There is no link because Studio has no Translations pillar and the editor's address is not reachable from the inspector without a prop on the mount, which is off the surface. The hint names the bundle in words, and the PR body says why (Zone 2 Implement component reordering via drag-and-drop in designer canvas #5's fallback).Changeset sentences checked against the head:
Shown as “Tax ID” in en: the app’s translation bundle overrides this label.";Reverse verification (dev report):
ablation-replace.mjs: the hint guard replaced byreturn nullgives the four hint pins red and the three controls green. Restored with the blob equal to HEAD.bc2bf4c(the wholeinspectors/directory, every importer of the designer string table, the Data pillar and Studio mounts of the inspector): 2707 tests passed. The full package run is CI's (declared narrowing).Gates: CI on
bc2bf4c(head_shaequals the PR head): 43 runs, 40 success, 3 skipped (Test (coverage), its shard template,dependabot), 0 failure.LintandType Checkare success.Contract review: not required (
Clause-②: no).Findings:
Acceptance notesInspectorTextFieldhas no description slot, so the hint is not tied to the input byaria-describedby. Fixing it means editing the sharedinspectors/_shared.tsx, and the reach is not measured →Acceptance notesdropped — dev harness only, no user doorLanding: ready + auto-merge through the queue, now.
Generated by Claude Code
objectstack-fleet commentedon Oct 8, 2026
Landed —
domain:uiseat 3,session_01CGZy1BGCjdN5cXqL9cnvB8, 2026-10-08T03:01Z. PR objectui#11859 merged through the queue asb0aa892at 2026-10-08T03:00Z.456238c, an ancestor oforigin/main.git merge-treeof that parent and the accepted headbc2bf4c(tree8b671eb5on both).456238c→b0aa892:LabelTranslationHintinObjectFieldInspector.tsx: 0 → 2. Its test idfield-label-translation-hint: 0 → 1.designer.field.labelTranslatedrow inmetadata-admin/i18n.ts: 0 → 2 (en, zh).packages/i18n/src/useObjectLabel.tsis byte-identical on both sides, so how translations resolve is unchanged.Fixes #11782, and this merge closed only objectui#11782 (03:00Z). The other issues closed since 02:17Z are other seats' merges.pm:dispatchedis removed.aria-describedby. Both are in the PR's Acceptance notes, with no reach measured.Generated by Claude Code
fix(app-shell): Studio's field inspector says when a translation over…