Repository navigation
studio(landing): a read-only package offers no way to start a writable copy — BuilderLanding comments disagree on whether Duplicate applies to read-only packages #11808
Description
Filing gate ② — a product decision only the maintainer can make.
Who acts on it: objectui triage → the Studio / app-shell owner. ⛔ Not a claim. Found in a manual browser QA pass of Studio on 2026-10-07; filed one card per finding on the maintainer's word: 「你发现的问题全部提交 issue」, and on the one-card-per-finding question 「覆盖规则，逐条立卡」.
Maintainer quick-read
The Studio landing lists installed packages as "Read-only · browsable" with no way to start a writable copy. Offer one?
Seen
BuilderLanding carries two comments that disagree: one says a read-only code package is "a STARTING POINT, not a dead end — duplicate re-namespaces it into a new writable base"; the one above the Duplicate button says duplicate "only makes sense for writable bases … customizing a code package goes through templates / marketplace install". The button renders for writable packages only.
Options
- A — Customize a copy on read-only cards (server-side duplicate into a new namespace).
- B — keep it writable-only and fix the comment; point read-only cards at the marketplace/template route.
- C — status quo.
Environment
objectstack 879bd38c · examples/app-showcase booted with objectstack dev --ui --seed-admin on an isolated port and SQLite file · objectui 179f6fe9 (HEAD; the framework pin .objectui-sha is a58626c8) served by the console's Vite dev server, perf numbers from a vite build of the same commit · Chromium 141 at 1440×900 · signed in as the seeded platform admin admin@objectos.ai unless stated.
Duplicate check
- Semantic issue search on objectstack-ai/objectui (open and closed), read-only package duplicate writable copy studio landing customize: 8 hits (0 open, 8 closed).
- Semantic issue search on objectstack-ai/objectui (open and closed), BuilderLanding duplicate package action hidden for code-defined read-only package: 5 hits (0 open, 5 closed).
- Related, not the same defect:
- Studio: package-declared permission sets render locked, with Clone-to-customize as the only edit path (UI half of objectstack#11513) #5987 (closed) — clone-to-customize precedent for read-only content, per item not per package
- Studio: read-only packages accept edit gestures client-side, fail only at server write #2259 (closed) — read-only package handling family
- Positive control in the same run: related lists action id refusal notice shown to end users on objectstack-ai/objectui returned related lists: an action id the related object does not define draws a refusal notice above the list for whoever opens the record — an authoring fault shown to end users; scope it to authors/admins #11768: yes.
Dedupe words: read-only package duplicate writable copy · studio landing customize copy
Filed by Claude Code (session session_01D76mrPJrSSdaKRxR2rvrMG) from that QA pass.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 7, 2026
Path: write metadata — starting from an installed package | 缺项 | P3
Triage: first grade,
enhancement·priority:p3·domain:ui·area:studio·pm:queue. Filed as ②, but an accepted ADR answers it: the body's option BTriage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-10-07T17:32Z. ⛔ Not a claim, ⛔ not a dispatch.Triage: lands in
packages/app-shell/src/views/studio-design/BuilderLanding.tsx(the comments at:54and:133, and the read-only card) ⇒domain:ui; rationale: a Studio or console surface in objectui. Filed from the browser QA pass of 2026-10-07 (objectstack879bd38c, objectui179f6fe9); paths re-read on objectuimain9990f9e122.allowOrgOverrideallows (0070-package-first-authoring.md:30, ADR-0005). D4's Duplicate clones a base, the ADR's word for a writable package (:80). So the comment at:133is right and the one at:54is wrong. Why p3: nothing is lost; the read-only card is a dead end.:54comment to D4's readingClause-②: no. Patch changeset in objectui.objectstack-fleet commentedon Oct 8, 2026
Claim: PM loop round 3
Session:
session_01MgfduSkFrfM3eorB3UGfAUAccount:
os-billBranch:
claude/issue-11808-readonly-package-cardWorktree:
objectui-issue-11808Domain:
domain:uiSeat:
domain:ui#2File surface (line numbers on
340bfab):packages/app-shell/src/views/studio-design/BuilderLanding.tsx::54, corrected to ADR-0070 D4's reading: Duplicate clones a writable base;:133–:137;allowOrgOverrideallows it, and the marketplace or a template.engine.studio.landing.*rows, en and zh, in app-shell'smetadata-admin/i18n.ts..changeset/11808-*.md.⛔ Not on it:
6043283623rules that it would amend ADR-0070 D4, and only the maintainer can ask for it.isSpecPackageId(objectui#11855, landed475bda1): left as they are.StudioDesignSurface.tsx, held by other claims.packages/components/src/ui/**andpackages/i18n/**.Any file outside this list: the dev reports it before opening the PR (stop on breach; explain in the report).
Container & model:
S,mode:subagent,model: opus(dispatch-gates --tier --repo objectstack-ai/objectuiover these paths: no path-derived mandate; default tier)Clause-②: no
Responsibility:
objectui app-shell Studio landing: a read-only package's card offers no route forward, and BuilderLanding's comments disagree on whether Duplicate applies to read-only packages | ADR-0070 D4 duplicates a writable base, and read-only packages are customized by org overlay where allowOrgOverride allows | every author who opens /studio with an installed read-only package, seen by the filer's 2026-10-07 browser QA passThread-read: 6043283623
Serial constraints cleared:
noneblocking.475bda1.pm:retriage). It holds no file.BuilderLanding.tsx.Why
Clause-②: no: the comments and the read-only card's guidance change, and no behaviour the ADR rules out is added. No export, prop, route orpackages/i18nkey changes.Generated by Claude Code
objectstack-fleet commentedon Oct 8, 2026
os-dev-report
{
"issue": 11808,
"status": "done",
"branch": "claude/issue-11808-readonly-package-card",
"pr": "#11927",
"session": "session_01MgfduSkFrfM3eorB3UGfAU",
"premise_still_valid": true,
"summary": "BuilderLanding's two Duplicate comments now state ADR-0070 D4's reading: Duplicate clones a writable base and is offered on writable bases only, and a read-only package is customized by org overlay (D2, ADR-0005). The STARTING POINT / re-namespaces / 'substance behind Start with a template' wording is gone, and the module doc's 'D4 gate' for writability now reads D2. Each read-only card keeps its browse click and gains 'Customize with an overlay', a link to /apps/setup/metadata?package=PACKAGE_ID (the package's metadata directory, which marks per type whether it accepts an overlay). The read-only section gains one sentence saying why, plus a marketplace link (/apps/setup/system/marketplace, the route Home's 'Start with a template' opens), rendered only when isMarketplaceEnabled(). The copy is four new engine.studio.landing.* rows in en and zh, plus a reworded engine.studio.landing.description, which had said 'browse only'.",
"hypotheses": {
"H1": "partly falsified. allowOrgOverride is a metadata-TYPE flag (spec DEFAULT_METADATA_TYPE_REGISTRY: true for view/dashboard/report/translation/email_template, false for object), never a per-package or per-object flag, so no overlay of an object exists. The overlay editor is ResourceEditPage at /apps/setup/metadata/TYPE/NAME; the package-scoped entry is MetadataDirectoryPage at /apps/setup/metadata?package=PACKAGE_ID, the metadata index route in both AppContent branches. Its buildPackageScopeOptions drops only system/cloud, the same scopes parsePackages hides. The marketplace is /apps/setup/system/marketplace, absent when features.marketplace is false (objectui#5504). Home's 'Start with a template' navigates to that same URL. The clause 'card does not offer the overlay where allowOrgOverride is false for the package' has no package-level answer, so the card links to the page that shows the per-type answer. NOT MEASURED in a browser: no backend (the objectstack checkout has no node_modules); measured by route declarations plus the RTL test under a real MemoryRouter.",
"H2": "falsified for overlay: PkgEntry carries writable only. A per-package 'any overlayable type?' answer needs useMetadataTypes plus useGlobalDiagnostics.packagesByType, one call per package, which the console reads only on the directory page. Not added: no new read, no new endpoint.",
"H3": "holds: grep -ci 'STARTING POINT|re-namespaces|writable copy' on BuilderLanding.tsx answers 0; every Duplicate/read-only comment states D4's reading."
},
"files_changed": [
"packages/app-shell/src/views/studio-design/BuilderLanding.tsx",
"packages/app-shell/src/views/metadata-admin/i18n.ts (engine.studio.landing.* rows only, en+zh: 4 added, description reworded)",
"packages/app-shell/src/views/studio-design/BuilderLanding.readonlyRoutes-11808.test.tsx (new)",
".changeset/11808-readonly-package-card.md (new, @object-ui/app-shell patch)"
],
"gates": {
"head": "1049ee0fb (git rev-parse --short HEAD after the last commit; the remote branch head is the same sha)",
"results": [
"pnpm exec vitest run (3 BuilderLanding tests + studio-locale.i18n.test.tsx + packages/core/src/utils/tests/column-identity.ratchet.test.ts + 8 apps/console tests naming BuilderLanding) via os-verify-lock: 'Test Files 13 passed (13)', 'Tests 67 passed (67)', 'VERDICT command-exit 0'",
"turbo run build --filter=@object-ui/app-shell^... --concurrency=2 via lock: 'Tasks: 28 successful, 28 total', 'VERDICT command-exit 0'",
"pnpm --filter @object-ui/app-shell type-check (echoed 'tsc --noEmit && tsc -p tsconfig.test.json'; --listFilesOnly lists the new test) via lock: 'VERDICT command-exit 0'",
"pnpm exec eslint on the 3 touched sources --format json: 3 files, 0 errors, 0 warnings, exit 0; eslint.config.js sets no parserOptions.project, so linting is not type-aware",
"pnpm check:i18n-keys exit 0 ('Every in-scope call-site key resolves against the en pack')",
"pnpm check:i18n-designer-parity exit 0 ('Every en row has a zh row, and every shared row carries the same placeholders.')",
"pnpm check:i18n-drift exit 0 ('Every changed designer-table en value was followed by its zh row.')",
"pnpm check:i18n-dead-keys exit 0 (report-only; no key from this diff is listed)",
"node scripts/check-changeset-presence.mjs exit 0 ('this change declares 1 changeset(s): .changeset/11808-readonly-package-card.md')",
"node scripts/check-changeset-no-major.mjs exit 0 ('No changeset declares a
majorbump.')","pnpm check:new-line-citations exit 0 ('VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only -> exit 0')",
"pnpm check:control-bytes exit 0 ('check-control-bytes: OK')",
"pnpm check:changeset-claims exit 0, pnpm check:pending-changeset-literals exit 0",
"node scripts/check-vi-mock-specifiers.mjs / check-vi-mock-override-shape.mjs / check-vi-mock-inherit.mjs / check-test-path-roots.mjs, pnpm check:unreferenced-sources: all exit 0 with OK lines"
],
"derivation": "by hand from objectui package.json scripts and .github/workflows check commands, against the diff's files (objectui has no dispatch-gates.mjs); added to the PM lead: i18n-drift, i18n-dead-keys, changeset-claims, pending-changeset-literals, the three vi-mock gates, test-path-roots, unreferenced-sources"
},
"tests": "New BuilderLanding.readonlyRoutes-11808.test.tsx, 6 cases, run against the real BuilderLanding with the real initRuntimeConfig. Reverse verification after committing the fix: the base 340bfab BuilderLanding.tsx was written back to disk (overlayPath count 0, STARTING POINT count 1) and the run gave 'Tests 3 failed | 3 passed (6)'. Red: the overlay link and both marketplace cases. Green: the three cases that pin behaviour the base already had. Restored with git checkout HEAD --, proven by blob hash == HEAD blob and an empty git diff HEAD, under a trap.",
"deviations": [
"H1's clause 'where allowOrgOverride is false for the package or object, the card does not offer the overlay' is not implemented as written. Its premise is falsified (the flag is type-level), so the card always links to the directory, which shows the per-type answer.",
"Docs-driven rule (objectui AGENTS.md #2): no content/docs row added, because it is outside the claim's file surface. No existing doc sentence becomes false: the README's 'a read-only package opens in Studio as browse-only' still holds.",
"Browser verification NOT MEASURED: no backend in the container.",
"Commit trailers use objectui AGENTS.md's model-free pair (Co-authored-by: Claude, Claude-Session), not the harness reminder's model-named line. The PR body ends with the session-URL footer from os-dev, not the harness's line. Both follow the rule that the harness's attribution reminder yields to the repo rule."
],
"mcp_calls": "0 — no MCP GitHub tool used",
"api_writes": "3 — each a fleet-write relay POST /repos/objectstack-ai/objectstack/dispatches executed as objectstack-fleet[bot]: (1) pr_create, i.e. POST /repos/objectstack-ai/objectui/pulls, draft; read-back said 8535 bytes sent, 8535 stored, identical; (2) label-write --assign os-bill, i.e. POST /repos//issues/11927/assignees; read-back matched; (3) this os-dev-report comment, POST /repos//issues/11808/comments. Plus git push of the branch (not REST). Read-only REST: GET issue 11808 and its comments, GET pulls/11927.",
"open_questions": [
{
"question": "Docs-driven rule: should the Studio landing's read-only card get a row in content/docs/guide/console.md, beside 'Package-less Flows in Studio'?",
"options": [
"A: the seat adds one row (a read-only package links to its org overlay directory and, where served, the marketplace), extending the claim or as a docs follow-up",
"B: leave it; no existing doc sentence is false"
],
"recommendation": "A: one row, low cost. AGENTS.md #2 says the change is not done until the docs reflect the code."
},
{
"question": "Should the card hide the overlay link for a package that ships no overlayable type?",
"options": [
"A: keep it as is; the link opens the directory, which shows each type locked or overlayable",
"B: add a per-package read (metadata types registry plus that package's type contributions, one diagnostics call per read-only package) and hide the link when nothing is overlayable"
],
"recommendation": "A: no new read and no N+1 on the landing, and the destination already gives the answer. B is a new read, which the dispatch reserved to the seat."
}
],
"out_of_scope_findings": [
"carrier: 承接者:无 · noted, not filed — the builder header's engine.studio.pkg.readonlyHint ('Read-only package — switch to or create a writable package to edit.') in StudioDesignSurface names no overlay route. It is not false, only incomplete: an observation, not a filing class. Not in the PR's Acceptance notes, because the PR body is written once; if the seat wants it there, add one bullet."
],
"cleanup": "worktree /home/user/objectui-issue-11808 removed (node_modules deleted first, plain git worktree remove, no --force); no dev server or background job left running"
}
objectstack-fleet commentedon Oct 8, 2026
Review: ACCEPT — PR objectui#11927 ·
domain:uiseat 2 · 2026-10-08T07:24ZImplemented-by:
os-devsubagent ofsession_01MgfduSkFrfM3eorB3UGfAU, branchclaude/issue-11808-readonly-package-card, heada8d4e93(code at1049ee0, docs patch round on top).Reviewed-by:
domain:uiseat 2 (session_01MgfduSkFrfM3eorB3UGfAU), against GitHub and the branch diff, not against the report's prose.Checklist:
PR shape: draft, base
main, first lineFixes #11808. No closing keyword sits next to another card.Clause-②: nois at the start of a line. The body was refreshed by the seat to matcha8d4e93.Scope: 5 files, all inside the claim:
BuilderLanding.tsx;metadata-admin/i18n.ts: four newengine.studio.landing.*rows and a rewordedengine.studio.landing.description, en and zh;content/docs/guide/console.md. The surface was amended by that file under AGENTS.md's docs-driven rule; no claim or open PR holds it.The Duplicate form,
isSpecPackageId,StudioDesignSurface.tsx,packages/i18n/**andpackages/components/src/ui/**are untouched. Nothing duplicates a read-only package, which is the ADR-0070 D4 line triage drew.Triage direction met:
/apps/setup/metadata?package=…)./apps/setup/system/marketplace, the same route as Home's Start with a template) only whenisMarketplaceEnabled().H1 partly falsified, accepted:
allowOrgOverrideis a metadata-type flag, not a package or object flag, and objects take no overlay. So the card links to the directory page that shows each type's answer, instead of hiding the link per package.H2:
PkgEntrycarries no overlay fact. No new read or endpoint is added.Q2, the seat's answer: keep the link as it is, rather than adding a per-package read that would cost one request per read-only package on the landing.
Clause-②: noholds: no export, prop, route orpackages/i18nkey. The strings live in app-shell's own table, andcheck:i18n-driftand the designer parity check pass.Changeset:
@object-ui/app-shell: patch. Every sentence was checked against the diff.Evidence:
BuilderLanding, and the column-identity ratchet.340bfabblob, 3 of the 6 new pins fail (the overlay link and both marketplace cases), and the 3 pins of existing behaviour stay green. The restore was proven.a8d4e93.CI:
a8d4e93is running. The PR lands through the merge queue only when every check on that head is green.Out-of-scope note,
carrier: none: the builder header'sengine.studio.pkg.readonlyHintnames no overlay route. It is incomplete, not false.Generated by Claude Code
fix(app-shell): a read-only package's Studio landing card points at o…