record page History: an activity row with no actor at all (actor_id and actor_name both null: seed and system writes) reads "Unknown user" with a "?" avatar — it reads System #12527

Activity

1. objectstack-fleet

   added

   bugSomething isn't workingSomething isn't working

   pm:queue

   priority:p2

   domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatobjectui ui stream: fix lands on the published library or apps — objectui execution seat

   area:recordsBusiness objects, records, the views that show data, usable forms, searchBusiness objects, records, the views that show data, usable forms, search

   pm:dispatched

   and removed

   pm:queue

   on Oct 15, 2026
2. objectstack-fleet

   assigned

   baozhoutao

   on Oct 15, 2026
3. objectstack-fleet commented on Oct 15, 2026

   

   objectstack-fleetBot

   on Oct 15, 2026

   ContributorAuthor

   More actions

   Claim: PM loop round 1
   Session: session_01XVp19E1MYUTFM3dnkwz8gB
   Account: baozhoutao (the seat's linked user as GET /user answers it; the card's assignee)
   Branch: claude/issue-12527-history-system-actor
   Worktree: objectui-issue-12527
   Domain: domain:ui
   Seat: domain:ui#2 (the card names the lane's next dispatch under seat 3's post #9800, which is vacant)
   File surface: packages/plugin-detail/src/HistoryTimeline.tsx and packages/plugin-detail/src/renderers/record-history.tsx (the no-actor label and glyph), packages/i18n/src/locales/*.ts (one new key in all ten packs), the tests beside each, and one .changeset/12527-*.md (stop on breach; explain in the report)
   Container & model: S, mode:subagent, model: opus (default tier; dispatch-gates --tier --repo objectstack-ai/objectui reads no path-derived mandate)
   Clause-②: no
   Responsibility: objectui's record History timeline, which labels an entry with neither actor_id nor actor_name as "Unknown user" | none: PR objectstack-ai/objectui#12070 resolves an actor_id, and an entry with no actor at all keeps the person-shaped fallback | every reader of a record page's History whose rows were written by the system (measured on HotCRM: every seeded lead's owner backfill and create rows)
   Thread-read: none
   Serial constraints cleared: at main b51242899, no in-flight claim or open PR touches HistoryTimeline.tsx, record-history.tsx or the i18n packs' history keys. objectui#12529 (claimed alongside, RecordDetailView.tsx) and objectui#12530 (this seat, sharedUserFeeds.ts) are disjoint.

   ---

   Generated by Claude Code
4. objectstack-fleet commented on Oct 15, 2026

   

   objectstack-fleetBot

   on Oct 15, 2026

   ContributorAuthor

   More actions

   os-dev-report
   {
   "issue": 12527,
   "status": "done",
   "branch": "claude/issue-12527-history-system-actor",
   "pr": "#12547",
   "session": "session_01XVp19E1MYUTFM3dnkwz8gB",
   "premise_still_valid": true,
   "summary": "HistoryTimeline now has three actor faces: a resolved name; no name and no user_id = System (detail.systemActor) with a lucide Cog glyph in place of the ? avatar; a user_id with no name = unknownUserText or Unknown user with ?. The record:history self-fetch now carries each row's actor id (bare actor_id or the expanded user record's id) onto HistoryEntry.user_id, which the type already declared, so the timeline can tell the two apart; activityActorName (#12067) untouched. No systemActorText override (no schema slot). Deviation: no new i18n key. detail.systemActor already exists, is translated in all ten packs and is what record:activity renders for the same no-actor row; reusing it avoids forking one word across ten packs, so no locale pack is touched and the changeset covers @object-ui/plugin-detail only.",
   "tests": "HEAD c18550e. vitest HistoryTimeline.test.tsx + record-history.{actorId-12067,contractEnvelope-6726,rowLimitRefusal-10005}: Test Files 4 passed, Tests 39 passed. vitest --maxWorkers=2 packages/plugin-detail/ (lock): Test Files 271 passed | 1 skipped, Tests 2630 passed | 14 skipped, VERDICT command-exit 0. Ablation (fix committed first; objectstack ablation-replace.mjs, anchor 1to0, blob 4adf08c8to20a50380): isSystemActor forced false gives 3 failed | 10 passed (two System pins in HistoryTimeline.test.tsx + the re-ruled #12067 third pin); Unknown-user pin stays green as expected; restore verified blob == HEAD 4adf08c8, git diff HEAD empty. Tests import HistoryTimeline by relative src path, so no dist rebuild was in the ablation path. Closure build pnpm --filter '@object-ui/plugin-detail^...' build exit 0; type-check plugin-detail + i18n exit 0 (both legs echoed type-check: Done). ESLint narrowed to the 4 changed ts/tsx files (count from --format json): 0 errors, warnings pre-existing (record-history.tsx 8 at base, 8 now); config has no type-aware linting, so untouched files cannot change verdict.",
   "gates": {
   "check:phantom-deps": 0, "check:self-import": 0, "check:unreferenced-sources": 0, "check:doc-example-readers": 0,
   "check:handler-key-reads": 0, "check:side-effects-array": 0, "check:element-data-source-declaration": 0,
   "check:spec-symbols": 0, "check:action-forward-parity": 0, "check:designer-field-key-parity": 0,
   "check:icon-record-names": 0, "check:i18n-keys": 0, "check:i18n-drift": 0, "check:i18n-designer-parity": 0,
   "check:control-bytes": 0, "check-changeset-fixed": 0, "check-changeset-presence": 0,
   "type-check plugin-detail+i18n": 0, "closure build": 0, "vitest touched": 0, "vitest plugin-detail": 0, "eslint narrowed": 0,
   "CI": "in_progress (not awaited, per contract)"
   },
   "line_budget": "n/a (no skills/** or governed surface touched)",
   "files_changed": [
   "packages/plugin-detail/src/HistoryTimeline.tsx",
   "packages/plugin-detail/src/renderers/record-history.tsx",
   "packages/plugin-detail/src/tests/HistoryTimeline.test.tsx",
   "packages/plugin-detail/src/renderers/tests/record-history.actorId-12067.test.tsx",
   ".changeset/12527-history-system-actor.md"
   ],
   "deviations": [
   "Section-1 ruling said one NEW i18n key in all ten packs; measured that detail.systemActor already exists, translated in all ten packs and used by record:activity for the same row. Reused it: no locale file edited, changeset is @object-ui/plugin-detail patch only (dispatch named @object-ui/i18n patch too). The ruling's end (properly translated System in all ten packs) holds; a zh pin proves the pack lookup. If the seat wants a distinct detail.history.* key anyway, that is a ten-pack follow-up the seat can order.",
   "The #12067 third pin (row with neither renders the existing fallback) is changed, not unchanged: the card re-rules exactly that row. The other #12067 pins are untouched.",
   "objectstack scripts/pm/dispatch-gates.mjs not run: it answers for the objectstack tree only; objectui gate list taken from the dispatch.",
   "Lock: first closure-build attempt was queue-timeout exit 99 (holder: another objectui worktree's vitest); re-acquired under the same slot and ran green."
   ],
   "mcp_calls": "0",
   "api_writes": "2 relay strokes + 2 git pushes: fleet-write dispatch pr_create (POST /repos/objectstack-ai/objectui/pulls draft + POST issues/12547/assignees) to PR #12547, read-back 4614 bytes identical, assignee baozhoutao; fleet-write dispatch comment (POST /repos//issues/12527/comments, this report). git push x2 (empty branch probe, c18550e). Zero label writes (dispatch named none; objectui labels via labeler.yml).",
   "open_questions": [],
   "out_of_scope_findings": []
   }
5. objectstack-fleet commented on Oct 15, 2026

   

   objectstack-fleetBot

   on Oct 15, 2026

   ContributorAuthor

   More actions

   Review: ACCEPT — objectui PR #12547 · domain:ui seat 2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-15T16:45Z

   Reviewed on GitHub at head c18550e, against the card's What to build 1–3 and Acceptance, and the claim (6196021892), not against the dev's report.

   • Shape: the PR is a draft against main. Its body opens Fixes objectstack-ai/objectui#12527, the only closing keyword, followed by Clause-②: no. 5 files.
   • Three actor faces in HistoryTimeline:
     • a resolved name;
     • no name and no user_id: System, with a lucide Cog glyph in place of the "?" avatar;
     • a user_id with no resolvable name: unknownUserText, or "Unknown user", with "?" (card item 2).
     • record:history's self-fetch now carries each row's actor id onto HistoryEntry.user_id, a field the type already declared. That is the bare actor_id or the expanded user record's id, and it is what lets the timeline tell the two cases apart. record:history maps the entry's user from actor_name only, so activity rows written without it (every row before objectstack#22510's fix) read "Unknown user" although actor_id is set #12067's activityActorName is untouched.
     • No systemActorText override was added, because the schema has no slot for one (card item 3).
   • Deviation, measured and accepted: the dispatch asked for a new i18n key in all ten packs. The dev reused the existing detail.systemActor instead: the seat read it in all ten packs (en "System", zh "系统", ar "النظام", de "System", es "Sistema", fr "Système", ja "システム", ko "시스템", pt "Sistema", ru "Система"), and record:activity already renders it for the same no-actor row. One word is not forked across ten packs, so no locale file changes, and a zh pin proves the pack lookup.
   • Pins and ablation:
     • A no-actor row renders "System" with the glyph; an unresolvable actor_id renders "Unknown user".
     • record:history maps the entry's user from actor_name only, so activity rows written without it (every row before objectstack#22510's fix) read "Unknown user" although actor_id is set #12067's third pin (a row with neither) is changed, as the card re-rules exactly that row. Its other pins are unchanged.
     • Forcing isSystemActor false fails 3 pins, and the Unknown-user pin stays green. Restore was proven by blob hash.
   • Changeset: @object-ui/plugin-detail: patch only, since no i18n pack changed.
   • Evidence: the closure build and the plugin-detail and i18n type-checks exit 0. packages/plugin-detail/ gives 2630 passed and 14 skipped under the lock. The battery exits 0, including check:i18n-keys and check:i18n-drift.
   • Acceptance note (not filed): the HotCRM browser reading (the seeded lead's three entries read "System") is the maintainer's check.
   • CI at head: 34 success, 3 skipped, 0 failures (filter=latest, 37 runs), all 16 test shards included.

   Next: pr_ready + automerge_enable.

   ---

   Generated by Claude Code
6. objectstack-fleet

   closed this as completedin #12547on Oct 15, 2026
7. objectstack-fleet commented on Oct 15, 2026

   

   objectstack-fleetBot

   on Oct 15, 2026

   ContributorAuthor

   More actions

   Landed · domain:ui seat 2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-15T17:01Z

   • Merged: PR fix(plugin-detail): a History entry with no actor reads "System", not "Unknown user" #12547 merged through the merge queue as main 165f8ff. The card closed by the PR's Fixes objectstack-ai/objectui#12527, which is the only closing keyword.
   • Verified by content: on origin/main, all 5 files the PR touches are blob-identical to the accepted head c18550e. They are HistoryTimeline.tsx, record-history.tsx, the two pin files and .changeset/12527-history-system-actor.md.
   • The HotCRM browser reading (the seeded lead's three History entries read "System") is the maintainer's check.
   • Label: pm:dispatched is removed in the same stroke as this comment.

   ---

   Generated by Claude Code
8. objectstack-fleet

   removed

   pm:dispatched

   on Oct 15, 2026
9. akarma-synetal

   added a commit that references this issue on Oct 28, 2026

   fix(plugin-detail): a History entry with no actor reads "System", not…

   ...

   This issue will close once commit 165f8ff is merged into the 'main' branch.

   165f8ff