You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
perf(test): make the DOM projects hermetic so they can run isolate:false (~3-4x suite speedup) #2648
Activity
os-zhuang commentedon Jul 18, 2026
决策:不采用 isolate:false,保持
isolate: true以优先长期稳定性评估后,维护者明确选择长期稳定性优先于一次性速度。理由:
isolate: false能带来 ~3-4× 提速,但代价是让整个dom套件永久对跨文件状态泄漏敏感。在这个 80+ agent 并行的仓库里:main会污染所有并行 agent 的基线(AGENTS.md 反复强调的红线);vitest.config.mts白纸黑字记录过,关闭 isolate 曾导致「上千个顺序依赖失败」。这个取舍不值得:#2641 / #2644 / #2647 已经把 CI 从 8.9 min 压到 ~2.5 min/片,安全收益已经兑现。用「更高的长期维护脆弱性」换那点即时收益,不符合本仓库的多 agent 并行现实。
若未来需要更多 CI 速度
用加分片这个零脆弱性的杠杆(
ci.yml里把 shard4 → 6),不要翻 isolate。若优先级改变要重开
本 issue 的完整定性(19 个泄漏文件、失败聚类、打法)保留供参考。但任何重启都必须走「shuffle 护栏持续强制 hermetic」的路径(修完泄漏 + CI 常驻
--sequence.shuffle守门),绝不裸翻开关。Closing as not planned.