You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
[P2] approvals: declare attachments on approve/reject and retire the inbox's hardcoded composer #2698
✅ Done — shipped in objectui#2710 (aefcf39) + framework#3332 (e412fb6).
The approvals inbox drawer now renders every decision — approve, reject, reassign, send-back, request-info, remind, recall, resubmit — purely through DeclaredActionsBar, with zero hand-wired action UI. Approve/reject collect a comment and file attachments through the generic declared-action dialog (the declared type:'file' param renders the shared upload widget; serializeParamValues maps the value to attachments: string[]). The hand-written composer, doAction, the upload handlers, the quick-phrase chips, and the admin actorOverride escape hatch are gone (~240 lines net removed from the inbox).
Browser-verified end-to-end: no composer, approve/reject render in the bar, the Approve dialog shows a file-upload widget, and staging a file + confirming POSTs {comment, attachments:["<fileId>"]}.
Original plan retained below for reference.
Goal
The approvals inbox drawer renders decisions purely through DeclaredActionsBar — zero hand-written action UI, including approve/reject and their attachments.
changed the title [-][P2] SDUI: `file`-type param in ActionParamDialog (unlocks attachment-carrying declared actions; retires the approvals approve/reject composer)[/-][+][P2] approvals: declare `attachments` on approve/reject and retire the inbox's hardcoded composer[/+]on Jul 20, 2026
changed the title [-][P2] approvals: declare `attachments` on approve/reject and retire the inbox's hardcoded composer[/-][+][P2] approvals: declare attachments on approve/reject and retire the inbox's hardcoded composer[/+]on Jul 20, 2026
Activity
[-][P3] SDUI: file-upload param in ActionParamDialog (to retire the approvals approve/reject composer)[/-][+][P2] SDUI: `file`-type param in ActionParamDialog (unlocks attachment-carrying declared actions; retires the approvals approve/reject composer)[/+]feat(app-shell): render ActionParamDialog params through the shared f…
[-][P2] SDUI: `file`-type param in ActionParamDialog (unlocks attachment-carrying declared actions; retires the approvals approve/reject composer)[/-][+][P2] approvals: declare `attachments` on approve/reject and retire the inbox's hardcoded composer[/+][-][P2] approvals: declare `attachments` on approve/reject and retire the inbox's hardcoded composer[/-][+][P2] approvals: declare attachments on approve/reject and retire the inbox's hardcoded composer[/+]feat(approvals-inbox): retire the approve/reject composer for declare…
test(app-shell): value-shape parity net for action params (#2714) (#2720