Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

[P2] approvals: declare attachments on approve/reject and retire the inbox's hardcoded composer #2698

Closed

Description

@os-zhuang

✅ Done — shipped in objectui#2710 (aefcf39) + framework#3332 (e412fb6).

The approvals inbox drawer now renders every decision — approve, reject, reassign, send-back, request-info, remind, recall, resubmit — purely through DeclaredActionsBar, with zero hand-wired action UI. Approve/reject collect a comment and file attachments through the generic declared-action dialog (the declared type:'file' param renders the shared upload widget; serializeParamValues maps the value to attachments: string[]). The hand-written composer, doAction, the upload handlers, the quick-phrase chips, and the admin actorOverride escape hatch are gone (~240 lines net removed from the inbox).

Browser-verified end-to-end: no composer, approve/reject render in the bar, the Approve dialog shows a file-upload widget, and staging a file + confirming POSTs {comment, attachments:["<fileId>"]}.


Original plan retained below for reference.

Goal

The approvals inbox drawer renders decisions purely through DeclaredActionsBar — zero hand-written action UI, including approve/reject and their attachments.

Delivered across:

  • objectui#2710 — FileField surfaces file_id; ActionParamDialog serializes upload params to file_id(s); composer retired.
  • framework#3332 — declared optional multi-file attachments param on approval_approve/approval_reject.

Refs

#2700 / #2704 / #2707 · objectui#2697 · framework#3300 · framework#3268 / #3274 · #2678 (P2-4) · cloud#861

Activity

  1. changed the title [-][P3] SDUI: file-upload param in ActionParamDialog (to retire the approvals approve/reject composer)[/-] [+][P2] SDUI: `file`-type param in ActionParamDialog (unlocks attachment-carrying declared actions; retires the approvals approve/reject composer)[/+] on Jul 19, 2026
  2. changed the title [-][P2] SDUI: `file`-type param in ActionParamDialog (unlocks attachment-carrying declared actions; retires the approvals approve/reject composer)[/-] [+][P2] approvals: declare `attachments` on approve/reject and retire the inbox's hardcoded composer[/+] on Jul 20, 2026
  3. changed the title [-][P2] approvals: declare `attachments` on approve/reject and retire the inbox's hardcoded composer[/-] [+][P2] approvals: declare attachments on approve/reject and retire the inbox's hardcoded composer[/+] on Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions