You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
waitEventConfig.onTimeout was removed in @objectstack/spec 17 (#4158). It had no readers at all — no code path ever inspected it, so neither fail nor continue ever happened. Delete the key.
Activity
yinlianghui commentedon Aug 5, 2026
认领:objectui 分片 PM 循环第 1 轮(v17 A 组,GA 前硬阻塞)
会话:
session_01GTRjn8xBqp75dk7kFupVRt分支:
claude/issue-3316-flow-wait-ontimeout-seedWorktree:
objectui-issue-3316域:objectui 分片(app-shell / metadata-admin previews)
文件面:
packages/app-shell/src/views/metadata-admin/previews/flow-canvas-parts.tsx、packages/app-shell/src/views/metadata-admin/previews/FlowCanvas.tsx+ 同目录测试 +.changeset/*.md(越界即停,报告说明)前提已对⚠️ 同日 churn 注记:#3294(flow 节点几何收敛,6e794a1)在本单立单后动过同批 flow 文件,
origin/main@68b6a28核验:两处onTimeout种子仍在(flow-canvas-parts.tsx:385、FlowCanvas.tsx:367)。FlowCanvas.tsx:367现为eventType: 'signal', signalName: 'revision', onTimeout: 'fail',与正文引用的快照已有出入 —— 派发词已要求 dev 以当前 origin/main 为准。Generated by Claude Code
yinlianghui commentedon Aug 5, 2026
PM 验收:ACCEPT → PR #3371 已转 ready + auto-merge(报告时 4 个 test 分片在跑,其余 11 项全绿;绿齐自动入队),跟到 MERGED。
落地内容:两个生产者(
defaultNodeExtras('wait')与addReviseLoop的 revision-wait)都不再种onTimeout;新增flow-canvas-seeds.spec-parse.test.tsx(25 例)按生产者而非文件划覆盖面 —— NODE_PALETTE 全类型 + start/end/http_request/boundary_event 整节点过 specFlowNodeSchema,revision-loop 节点从真实按钮点击捕获;config根的残缺种子(approval/notify/http)下沉到键级对 spec 在生键判定,并带[REMOVED]墓碑点名断言 —— 下一次退役会直接红在种子处并报出是哪个键。反向验证 4 红逐条点名,与预判方向一致。附加价值:① issue 建议第 3 点核验完成,其余分支无第二例;② 修正 issue 旁注 —— rc.2 下
timerDuration是z.string(),裸数字被拒,字符串通过(已记录防后人踩空);③ 消费半径扫描确认无陈旧 fixture 仍拼写onTimeout。v17 A 组(GA 前硬阻塞)至此代码侧闭环,待队列落地。
objectui 分片 PM
session_01GTRjn8xBqp75dk7kFupVRtGenerated by Claude Code
fix(app-shell): drop the retired waitEventConfig.onTimeout from flow …