Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

[i18n][finding] ListView 与 ObjectGrid 自拼英文标题传给 NavigationOverlay 的 title prop,绕过 detail.recordDetail 默认值 #3426

Closed

Description

@yinlianghui

观察类记录,发现于 objectstack#5506(PR #3423)实现过程,dev 报告后由 PM 立单归档;未验证用户可达性,故按 finding 持有,待发现分诊轮判级。

现象

PR #3423 把 NavigationOverlay 的 resolvedTitle 默认值接入了 i18n(detail.recordDetail),但两个调用方在传入侧自拼英文标题,默认值根本轮不到生效:

  • packages/plugin-list/src/ListView.tsx:2855 —— 拼 `${label} Detail` 传给 title;
  • packages/plugin-grid/src/ObjectGrid.tsx:2285 —— 传 'Record Detail' 字面量。

行号为 origin/main@789fe3ee2 时点,#3423 合并后可能漂移。

待分诊轮回答的问题

  1. 这两条路径是否用户可达(还是死默认/被上层再覆盖)?
  2. 可达的话,修法应是调用方入键(detail.recordDetail 复用 + {{label}} 变体),而不是删传参依赖组件默认——${label} Detail 带插值,组件默认值给不了。

查重:已搜 NavigationOverlay title(open,零命中,扫描器经邻近词反查有效)。

Generated by Claude Code

Activity

  1. self-assigned this
    on Aug 6, 2026
  2. yinlianghui commented on Aug 6, 2026

    @yinlianghui
    ContributorAuthor

    发现分诊(晋级):摘 finding 换 pm:queue,即派——objectui 分片 PM 并行批第 41 单。前置已解除:#3445 落地后 packages/i18n 语言包无在飞占用;#3444 落地后 NavigationOverlay 的 title 语义已按「titled header 拥有 h1」定形,本单是其调用方侧的收尾。

    认领:
    会话:session_01GTRjn8xBqp75dk7kFupVRt
    分支:claude/issue-3426-overlay-caller-titles
    Worktree:objectui-issue-3426
    文件面:packages/plugin-list/src/ListView.tsx、packages/plugin-grid/src/ObjectGrid.tsx(两处调用点)、packages/i18n/src/locales/*(十包,若需 {{label}} 变体键;本批独占)、两包测试、changeset。越界即停。
    与在飞第 37 单(components/ui + sync 脚本)、42 单(docs guide)互不相交。


    Generated by Claude Code

  3. yinlianghui commented on Aug 6, 2026

    @yinlianghui
    ContributorAuthor

    验收:ACCEPT → PR #3457(并行批第 41 单,会话 session_01GTRjn8xBqp75dk7kFupVRt),17/17 检查绿,已转 ready + auto-merge。

    复核要点:可达性判定是本单核心且做得扎实——两个调用点均以真实行点击测试证实可达(list-view/object-grid 是 public blocks,navigation 是 authorable key;app-shell ObjectView 的抑制是宿主覆盖而非死分支);裁定下的修法对称补全到两文件各三分支(label/objectName/裸字面),避免修一半留英文活口;detail.recordDetailWithLabel 十包齐、无标签分支复用 NavigationOverlay 自身默认键——一个控件一份翻译;反向验证两方向严丝合缝。顺带发现 #3459(kanban/tree/view 三处同款,含复数拼写决策)已分诊,裁定见该单。


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions