@object-ui/plugin-report 声明了 react-dom peer 却从未 import 它——仅作为 UMD 全局名出现在 vite.config externals #3740

Activity

1. yinlianghui

   added

   finding

   on Aug 8, 2026
2. os-zhuang commented on Aug 8, 2026

   

   os-zhuang

   on Aug 8, 2026 – with Claude

   Contributor

   More actions

   Findings triage: held — finding stays (labels unchanged).

   Stale-premise check (objectui origin/main @ b1204af): packages/plugin-report/package.json still declares react-dom: "^18.0.0 || ^19.0.0" in peerDependencies; zero react-dom imports across src/ (scanner control: sibling greps in the same batch returned hits). Premise live.

   Why held rather than promoted or closed: PR #3727's ruling deliberately kept and widened this peer — fixed-group consistency was chosen over cropping, so removing it now would reverse a made call without new information. It is also harmless today (every consumer of a React UI library has react-dom installed). But it is a true declared-but-unused requirement, so it stays recorded rather than closed.

   Restart signal: any ruling on cropping unused peers — most likely from the #3750 dispatch (queued this round), whose dev must already decide the same "does this package want a react-dom peer" question for five README-side overclaims; if that lands a crop-unused-peers principle, this card follows it mechanically.

   本评论来自分诊座位 Routine（#5474 试点），不构成认领。

   ---

   Generated by Claude Code
3. claude commented on Aug 10, 2026

   

   claudeBot

   on Aug 10, 2026 – with Claude

   Contributor

   More actions

   Findings round (periodic re-verification of oldest-checked holds): HOLD maintained (finding unchanged). Re-checked @ origin/main 6b6721c: packages/plugin-report/package.json still declares the react-dom peer (^18.0.0 || ^19.0.0) with zero react-dom imports under src/. The #3727 fixed-group ruling that keeps it stands; no new information.

   本评论来自分诊座位 Routine（#5474 试点），不构成认领。

   ---

   Generated by Claude Code
4. claude commented on Aug 10, 2026

   

   claudeBot

   on Aug 10, 2026 – with Claude

   Contributor

   More actions

   Findings triage: CLOSED (not planned) — the open question was already answered by the ruling the card itself records.

   Re-verified on objectui origin/main @ 564252c: packages/plugin-report/src still has zero react-dom imports; the peer remains declared in package.json:43 and the UMD global mapping at vite.config.ts:46. The card's one open question ("是否裁剪属独立取舍") is settled by the #3727 dispatch ruling it cites: fixed-group peer consistency was deliberately prioritized over per-package trimming, and trimming this one peer would recreate exactly the inconsistency that ruling removed. No consumer of a React UI plugin lacks react-dom, so the declared-but-unused peer costs nothing measurable. Reopen only if the plugin group's peer policy itself is revisited. Maintainer may veto by reopening.

   本评论来自分诊座位 Routine（#5474 试点），不构成认领。

   ---

   Generated by Claude Code
5. claude

   closed this as not plannedon Aug 10, 2026