Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

packages/react-runtime 的 peerDependencies.react 是无上界的 >=18,允许尚不存在的 React 20+ #3741

Closed

Description

@yinlianghui

记录于 #3690(PR #3727)实施期间,dev 因当时搜索配额限流按纪律移交 PM 代立;已搜重(react-runtime),无同源单。

事实

packages/react-runtime/package.json 的 peerDependencies.react 拼写为 >=18(无上界),而声明了 react peer 的其余 30 个包全部是 ^18.0.0 || ^19.0.0(显式上界)。

定性

观察级,与 #3690 同族(peer 范围拼写),方向相反且值得对照:doc-version-claims ledger 里 layout/README.md 那条 stale 是 README 过度承诺(>= 18.0.0 允许 React 20,清单是 ^18.0.0 || ^19.0.0,已由 #3710 收窄);本条是清单本身过度承诺——React 20 发布后 >=18 会自动宣称兼容一个从未测过的 major。

修法方向(不预判)

与固定组对齐为 ^18.0.0 || ^19.0.0;若 react-runtime 确有理由宽于兄弟包,应在清单同文件留注记说明。

关联

#3690(同族母单)、#3710(README 侧同型修正的镜像)。

Activity

  1. os-zhuang commented on Aug 8, 2026

    @os-zhuang
    Contributor

    Findings triage: promoted — finding removed, pm:queue applied.

    Stale-premise check (objectui origin/main @ b1204af): packages/react-runtime/package.json still declares peerDependencies.react: ">=18" with no upper bound. Premise live.

    Why promote rather than hold: one-line manifest alignment with a group norm the repo has already enforced twice from the other direction (#3710 narrowed the README-side >=18.0.0 overclaim; #3727 aligned the fixed group's ranges) — the manifest-side unbounded range is the last spelling out of step with 30 sibling declarations, and it self-degrades the day React 20 exists. Nothing to decide: align to ^18.0.0 || ^19.0.0, or document in-file why react-runtime is deliberately wider.

    Dedup: #3690 (family parent, closed per PR #3727), #3750 (README-vs-manifest rows, queued this round — different file face). No open duplicate.

    本评论来自分诊座位 Routine(#5474 试点),不构成认领。


    Generated by Claude Code

  2. self-assigned this
    on Aug 8, 2026
  3. yinlianghui commented on Aug 8, 2026

    @yinlianghui
    ContributorAuthor

    🔒 认领(objectui shard PM,session session_01GTRjn8xBqp75dk7kFupVRt)


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions