You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Finding-triage ruling: Hold (why still held): the second mergeViewsIntoObjects in core has zero in-repo consumers and diverges from the live app-shell merge, but removing a public export is a changeset-discipline change, not a drive-by; the record's chief value is stopping the next agent from mistaking it for the live merge. Restart: the next dead-code sweep or the next core public-surface changeset (ROADMAP.md:1428 item still unchecked).
Authorization: maintainer directive (this session) —「对于issue中的findings 执行一次集中分诊,并更新issue 的状态。」Centralized pass under that directive; finding grading is normally the triage seat's single channel. Round: objectstack#4949 finding-triage, 2026-08-10.
Session: 01JaVVMrSxt7Tgi1uwEuDtH7
Findings triage (re-verify @ origin/mainda81093): HOLD — the second copy (packages/core/src/utils/merge-views-into-objects.ts) still exists, is still publicly exported (core/src/index.ts:34), and still has zero in-repo consumers (the only new grep hit since filing, clientValidation.ts:76, is a comment). Divergence from the app-shell path stands. Exit is delete-with-changeset vs delegate — a public-API call, held for a ruling. finding stands.
Findings cadence (triage seat): HOLD — re-verified on origin/main @ e1ade8f: the second mergeViewsIntoObjects is still exported from @object-ui/core (packages/core/src/utils/merge-views-into-objects.ts:20) with zero in-repo consumers (only a prose mention in data-objectstack), still diverging from the app-shell path on default-list handling and view identity. Keep-vs-retire is an enforce-or-remove-shaped call on a public export; holds until graded with that question in front of whoever owns the core surface.
Findings triage (cadence re-verify @ origin/main5e2e9fa): HOLD as finding. The second mergeViewsIntoObjects still exists at packages/core/src/utils/merge-views-into-objects.ts and still has zero importers outside packages/core (repo-wide grep; counter-probe: the same pattern finds the live app-shell implementation in MetadataProvider.tsx and its merge tests). Dormant duplicate with the recorded defects (drops container default list, bare-key identity); promote as a deletion candidate in the next core dead-export sweep — deletion needs the usual tombstone/changeset discipline, not a rider.
Findings triage (cadence re-check): HOLD as finding — premise frozen.
Re-verified on origin/main @ b954120: packages/core/src/utils/merge-views-into-objects.ts still exists, and the repo-wide mergeViewsIntoObjects hit list is unchanged in kind — app-shell's own implementation + its tests, the core copy, and prose mentions (data-objectstack/src/index.ts, clientValidation.ts); still zero real importers of the core export.
Dormancy contract intact: no in-repo caller, divergence (no default list, bare keys) unreachable today. Delete-vs-delegate direction still undecided — stays with the card.
Rotation note: premise now frozen across 3+ checks; candidate for back-of-rotation if unchanged next cycle.
Findings cadence (triage seat): HOLD — re-verified @ origin/main6044d13: the second mergeViewsIntoObjects copy is still exported from packages/core/src/utils/merge-views-into-objects.ts:20, still with zero in-repo consumers (all live call sites resolve to the app-shell MetadataProvider implementation), still dropping the container default list and using bare keys rather than assembler identity. Dead-surface deletion candidate; no behaviour hit today. finding stands. Restart unchanged: fold into the next dead-surface sweep batch (the #3931 sweep shape is the precedent) or the next @object-ui/core utils touch.
Findings triage: promoted — finding → pm:queue as a member of sweep #4328 (dead-surface deletions batch 3). Not individually dispatchable while the sweep is open; the sweep PR closes it via Fixes.
Premise re-verified on origin/main @ b16be40: the second copy still exists at packages/core/src/utils/merge-views-into-objects.ts:20, re-exported via packages/core/src/index.ts:34, with zero in-repo consumers; the live copy is app-shell's MetadataProvider.mergeViewsIntoObjects (MetadataProvider.tsx:222, consumed at :697).
Activity
os-zhuang commentedon Aug 10, 2026
Finding-triage ruling: Hold (why still held): the second mergeViewsIntoObjects in core has zero in-repo consumers and diverges from the live app-shell merge, but removing a public export is a changeset-discipline change, not a drive-by; the record's chief value is stopping the next agent from mistaking it for the live merge. Restart: the next dead-code sweep or the next core public-surface changeset (ROADMAP.md:1428 item still unchecked).
Authorization: maintainer directive (this session) —「对于issue中的findings 执行一次集中分诊,并更新issue 的状态。」Centralized pass under that directive; finding grading is normally the triage seat's single channel. Round: objectstack#4949 finding-triage, 2026-08-10.
Session: 01JaVVMrSxt7Tgi1uwEuDtH7
Generated by Claude Code
claude commentedon Aug 10, 2026
Findings triage (re-verify @
origin/mainda81093): HOLD — the second copy (packages/core/src/utils/merge-views-into-objects.ts) still exists, is still publicly exported (core/src/index.ts:34), and still has zero in-repo consumers (the only new grep hit since filing,clientValidation.ts:76, is a comment). Divergence from the app-shell path stands. Exit is delete-with-changeset vs delegate — a public-API call, held for a ruling.findingstands.本评论来自分诊座位 Routine(#5474 试点),不构成认领。
Generated by Claude Code
claude commentedon Aug 11, 2026
Findings cadence (triage seat): HOLD — re-verified on
origin/main@e1ade8f: the secondmergeViewsIntoObjectsis still exported from@object-ui/core(packages/core/src/utils/merge-views-into-objects.ts:20) with zero in-repo consumers (only a prose mention indata-objectstack), still diverging from the app-shell path on default-listhandling and view identity. Keep-vs-retire is an enforce-or-remove-shaped call on a public export; holds until graded with that question in front of whoever owns the core surface.本评论来自分诊座位 Routine(#5474 试点),不构成认领。
Generated by Claude Code
os-zhuang commentedon Aug 11, 2026
Findings triage (cadence re-verify @
origin/main5e2e9fa): HOLD asfinding. The secondmergeViewsIntoObjectsstill exists atpackages/core/src/utils/merge-views-into-objects.tsand still has zero importers outsidepackages/core(repo-wide grep; counter-probe: the same pattern finds the live app-shell implementation inMetadataProvider.tsxand its merge tests). Dormant duplicate with the recorded defects (drops container defaultlist, bare-key identity); promote as a deletion candidate in the next core dead-export sweep — deletion needs the usual tombstone/changeset discipline, not a rider.本评论来自分诊座位 Routine(#5474 试点),不构成认领。
Generated by Claude Code
os-zhuang commentedon Aug 11, 2026
Findings triage (cadence re-check): HOLD as
finding— premise frozen.origin/main@b954120:packages/core/src/utils/merge-views-into-objects.tsstill exists, and the repo-widemergeViewsIntoObjectshit list is unchanged in kind — app-shell's own implementation + its tests, the core copy, and prose mentions (data-objectstack/src/index.ts,clientValidation.ts); still zero real importers of the core export.list, bare keys) unreachable today. Delete-vs-delegate direction still undecided — stays with the card.本评论来自分诊座位 Routine(#5474 试点),不构成认领。
Generated by Claude Code
os-zhuang commentedon Aug 11, 2026
Findings cadence (triage seat): HOLD — re-verified @
origin/main6044d13: the secondmergeViewsIntoObjectscopy is still exported frompackages/core/src/utils/merge-views-into-objects.ts:20, still with zero in-repo consumers (all live call sites resolve to the app-shellMetadataProviderimplementation), still dropping the container defaultlistand using bare keys rather than assembler identity. Dead-surface deletion candidate; no behaviour hit today.findingstands. Restart unchanged: fold into the next dead-surface sweep batch (the #3931 sweep shape is the precedent) or the next@object-ui/coreutils touch.本评论来自分诊座位 Routine(#5474 试点),不构成认领。
Generated by Claude Code
os-zhuang commentedon Aug 11, 2026
Findings triage: promoted —
finding→pm:queueas a member of sweep #4328 (dead-surface deletions batch 3). Not individually dispatchable while the sweep is open; the sweep PR closes it viaFixes.Premise re-verified on
origin/main@b16be40: the second copy still exists atpackages/core/src/utils/merge-views-into-objects.ts:20, re-exported viapackages/core/src/index.ts:34, with zero in-repo consumers; the live copy isapp-shell'sMetadataProvider.mergeViewsIntoObjects(MetadataProvider.tsx:222, consumed at:697).本评论来自分诊座位 Routine(#5474 试点),不构成认领。
Generated by Claude Code
chore(sweep): retire four zero-consumer declared surfaces (objectstac…