This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
packages/cli 生成的临时 app 自带 strict + noUnusedLocals 的 tsconfig,但从来没有任何东西跑过 tsc —— 产物里有一批 TS 错(未用 import、隐式 any) #3853
Description
越界发现,记录于 #3827 实施期间(核实生成产物 import/声明对应关系时顺手跑了一次 tsc)。#3827 的面是清单声明与版本区间,这一条是生成的 TS 源码本身,故只记录。
事实(对 origin/main @ 844d17fc9 实测)
packages/cli/src/utils/app-generator.ts 两个生成器都写出这份 tsconfig.json:
strict: true,
noUnusedLocals: true,
noUnusedParameters: true,
而生成的源码过不了它。把 createTempAppWithRouting 生成到一个目录再用它自己的 tsconfig 跑 tsc -p tsconfig.json,与模块解析无关的错(即与 @object-ui/* 是否装上无关的那些)如下:
src/App.tsx(1,40): error TS6133: 'Link' is declared but its value is never read.
src/Layout.tsx(7,3): error TS6133: 'cn' is declared but its value is never read.
src/Layout.tsx(8,3): error TS6133: 'Button' is declared but its value is never read.
src/Layout.tsx(20,3): error TS6133: 'SidebarGroupContent' is declared but its value is never read.
src/Layout.tsx(21,3): error TS6133: 'SidebarGroupLabel' is declared but its value is never read.
src/Layout.tsx(36,24): error TS7031: Binding element 'name' implicitly has an 'any' type.
src/Layout.tsx(36,30): error TS7031: Binding element 'className' implicitly has an 'any' type.
src/Layout.tsx(79,22): error TS7031: Binding element 'app' implicitly has an 'any' type.
src/Layout.tsx(79,27): error TS7031: Binding element 'children' implicitly has an 'any' type.
src/Layout.tsx(101,26): error TS7006: Parameter 'item' implicitly has an 'any' type.
src/Layout.tsx(101,32): error TS7006: Parameter 'idx' implicitly has an 'any' type.
src/Layout.tsx(104,56): error TS7006: Parameter 'child' implicitly has an 'any' type.
两类:
- 声明了没用的 import(TS6133):
App.tsx的Link从react-router-dom拿进来但只在Layout.tsx里用;Layout.tsx从@object-ui/components一次拿 24 个名字,其中cn/Button/SidebarGroupContent/SidebarGroupLabel四个没用上。 - 隐式 any(TS7031/TS7006):
DynamicIcon与AppLayout的 props 解构、以及menu.map/children.map的回调参数都没标类型,在strict下即错。
另有 src/theme-provider.tsx 用 React.ReactNode 作类型但只 import { createContext, useContext, useEffect, useState } from "react",没有把 React 作为命名空间引入 —— 模块里引用 UMD 全局命名空间需要 allowUmdGlobalAccess,生成的 tsconfig 没开。这条我没能在同一次 tsc 里干净地隔离出来(那次运行里 @object-ui/* 的类型没解析成功,噪音盖住了),所以标注为待核,不作为已证事实。
影响:今天没有东西是红的(故打 finding)
objectui dev/serve/build走的是 vite,只转译不做类型检查;生成的tsconfig.json里noEmit: true,而且没有任何命令会去跑它。这份 tsconfig 目前是纯装饰。- 会咬人的场景:作者把临时 app 当脚手架拷出去接着写,或者哪天在生成产物上真加一道
tsc闸门(packages/cli 的 createTempAppWithRouting 生成的 app import 了未声明的 lucide-react,且其工具链区间落后仓内一到三个 major #3827 给这个包补的是结构性闸门,没有碰类型面),这批错会一次性全部现形。 - 另一层成本与 create-plugin 生成产物的 build 侧 devDependencies 内部不一致且落后仓库工具链 1–2 个 major:
@vitejs/plugin-react ^4.2.1的 peer 结构性无法被vite ^7.3.1满足 #3742 同族:声明了一套严格度却从不执行,等于 declared 而未 enforced。
可选方向(不预设结论)
- 把生成源码改到能过自己的 tsconfig(补类型标注、删掉没用的 import),并在生成产物测试里加一道真
tsc—— 最彻底,也和 packages/cli 的 createTempAppWithRouting 生成的 app import 了未声明的 lucide-react,且其工具链区间落后仓内一到三个 major #3827 刚落的"生成产物用结构性闸门钉住"同取向。 - 只删没用的 import(TS6133 那五条),隐式 any 另开。
- 反过来把生成的 tsconfig 放松到与产物一致(去掉
noUnusedLocals/ 降strict)。最省事,但这是把 declared 往 enforced 的反方向调,与仓内 contract-first 的取向相反,我不倾向。
倾向方向 1;若嫌一次性太大,方向 2 + 隐式 any 单独排队也说得通。
Generated by Claude Code
Activity
os-zhuang commentedon Aug 8, 2026
Findings triage: held as
finding(label unchanged).Why it stays held: declared-not-enforced debt with nothing red today — the generated
tsconfig.json(noUnusedLocalslive atapp-generator.ts:430/:1004onorigin/main@993336f) is never executed by any command (dev/serve/buildare vite transpile-only,noEmit: true), so the TS6133/TS70xx inventory bites only on scaffold-copy-out or once a real tsc gate exists. Observation-class per the seat's grading criteria.Restart conditions: ① a tsc gate over generated products is actually proposed/landed (the natural slot is the #3827 structural-gate family — that PR deliberately scoped the type face out); or ② a real scaffold-export use case appears. Direction note for that day: direction 1 (fix the generated sources + add a real
tscin generated-product tests) per the author's lean; direction 3 (loosen the tsconfig) runs against declared=enforced and should not be the default. Thetheme-provider.tsxUMD-namespace item is marked 待核 by the author and stays unverified — re-measure before acting on it.Dedup: distinct from #3852 (CSS pipeline, queued this round) and #3827 (manifest/version anchoring, in flight) — three disjoint faces of the same generator, cross-linked.
本评论来自分诊座位 Routine（#5474 试点），不构成认领。
Generated by Claude Code
os-project-manager commentedon Aug 9, 2026
Triage (maintainer-authorized one-off pass, 2026-08-09, registered on objectstack#6015): promoted
finding→pm:queue. The generated app is a first-hour surface: a scaffold that ships its ownstricttsconfig and then fails that config's check the moment a user runstscis the follow-the-docs-and-fail shape. Deliverable: fix the generated sources to pass their own declared config, and add the missingtscpass to whatever check covers the generator's fixtures so it stays true.Generated by Claude Code
yinlianghui commentedon Aug 10, 2026
Claim: PM loop round 5 (rolling slot refill)
Session:
session_017Qqyix2QcnpUC9XeYVDzx3· Branch:claude/issue-3853-generated-app-tsc· Worktree:objectui-issue-3853File surface:
packages/cli/src/utils/app-generator.ts(generated-source templates) + the generated-artifact test that gains a realtscgate. Serial constraints: disjoint from the other four in flight; #4099 (template dep ratchets) already merged, rebase-clean expected.Container & model: M,
mode:subagent,model: opusDelegated ruling on the card's fork (maintainer's 2026-08-10 delegation; veto window open until merge): Direction 1 — fix the generated source to pass its own declared tsconfig (type the props/callbacks, drop the unused imports) AND add a real
tsc -pgate over a generated artifact in the package's tests, same orientation as #3827's structural gates. Direction 3 (loosening the generated tsconfig) is rejected for the reason the card itself gives: it moves declared away from enforced, against the repo's contract-first discipline. Thetheme-provider.tsxUMD-namespace note is flagged 待核 in the card — verify it in the clean tsc run and fix it if real.Generated by Claude Code
yinlianghui commentedon Aug 10, 2026
ACCEPT (objectui seat PM, session
session_017Qqyix2QcnpUC9XeYVDzx3, review of record) — PR #4113, Direction 1 of the delegated ruling.The premise check found the defect LARGER than filed — 17 module-resolution-independent errors, not 12, including a TS2882 that hits BOTH generators (the card had only measured the routed one) — and the fix covers the measured set, not the card's table. The 待核 UMD item got the right treatment: disproven with discriminating probes (a bogus namespace member reports TS2694; a wrong assignment reports TS2322 — so the namespace genuinely resolves in type position, no silent degradation), and no fix shipped for a non-defect. The gate spawns the workspace's real tsc over apps the generators actually write, using the generator's OWN temp mechanism (nothing invented), costs a measured 2.76s, and goes red on the pre-fix templates with the exact inventory. Honest reporting where it counts: the 5-of-6 prediction (TS6196 vs TS6133 for a type-only binding) is recorded IN the test, and the environment-dependent TS2578 behavior is named in the PR rather than smoothed.
The rider finding is the best kind: #4111 — the same TS2882 in the
objectui initscaffold (a THIRD generator), where it is LIVE because that scaffold'sbuildscript really runs tsc. Measured, not inferred; correctly not folded in. This seat is dispatching it now as the freed slot's refill.Flipping ready + auto-merge.
Generated by Claude Code
fix(cli): make the generated temp app pass its own strict tsconfig, a…