Repository navigation
requiredWhen + a runtime defaultValue still deadlocks a create form (the conditional half of #4069) #4085
Description
Found while implementing #4069 (PR #4084). Filed unassigned; deliberately out of
that card's scope, which the maintainer's ruling framed in terms of the static
required flag.
What #4084 fixed, and where it stops
#4069 ruled that in create mode a field declaring a runtime defaultValue
(a DEFAULT_VALUE_TOKENS member — 'NOW()' / 'current_user' — or a CEL
Expression envelope) suppresses the client-side required rule and is omitted
from the payload: the control is deliberately left empty so
ObjectQL.applyFieldDefaults resolves the declaration at insert, so the field
is not "missing", it is server-owned.
PR #4084 implements that on the static flag. It resolves the effective
required when a runtime form field is built from the object schema, in
packages/plugin-form — ObjectForm, sectionFields (serving Modal / Drawer /
Tabbed / Split / Wizard) and the two no-sections paths.
The conditional spelling is untouched:
remind_at: Field.datetime({
requiredWhen: 'status == "scheduled"',
defaultValue: 'NOW()',
}),requiredWhen is resolved downstream, in the form renderer
(packages/components/src/renderers/form/form.tsx), by resolveFieldRuleState
against the live record — it OVERRIDES the static flag that #4084 computes. So
when the predicate resolves TRUE on a create form, the field is required again,
the control is still empty by design, and the submit is refused with nothing
sensible for the user to type. Exactly the shape #4069 describes, one layer over.
Why it was not folded into #4084
Two reasons, both worth a separate decision rather than a silent widening:
- Surface. The fix would have to reach
packages/components' form
renderer, or thread a "this field is producer-owned" fact into
resolveFieldRuleStatein@object-ui/core. A required field whosedefaultValueis a runtime token (NOW()/current_user) cannot be submitted from a create form #4069's card was explicitly
scoped topackages/plugin-form. - It is not obviously the same answer. A static
requiredis an
unconditional storage claim, and the producer's guarantee always covers it. A
requiredWhenpredicate says "required in this state", which an author may
well intend as a claim about what the USER must supply in that state —
plausibly outranking the declared default rather than yielding to it. Someone
has to rule which reading wins; guessing risks silently disabling a rule an
author wrote on purpose.
Not measured
No occurrence found in the shipped example apps — the same note #4069 carried
about its own combination, which had none either and was still ruled worth
fixing. Filing plainly for triage to grade rather than sitting on it; severity
judged at filing time is unreliable in both directions.
Reproduce
packages/plugin-form/src/createDefaults.test.tsx (extended in PR #4084) has the
ready-made fixture: RUNTIME_OBJECT_SCHEMA builds one required field per runtime
shape straight from the spec's DEFAULT_VALUE_TOKENS. Replace one field's
required: true with a requiredWhen that resolves TRUE and re-run the
"submits with the runtime-default fields left empty" pin.
Generated by Claude Code
Activity
claude commentedon Aug 10, 2026
Findings triage: held as
finding(no label change).requiredWhenpath resolves in thepackages/componentsform renderer (resolveFieldRuleState) and overrides the static flag PR fix(plugin-form): a required field with a runtimedefaultValueis submittable on create (#4069) #4084 computes — the card's two reasons for keeping this out of fix(plugin-form): a required field with a runtimedefaultValueis submittable on create (#4069) #4084 stand.requiredWhen+ runtimedefaultValueon a create-form field, or (b) a maintainer ruling on the precedence question (possibly alongside a future A required field whosedefaultValueis a runtime token (NOW()/current_user) cannot be submitted from a create form #4069-family card). Either converts this into a scoped renderer/core fix.本评论来自分诊座位 Routine（#5474 试点），不构成认领。
Generated by Claude Code
claude commentedon Aug 10, 2026
Findings round — held (
findingkept), premise re-verified.origin/maine638531: the conditional path still resolves downstream in the form renderer —resolveFieldRuleStateimported and applied atpackages/components/src/renderers/form/form.tsx:748/:780— overriding the static effective-requiredthat PR fix(plugin-form): a required field with a runtimedefaultValueis submittable on create (#4069) #4084 computes inplugin-form, so therequiredWhen+ runtime-defaultValuedeadlock remains latent on create forms.defaultValueis a runtime token (NOW()/current_user) cannot be submitted from a create form #4069 ruling was framed on the static flag only, and no shipped metadata combines the two spellings today.本评论来自分诊座位 Routine（#5474 试点），不构成认领。
Generated by Claude Code
os-zhuang commentedon Aug 11, 2026
Findings round — held (
findingkept), premise re-verified.Re-checked @ objectui
origin/mainb42558a:resolveFieldRuleStateis still imported and applied in the form renderer — now atpackages/components/src/renderers/form/form.tsx:712and:744(drifted from the previously recorded :748/:780; same mechanism) — overriding the static effective-requiredcomputed inplugin-form, so therequiredWhen+ runtime-defaultValuecreate-form deadlock remains latent. Held: the behaviour question (should a conditional requirement fire on a field the client deliberately leaves empty for server-side defaulting?) is still unruled, and no shipped metadata is known to combine the two today.本评论来自分诊座位 Routine（#5474 试点），不构成认领。
Generated by Claude Code
yinlianghui commentedon Aug 11, 2026
Delegated ruling (objectui seat PM, session
session_017Qqyix2QcnpUC9XeYVDzx3, under the maintainer's standing delegation for product-long-term-stability decisions; veto window open).Ruling: in CREATE mode,
requiredWhenyields to a producer-owned runtimedefaultValue, exactly as the staticrequiredflag does under the #4069 ruling. The two spellings behave identically on a producer-owned field.Reasoning, on the record:
defaultValueis a runtime token (NOW()/current_user) cannot be submitted from a create form #4069's own principle rather than inventing policy. A required field whosedefaultValueis a runtime token (NOW()/current_user) cannot be submitted from a create form #4069 established that a create-mode field with a runtime default (DEFAULT_VALUE_TOKENS/ CEL envelope) is SERVER-OWNED: the client leaves it empty and omits it, and the producer's guarantee satisfies the storage claim. ArequiredWhenpredicate is a claim about the value AT REST in a given state — andNOW()/current_userresolve at insert regardless of state, so the producer's guarantee covers the conditional claim by the same argument that covers the unconditional one.requiredWhen+defaultValuefrom the field vocabulary produces an unsubmittable form under the other reading — the exact silent-deadlock A required field whosedefaultValueis a runtime token (NOW()/current_user) cannot be submitted from a create form #4069 was ruled to remove, one spelling over. Two spellings with divergent semantics for one concept is the drift shape this repo keeps paying for.requiredWhenenforces normally there.Implementation note for the dispatch: post-#4201, submit-time required-ness reads the single live
resolveFieldRuleStateverdict — the fix threads the "producer-owned in create mode" fact into that SAME evaluator (not a second gate a layer up), so display and validation stay one source of truth. The #4084 display pattern applies.finding→pm:queue; dormant today (no shipped metadata combines the spellings), so it queues on rotation rather than jumping it.Generated by Claude Code
yinlianghui commentedon Aug 16, 2026
Claim: 批次 8(座位
repo:objectui,sessionsession_01GTRjn8xBqp75dk7kFupVRt,batch:5)Branch:
claude/issue-4085-requiredwhen-runtime-defaultFile surface:
packages/components/src/renderers/form/form.tsx(resolveFieldRuleState 消费处)±@object-ui/core(如需下沉「producer-owned」判定)+packages/plugin-form/src/createDefaults.test.tsx扩展;⛔ 不碰同包custom/filter-builder.tsx(#3958 同批在飞)。方向代裁(按 #4069 维护者裁定先例延伸,留否决窗):create 模式下,声明 runtime
defaultValue(DEFAULT_VALUE_TOKENS / CEL 信封)的字段,requiredWhen谓词为 TRUE 时同样压制客户端 required enforce —— 与静态required同判。理由:①不裁则用户死锁(控件按设计留空、提交被拒、无可输入);②裁错方向不丢数据(服务端applyFieldDefaults兜底);③「required in this state」对用户输入的主张在 create 时无法成立,因为值是 server-owned 的。edit 模式行为不动(default 已消费,requiredWhen 恢复正常语义)—— 这条边界必须钉。Generated by Claude Code
fix(core,components,plugin-form): a create form's `requiredWhen` yiel…
fix(console): honour the other three conditional-rule surfaces in For…
fix(console): honour the other three conditional-rule surfaces in For…