FormPage: the FORM_RECORD_ID_PARAM comment cites a resolver unreachability that PR #4318 removed #4319

Activity

1. yinlianghui

   added

   finding

   on Aug 11, 2026
2. os-zhuang commented on Aug 11, 2026

   

   os-zhuang

   on Aug 11, 2026 – with Claude

   Contributor

   More actions

   Findings triage (first grade): HOLD — finding stays.

   • Premise re-verified @ origin/main 6044d13: the drift is real and current — apps/console/src/components/FormPage.tsx:123 still cites "the same unreachability createdRecordPath.ts documents for resolveHostAppSegment", while PR fix(app-shell,console): publish resolveHostAppSegment from the package root and delete the console's copy #4318 (merged, e4d1c08) made createdRecordPath.ts import the resolver from the package root (:57 import { resolveHostAppSegment } from '@object-ui/app-shell'). The surviving half of the comment also still holds: app-shell's root barrel exports no ./urlParams, so the literal remains justified.
   • Why hold: one clause, comment-only, zero behaviour, zero tests. Dispatching it standalone spends a claim + PR + CI cycle on a single sentence — the wrong fixed-cost ratio while the fix has a natural carrier.
   • Restart conditions: ① the next PR touching FormPage.tsx — the dispatch order should name this card as a declared out-of-surface add-on (the fenced app-shell: export resolveHostAppSegment from the package root — apps/console carries a documented local subset that must become a pure deletion #4280 dev correctly filed instead of touching); ② a comment-hygiene sweep batch in this repo, where this joins as one line of N (the stale-cross-reference family: toPredicateInput 仍有两份实现(core canonical / react 渲染器侧),应让 react 直接 re-export core #3367 / 动作 disabled 的「已声明」判定用 != null,disabled: '' 把按钮永久置灰(#3492 同族的另一半 predicate,探针实证) #3842 one level down, as the card notes).
   • Dedup: no other card covers this clause; app-shell: export resolveHostAppSegment from the package root — apps/console carries a documented local subset that must become a pure deletion #4280/fix(app-shell,console): publish resolveHostAppSegment from the package root and delete the console's copy #4318 are the cause, not an overlap.

   本评论来自分诊座位 Routine（#5474 试点），不构成认领。

   ---

   Generated by Claude Code
3. os-steve

   added

   documentationImprovements or additions to documentationImprovements or additions to documentation

   pm:queue

   and removed

   finding

   on Aug 17, 2026
4. os-steve

   added the

   Task

   issue type on Aug 17, 2026
5. os-steve commented on Aug 17, 2026

   

   os-steve

   on Aug 17, 2026 – with Claude

   Collaborator

   More actions

   Concentrated finding round (unified triage seat, 2026-08-17): promoted to pm:queue, type Task. One-clause comment repair in apps/console/src/components/FormPage.tsx: keep the still-true ./urlParams justification, drop the borrowed createdRecordPath.ts witness that PR #4318 resolved, per the card's own honest-replacement sketch. S / sonnet; batches naturally with any other stale-comment card the claiming seat holds (#4559/#4596/#4622 are the same family if a packaged sweep is preferred — claimant's call, declared in the claim).

   ---

   Generated by Claude Code
6. os-zhuang

   added

   domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatobjectui ui stream: fix lands on the published library or apps — objectui execution seat

   on Aug 21, 2026
7. os-sales

   added

   pm:dispatched

   and removed

   pm:queue

   on Aug 21, 2026
8. os-sales

   self-assigned this

   on Aug 21, 2026
9. os-sales commented on Aug 21, 2026

   

   os-sales

   on Aug 21, 2026 – with Claude

   Collaborator

   More actions

   Claim. PM seat domain:ui (seat post #5560), round 7. Session session_012u2pRjcqAYtoEjgr3wwhnK. Branch claude/issue-4319-formpage-urlparams-comment. pm:queue → pm:dispatched.

   Scope. One clause in apps/console/src/components/FormPage.tsx, around the FORM_RECORD_ID_PARAM literal.

   Keep the true half, drop the borrowed witness. The comment's own claim still holds — app-shell's root barrel still does not re-export ./urlParams, so the literal is still justified. What expired is the cross-reference: PR #4318 published resolveHostAppSegment from the package root and deleted the console's local subset, so createdRecordPath.ts documents no such unreachability any more; it imports the resolver. Point at the ./urlParams fact directly instead of borrowing a sibling's now-resolved case.

   Verify both halves before writing. Confirm on current origin/main that (a) the root barrel still omits ./urlParams, and (b) createdRecordPath.ts now imports resolveHostAppSegment from @object-ui/app-shell. If (a) has changed, the literal itself may no longer be justified and this stops being a comment fix — stop and report rather than repairing prose around a premise that moved.

   Note on the timing. This card's hold said its restart condition was "the next PR touching FormPage.tsx". That fired: this seat landed #5597 against that file earlier today. Dispatching it now rather than waiting for another carrier.

   Prose only — no behaviour, no tests. If your diff touches anything that emits JavaScript, stop and report.

   ---

   Generated by Claude Code
10. os-sales

    added a commit that references this issue on Aug 21, 2026

    docs(console): state the ./urlParams fact directly in the FORM_RECORD…

    ...

    This issue will close once commit 3756e86 is merged into the 'main' branch.

    3756e86
11. os-sales commented on Aug 21, 2026

    

    os-sales

    on Aug 21, 2026 – with Claude

    Collaborator

    More actions

    {
      "issue": 4319,
      "status": "done",
      "branch": "claude/issue-4319-formpage-urlparams-comment",
      "pr": "https://github.com/objectstack-ai/objectui/pull/5616",
      "premise_still_valid": true,
      "summary": "Replaced the expired cross-reference in the FORM_RECORD_ID_PARAM docblock of apps/console/src/components/FormPage.tsx. The comment's own claim was kept because it re-verified as still true; only the borrowed witness was dropped, and the ./urlParams fact is now stated directly with the exports map named inline so it is checkable without opening a second file. The resolver's publication is retained as PRECEDENT for retiring the literal rather than as a live second witness — a merged historical publication cannot later invert the way the old cross-reference did. Diff is exactly two files (the comment plus a required empty-frontmatter changeset), touches nothing governed, and is provably comment-only.",
      "tests": "NO TEST AND NO ABLATION IS POSSIBLE ON A COMMENT EDIT, and none was manufactured: there is no behaviour to assert and no code path to mutate, so no assertion could turn red. What was verified instead is the comment-only property itself, mechanically rather than by eye: both revisions transpiled with removeComments:true emit byte-identical programs (23064 bytes, sha256 4fdf391e7cebc470efbf6ff2b75ecffb2be641950e6a68c26c6bf3ee5ac1c36f, zero diagnostics both sides), and a CONTROL PROBE confirms that comparison can fail (mutating the literal to 'recordIdX' produced a different emit). Scope of that claim is deliberately limited: tsconfig.base.json sets removeComments:false, so comments DO ship — the claim is not that published bytes are unchanged, only that the diff carries zero program semantics. Gates, all at final commit 3756e86e9, exit codes captured before any pipe, each quoted from the gate's own verdict line: console type-check EXIT=0 (dependency closure built first — packages/app-shell/dist was absent in the fresh worktree, which would have been a false red); console lint EXIT=0 '200 problems (0 errors, 200 warnings)' with every FormPage finding pre-existing at lines 227+ while the edit is lines 141-148; 'pnpm exec vitest run apps/console/' from REPO ROOT EXIT=0 'Test Files 65 passed (65)' / 'Tests 710 passed (710)' (65 files, not the 22-file objectui#3378 cwd trap); check-changeset-presence EXIT=0; check-changeset-no-major EXIT=0; check-changeset-fixed EXIT=0; check-control-bytes EXIT=0 'scanned 4666 tracked text file(s)' (re-run AFTER commit — it scans only tracked files and the changeset was untracked on the first run, 4665 vs 4666); check-type-check-coverage EXIT=0; check-lint-coverage EXIT=0 '46/46 packages linted, 0 with outstanding errors'; check-phantom-dependencies EXIT=0; check-package-self-import EXIT=0; check-spec-symbol-derivation EXIT=0; check-action-forward-parity EXIT=0; check-i18n-call-site-keys EXIT=0; check-i18n-en-drift EXIT=0 'No en value changed in this range.'; check-node-esm-load --specifiers-only EXIT=0; check-skills-paths EXIT=0. check-eager-closure-budget first EXIT=2 — its self-declared BROKEN GAUGE, not a pass, because no console build had written apps/console/dist/eager-closure.json; the console was built and the real number read rather than arguing the change must be inert: EXIT=0 'Console eager closure is 3785.7 KB gzipped across 52 of 508 chunks (budget: 3867.2 KB, headroom: 81.5 KB)'. DECLARED NARROWING: repo-wide farm runs (pnpm lint over 46 packages, full 4-shard pnpm test, repo-wide pnpm type-check, the CLI's pnpm check) were left to CI, which runs them once regardless; the narrowing is sound here for a stronger reason than usual — the comment-stripped emit is byte-identical, so no type information or lint input anywhere in the workspace can have moved.",
      "evidence_half_1_literal_still_justified": "UNCHANGED, so the repair stayed a comment repair. packages/app-shell/package.json exports publishes only '.' and './styles.css' — no subpath pattern, so a deep import is unreachable too. grep for 'urlParams|RECORD_DRAWER_PARAM' in packages/app-shell/src/index.ts exits 1 with ZERO hits; CONTROL PROBE on the same file for 'resolveHostAppSegment' exits 0 hitting lines 74 and 79, so the absence is real rather than a broken search. A second sweep of every index.ts under packages/app-shell/src also returns zero. packages/app-shell/src/urlParams.ts does exist and defines RECORD_DRAWER_PARAM = 'recordId' at line 86 — present but unreachable to a consumer, which is exactly what the surviving justification claims.",
      "evidence_half_2_cross_reference_expired": "CONFIRMED EXPIRED. apps/console/src/components/createdRecordPath.ts:57 is `import { resolveHostAppSegment } from '@object-ui/app-shell';`, and its docblock documents the unreachability only in the PAST tense: ':33 its package root, and that root re-exported ./utils nowhere), so it shipped' / ':35 falls through further. #4280 published the resolver from the package root and'. A reader following the old cross-reference therefore found the opposite of what it promised.",
      "exact_replacement_clause": "BEFORE: ' * exports its package root alone and that root does not re-export\\n * `./urlParams` — the same unreachability `createdRecordPath.ts` documents for\\n * `resolveHostAppSegment`. `FormPage.test.ts` pins the two spellings equal so\\n * they cannot drift apart in silence.' ||| AFTER: ' * exports its package root alone — its `exports` map publishes `.` and\\n * `./styles.css`, nothing else — and that root does not re-export\\n * `./urlParams`, so `RECORD_DRAWER_PARAM` has no spelling a consumer can\\n * import. Retiring this literal means publishing the registry from that root,\\n * the way objectui#4280 collected `resolveHostAppSegment`. `FormPage.test.ts`\\n * pins the two spellings equal so they cannot drift apart in silence.' ||| The surviving FormPage.test.ts sentence was re-verified rather than assumed and left unchanged: FormPage.test.ts:260 pins FORM_RECORD_ID_PARAM to 'recordId', with a comment at :257 naming RECORD_DRAWER_PARAM in packages/app-shell/src/urlParams.ts.",
      "changeset_required": "YES — the gate was run rather than assumed, and it demanded one. First run EXIT=1: '1 source file(s) of 1 released package(s) changed, and this change adds no changeset: @object-ui/console'. apps/console sits inside the release's fixed group, so a change under its src/ must declare itself even though it is an application. Form chosen per the dispatch criterion — no consumer-visible API documentation changes — so EMPTY FRONTMATTER, the explicit first-class exemption, in .changeset/formpage-record-id-param-comment-4319.md. Gate then EXIT=0: 'Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate.' No skip-changeset label was created or applied: that label does not exist in this repo and applying one would silently mint it.",
      "mutation_confirmed_on_disk": "The edit was applied by a script that ABORTS unless its anchor matches exactly once (it reported OLD_ANCHOR_HITS=1), and landing was then proven by anchored greps rather than by the editor's exit code or a bare diff --stat: the removed text 'the same unreachability `createdRecordPath.ts` documents for' counts 0 after (was 1), the injected text 'Retiring this literal means publishing the registry from that root' counts 1 after (was 0), and the surviving `FormPage.test.ts` mention is still present.",
      "open_questions": [],
      "out_of_scope_findings": []
    }

    Draft PR #5616, 2 files, +17/-4, head 3756e86e9. Not flipped ready, no auto-merge, not merged. CI convergence is the PM's to read.

    ---

    Generated by Claude Code
12. os-sales

    closed this as completedin #5616on Aug 21, 2026
13. akarma-synetal

    added a commit that references this issue on Aug 23, 2026

    docs(console): state the ./urlParams fact directly in the FORM_RECORD…

    ...

    This issue will close once commit 49e750e is merged into the 'main' branch.

    49e750e