Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

Six pack keys render raw on provider-less hosts — their consumers' defaults tables lack the entry and the call sites carry no inline defaultValue (#3865 census residue) #4396

Closed

Description

@yinlianghui

Filed by the PM seat from PR #4372's accepted census (the #3865 option-A implementation), where these six were measured and explicitly left for a follow-up: of the 26 keys read outside their hook's defaults table, 20 carried an inline defaultValue and were fixed by #4372's fallback order; these six carry neither a table entry nor an inline default, so on a provider-less host createSafeTranslation's fallbackT returns the raw key string.

The six (from the census — re-verify each at claim time, call sites move)

key consumer hook (per the census)
detail.saving plugin-detail useDetailTranslation
list.resetSortToDefault plugin-list useListViewTranslation
appDesigner.widgetProperties plugin-designer useDesignerTranslation
appDesigner.addWidget plugin-designer useDesignerTranslation
appDesigner.modeEdit plugin-designer useDesignerTranslation
common.delete (census: outside-table without default — locate the actual call site)

Fix shape

Add each key to its consumer's module-local defaults table, byte-identical to the en pack value per each map's docblock contract (mechanically enforced for some maps — see objectui#3440's precedent). No pack edits, no new keys, no call-site changes. Red-first per key: a provider-less render asserting the raw key pre-fix, the en value post-fix (the #4372 test file has the mounting pattern).

Alternative for any key whose census attribution turns out stale (consumer gone, key retired): record the measurement instead of forcing an entry.

Why now

PR #4372 made inline defaults live, but these six have no fallback of any kind — they are the census's only remaining raw-key renders. Small, mechanical, fully enumerated.

Related: #3865 / PR #4372 (census source), #3810 (closed — its option C must not be revived as written), #3440 (byte-identity enforcement precedent).

Activity

  1. self-assigned this
    on Aug 12, 2026
  2. yinlianghui commented on Aug 12, 2026

    @yinlianghui
    ContributorAuthor

    CLAIM — PM seat session_017Qqyix2QcnpUC9XeYVDzx3, branch claude/issue-4396-six-bare-keys, one dev agent, one PR, Fixes #4396.

    Surface note at dispatch: defaults tables in plugin-detail / plugin-list / plugin-designer are free. common.delete's call site must be located first — if it lands in packages/components (held by the in-flight #4386) or any other held surface, that one key is report-don't-fix in the PR body, and the card stays satisfied by the other five plus the record. No pack edits anywhere in this PR.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions