Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

eslint 配置兑现 _ 前缀约定:补 varsIgnorePattern / caughtErrorsIgnorePattern(#4806 测量的 R1,822 条 warning 中 74.6% 是已标注「故意不用」的噪声) #4835

Closed

Description

@yinlianghui

来源

objectstack-ai/objectstack#25947 测量回报的 R1(判别材料全文见该卡回报)。PM 按契约机械类代裁派发,留否决窗。

事实(#4806 测量实测)

  • eslint.config.js:45 只设了 argsIgnorePattern: '^_'(只管参数),没设 varsIgnorePattern / caughtErrorsIgnorePattern;
  • 全仓 @typescript-eslint/no-unused-vars 822 条 warning 里 613 条(74.6%)已是 _ 开头 —— 作者早就按约定标注「故意不用」,配置没兑现;
  • 两大主类都是正当写法不是死代码:type-alias 442 条主体是测试里的类型级断言(type _NotAny = Assert<...>),destructuring 216 条主体是故意 omit 惯用法;
  • 修后预期 822 → 约 209,不掩盖任何真实缺陷(被消掉的全是 _ 标注项),零门禁强度变化(warning→warning)。

完成范围

  1. eslint.config.js 的 no-unused-vars 配置补 varsIgnorePattern: '^_' + caughtErrorsIgnorePattern: '^_';是否同时把 ignoreRestSiblings 修对(#4806 实测 rest-sibling 当前会被报,与 omit 惯用法冲突)由实施者实读现配置后判,披露依据;
  2. 修前修后各跑一遍全仓 eslint 计数,报文写进 PR(预期 822→~209 量级,偏差要解释);
  3. 反向验证:去掉新增 pattern 预判计数回升;
  4. ⛔ 不动任何规则的 severity;⛔ 不删任何代码;⛔ R2(import 子类提 error)/R3(base tsconfig)/R4/R5 不入本单。

参考

Activity

  1. self-assigned this
    on Aug 16, 2026
  2. yinlianghui commented on Aug 16, 2026

    @yinlianghui
    ContributorAuthor

    【认领】os-dev(session_01GTRjn8xBqp75dk7kFupVRt),分支 claude/issue-4835-eslint-underscore-convention。

    按完成范围四条执行:补 varsIgnorePattern / caughtErrorsIgnorePattern,修前修后全仓 eslint 计数对照,反向验证,ignoreRestSiblings 实读现配置与 typescript-eslint 语义后判并披露依据。只动 eslint.config.js,不动 severity、不删代码、R2–R5 不入本单。


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions