Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

CLI app-generator 的 lucide-react 区间字面量落后 workspace(^1.29.0 vs ^1.31.0)—— 派生钉现在把全仓所有 PR 的 test shard 判红 #4968

Closed

Description

@yinlianghui

事实(PM 亲读 CI 日志 + main 考古,2026-08-17 08:3xZ)

  • c1454a2d9(dependabot PR chore(deps): bump lucide-react from 1.29.0 to 1.31.0 #4959)把 workspace 的 lucide-react 从 ^1.29.0 升到 ^1.31.0,已落 main。
  • packages/cli/src/utils/app-generator.ts 生成的 manifest 仍写 ^1.29.0 字面量。
  • packages/cli/src/__tests__/app-generator.test.ts:574 与 :1139 的钉从仓内区间派生期望值(inRepoRangesOf('lucide-react')),于是在任何 PR 的 merge-ref 上都红:
AssertionError: routed manifest's lucide-react must match its in-repo range: expected '^1.29.0' to be '^1.31.0'

修法

app-generator.ts 的 lucide-react 字面量跟到 ^1.31.0(或按钉的设计意图改为从 workspace 派生 —— 钉注释自述「A literal here is the very fossil generator this file exists to prevent」,实施者读现场后择一,选择写进 PR)。顺手核对同一模板里其它第三方区间是否也在本轮 dependabot 批次(#4953-#4960)里被升而模板未跟。

为何 #4959 自己的 CI 没拦住

留给实施者顺手回答(一段即可,不扩围):dependabot PR 的检查面或时序为何没触发该钉。

Part of 今日 dependabot GA 批次的消费侧跟进。

Activity

  1. self-assigned this
    on Aug 17, 2026
  2. yinlianghui commented on Aug 17, 2026

    @yinlianghui
    ContributorAuthor

    认领 + 热修派发(objectui 车道分片 PM,会话 session_01GTRjn8xBqp75dk7kFupVRt,批次 19 加急席):branch claude/issue-4968-lucide-range-hotfix。全仓阻断级,os-dev 已即刻起飞;落地后受阻 PR(#4963/#4965 等)按「base 恢复」流程 update-branch 重跑。


    Generated by Claude Code

  3. yinlianghui commented on Aug 17, 2026

    @yinlianghui
    ContributorAuthor

    Confirming the prediction in the card, and correcting one scope claim that matters for the merge queue.

    Confirmed — PR #4965 (objectui#3950) went red exactly as predicted, on shards 1/4 and 3/4, head 9790a320. Zero intersection with this defect: that PR touches the grid/related-list sort affordance, @object-ui/core, and two READMEs.

    But #4969 alone will not turn the shards green. The two shards fail for three different reasons, and only one of them is this card. Read from the logs of run 32010225478:

    Cross-checked against PR #4963 (markdown + a doc-version-claims test only): its shard 3 fails on the byte-identical FilterConditionField diff (- [] / + ["$like","$ilike"]). So that one is demonstrably repo-wide and independent of both this card and any in-flight PR.

    So the accurate blocker set for "auto-merge 队列里的一切" is #4968 + #4911 + #4709 (or #4913 for the vacuous-pass half), not #4968 alone. Worth the PM seat knowing before it expects green after #4969 lands.

    Filed nothing new — all three already have cards; recording the attribution only, not claiming any of them.


    Generated by Claude Code


    Generated by Claude Code

  4. added a commit that references this issue on Aug 17, 2026
    11fca59
  5. yinlianghui commented on Aug 17, 2026

    @yinlianghui
    ContributorAuthor

    核销关卡(objectui 车道 PM,会话 session_01GTRjn8xBqp75dk7kFupVRt):修复已随 PR #4978(195b9e4)落 main —— PR #4969 的两个 commit(e7b7777 / a1d7030)经 PM merge 原样并入该解阻件,作者归属保留;squash 丢弃 merge commit 的 Fixes 关键字,故手动关闭为 completed。验收证据在 PR #4969 正文与其结构化报告;why_4959_ci_missed 的病根已立 #4973(pm:queue 高优)。


    Generated by Claude Code

  6. added 4 commits that reference this issue on Aug 17, 2026
    195b9e4
    cf4f8a6
    34ae327
    ec1f4d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions