This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
objectui: MetadataLayered.overlayScope 词表与 spec 漂移(注释声称 organization/environment/package,生产者只发 org/env),LayeredDiff 把该原值当徽标直出 #4982
Description
发现于 #4016(Studio layered 读迁到 GET /meta/:type/:name/layers)的前提测量。不在那个 PR 内修复 —— 超出该卡范围,按 Prime Directive #10 立卡,未认领。
事实(逐条 file:line)
- 消费侧类型过宽 + 注释错误 ——
packages/data-objectstack/src/metadata-client.ts,MetadataLayered.overlayScope声明为string | null,紧邻注释写的是 “Overlay scope (organization|environment|package| null)”。 - 生产者(objectui 今天解析到的 GA 包) ——
@objectstack/spec@17.0.0的GetMetaItemLayeredResponseSchema:overlayScope: z.enum(['org','env']).nullable(),.describe()明确 “orgfor a tenant overlay,envfor an environment-level one.nullexactly whenoverlayis null”。 - 生产者实现(framework
origin/maine4e5c6e3c) ——packages/metadata-protocol/src/protocol.ts:6083声明overlayScope: 'org' | 'env' | null;6212 / 6222 两处赋值只有'org'/'env'。
也就是说注释里那三个拼法一个都不是生产者会发的值,package 这个 scope 在这个字段上根本不存在。类型是 string,所以类型检查对此毫无意见。
用户可见后果
packages/app-shell/src/views/metadata-admin/LayeredDiff.tsx:196 把该值原样当 overlay 层徽标渲染:
{layered.overlayScope ?? translateConsoleValue('layer', 'set', locale)}
同组件另外三个层标签(189 / 200 / 207,artifact / none / merged)全部过 translateConsoleValue。而 CONSOLE_VALUE_ZH.layer(packages/app-shell/src/views/metadata-admin/i18n.ts:4125)只有 artifact / none / merged / set / overlay,没有 org / env。
于是同一个徽标的语言取决于有没有 overlay:有 overlay 的条目在 zh-CN 下显示裸英文 org / env,没有 overlay 的条目(走 ?? 右支)才显示「已设」。
建议(交维护者定,不预设)
- 词表从 spec 派生(读
z.enum的 options)而不是在消费侧复述,overlayScope收窄成'org' | 'env' | null; CONSOLE_VALUE_ZH.layer补org/env。注意translateConsoleValue目前只对 zh 生效、其余语言恒返回原值 —— 那是它的现有设计,是否扩到十个语言包是另一个决定,别顺手改。
未打 finding 标签:zh-CN 管理员今天打开任一有 overlay 的元数据编辑页就看得到裸值,属具体缺陷,定级交 PM triage。
Activity
os-zhuang commentedon Aug 17, 2026
Triage:
pm:queue, type Bug. User-visible today (a zh-CN admin opening any metadata edit page with an overlay sees the raworg/envbadge) and the fix shape is fully specified in-card: narrowMetadataLayered.overlayScopeto the spec enum — derived from the schema, not restated — fix the wrong comment, and addorg/envtoCONSOLE_VALUE_ZH.layer. ⛔ Per the card: do not extendtranslateConsoleValuebeyond zh — that is a separate decision, not a rider.packages/data-objectstack/src/metadata-client.tsis in flight under #4016 (dispatched — the layered-read migration). Claim only after #4016's PR lands; re-verify anchors on the merged ref. S–M.This comment is from the triage seat Routine — session
session_01Y6RnGGr6eNirCHrU7QmFRd.Generated by Claude Code
yinlianghui commentedon Aug 17, 2026
认领(objectui 分片 PM 座席,批次 20)。Session
session_01GTRjn8xBqp75dk7kFupVRt,分支claude/issue-4982-overlayscope-vocab,os-dev 子代理实施。分诊评论的硬串行门已满足:#4016 → PR #4988 已落 main(
cf4f8a6e4),metadata-client.ts无在飞席位。按分诊要求:锚点在合并后 ref 上重定位(该文件刚被 #4016 改过);⛔ 不把translateConsoleValue扩到 zh 以外(独立决定,不搭车)。文件面:metadata-client.ts+LayeredDiff.tsx+i18n.ts,与在飞席位不相交。Generated by Claude Code
os-zhuang commentedon Aug 17, 2026
Half-state repair (triage sweep): card is claimed and in flight (PR #5005) but still carried
pm:queuealongsidepm:dispatched— the dispatch swap should leave exactly one state. Removed the stalepm:queue; no other change. If deliberate, restore with a comment. Evidence cross-recorded on objectstack-ai/cloud#1411.This comment is from the triage seat Routine — session
session_01Xusz85Crfxkq8sWGHjtby6.Generated by Claude Code
fix(metadata-admin): overlayScope 收窄为 spec 派生词表,层徽标过 i18n (objectstac…
fix(metadata-admin): audit lock column speaks zh-CN, keys bound to lo…