Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

Dashboard cross-tab (pivot with >=2 dimensions) did not get #5827 row hover, and its sort story is unsettled #5836

Closed as not planned

Description

@os-zhuang

Noticed while implementing #5827 (PR #5834), which was scoped to the FLAT dataset table only. Filed as an observation, not a defect report — nobody has asked for it.

packages/plugin-dashboard/src/DatasetWidget.tsx has two table renderers inside if (isTable):

The cross-tab already right-aligns its measure cells, so the worst of #5827 does not apply. What it still lacks, measured by reading the branch:

  1. No row hover. Its <tr> carries only border-t; hover exists on individual drillable cells (hover:bg-accent/40 on dataset-drill-cell), never on the row. On a wide cross-tab, tracking a row across bucket columns is exactly where a row highlight earns its place.
  2. tabular-nums on the row-header cells. <td className="px-2 py-1 whitespace-nowrap font-medium"> for row-dimension labels — actually these do NOT carry it, unlike the flat table's cells; noting it here only so a future sweep does not "fix" it by adding one.
  3. No sortable headers. A cross-tab's axes are structural (row buckets down, column buckets across), so "click a header to sort" is not the same feature it is on a flat table — sorting rows by one across-bucket's measure is a real feature, but it is a design question, not a port of Dashboard table widget: right-align numeric columns, sortable headers, null bucket last, row hover — it currently reads as a raw dump #5827's implementation.

Item 3 is the one that needs a ruling before any code: whether a cross-tab should sort its row axis by a chosen cell column at all. Items 1 is mechanical.

Not blocking anything. Filed unassigned.

Activity

  1. claude commented on Aug 24, 2026

    @claude
    Contributor

    Finding concentration round (triage seat, session session_01Kktexqp6uVuFMztvvTMf3V, 2026-08-24, maintainer-invoked): closed not planned — cross-tab hover/sort polish with zero pull (the card's own words: "nobody has asked for it"), and its sort story is an unsettled design question nobody is blocked on. Per the standing rule for zero-pull polish (2026-08-16: 暂时不准备开发的应该直接关闭), the card-as-record stays and re-opening is free the day a user asks for cross-tab ergonomics. The measured gap list in the body is the re-open brief.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions