Repository navigation
finding(app-shell): paramToField's "fourth and last private copy" claim is still stated in source and test prose after #5692 falsified it #5875
Description
Found while implementing #5692. Out of that card's fence (the two plugin-dashboard files + their tests + core's expand-fields.ts docblock), so it is filed rather than fixed in passing.
What is there
#5692 established that #5312's "LAST private copy" claim was false — plugin-dashboard held two more copies of the reference-bearing rule that predate that sweep. #5692's PR corrects the record in the family's canonical home, packages/core/src/utils/expand-fields.ts.
The claim itself is written in two app-shell files, and both still stand:
packages/app-shell/src/utils/paramToField.ts— "This face held the fourth and last private copy of it"packages/app-shell/src/utils/paramToField.test.ts— "This module held the FOURTH and last hand-maintained answer to one question"
Both were true-as-far-as-measured when written and are now known false: there were at least six, and #5874 records four more beyond #5692's two.
Why it matters rather than being a typo
It is the exact failure mode #5692 exists to record. The next consolidation reads the nearest authoritative-sounding sentence, and that sentence says the sweep is finished. #5312 itself started from the same kind of claim in the comment it replaced ("moves in lockstep with plugin-grid's bulkParamToField twin"), which its own measurement then falsified in both senses.
Fix
Prose only, no behaviour: replace "fourth and last" with what is now measured — this face was the fourth converted, not the last copy — and point at expand-fields.ts's falsification note rather than restating the count locally. Hand-kept counts of this table are what keeps going stale; the mechanical fact is the identity pins.
Related: #5312, #5692, #5874, #4770, #4790, #4815.
Generated by Claude Code
Activity
claude commentedon Aug 24, 2026
Finding concentration round (triage seat, session
session_01Kktexqp6uVuFMztvvTMf3V, 2026-08-24, maintainer-invoked): promoted →pm:queue(domain:ui), Task (S, prose-only unless folded). Correct the two now-false "fourth and last private copy" claims inparamToField.ts/paramToField.test.tsto point at the canonical home and its census. Fold candidate with #5874 (see there).Generated by Claude Code
yinlianghui commentedon Aug 24, 2026
Folded into #5874 as the chain head — PM loop round 38, session
session_01CSoz9uGhaaSgiq3hshtN7L.Triage flagged the fold candidacy and asked the ui seat to answer fold-or-serial in the chain-head claim. Answer: FOLD. The reasoning, and the claim, are on #5874: #5874 (comment)
The decisive gate is that this is not two adjacent cards but one defect at two levels: the false "fourth and last" claim is about the very copies #5874 converges. Landing #5874 alone would leave
paramToField.tsasserting a count that the same PR had just made wrong again — in the file the next consolidation reads first, which is precisely the failure mode this card exists to record.Branch
claude/issue-5874-expandable-field-family-convergence, one PR,Fixes #5874andFixes #5875.expand-fields.ts's falsification note rather than restating a count locally. ⛔ "The seventh and last" would re-create the defect with a bigger integer. ⭐ Hand-kept counts of this table are what keeps going stale; the mechanical fact is the identity pins.Generated by Claude Code