finding(examples,docs): the four alert-dialog schema-catalog fixtures author an actions array no surface carries — the docs page's own examples render an empty footer

Found while implementing objectui#7104 (declaring the keys the alert-dialog renderer reads). Filed rather than folded in: the fixtures live under examples/schema-catalog/, outside that card's four-file fence, and the conversion is not mechanical (see below).

Measured on origin/main a3eb5d07a.

The measurement

All four fixtures under examples/schema-catalog/src/schemas/components-overlay-alert-dialog/ — basic-alert-dialog.json, confirmation-dialog.json, custom-actions.json, destructive-action.json — author their buttons as an actions array of button nodes, e.g. destructive-action.json:

{
  "type": "alert-dialog",
  "title": "Confirm Deletion",
  "description": "This will permanently delete your account and all associated data.",
  "trigger": { "type": "button", "label": "Delete", "variant": "destructive" },
  "actions": [
    { "type": "button", "label": "Cancel" },
    { "type": "button", "label": "Delete", "variant": "destructive" }
  ]
}

actions is carried by no surface: it is not on the TS interface, not in the zod mirror, and schema.actions appears nowhere in packages/components/src/renderers/overlay/alert-dialog.tsx (pinned by packages/types/src/__tests__/overlay-node-slot-doc-types-7082.test.ts). The renderer draws its footer from two other keys only: line 37 renders the cancel button only when schema.cancelText is truthy, and line 38 renders the action button only when schema.actionText is truthy (wiring schema.onAction as its click handler).

So every one of the four examples embedded on content/docs/components/overlay/alert-dialog.mdx through SchemaExample renders a dialog with a header and an EMPTY footer — no cancel button, no confirm button. custom-actions.json is embedded under a heading literally called "With Custom Actions".

Lit controls (same git grep, tracked files, node_modules/dist excluded): cancelText / actionText have three in-repo producers on an alert-dialog node — the renderer's registered inputs (alert-dialog.tsx:49-50), its defaultProps (:67-68), and packages/app-shell/src/__tests__/widget-dom-leak-sweep.test.tsx:719; actions on an alert-dialog node has exactly these four producers, all in the catalog; cancelLabel / confirmLabel / confirmVariant have zero producers on any alert-dialog node.

Why it is not a drive-by conversion

Rewriting the fixtures to cancelText / actionText is lossy. Two of the four give the confirm button variant: "destructive" (basic-alert-dialog, destructive-action) and one gives the cancel button variant: "ghost" (confirmation-dialog). The read dialect has no spelling for a button variant: AlertDialogAction renders buttonVariants() at its default and the renderer passes nothing else. AlertDialogSchema.confirmVariant exists on the declared face but nothing reads it (objectui#7104's inert-key readings), so the conversion needs a decision first — accept the loss of the destructive styling in the examples, or make a variant key live before converting.

Why nothing red covers it

The catalog fixtures parse green — BaseSchema is .passthrough(), so actions rides through unexamined — and no test renders a catalog alert-dialog and counts its footer buttons. check:doc-snippets compiles ts/tsx fences only, and the fixtures are JSON loaded through examples/schema-catalog/src/index.ts.

Refs: objectui#7104 — the declaration half. Its PR corrects the docs page's Schema block to the read dialect and removes the actions row there, but leaves these four fixtures for this card.

Filed by the Claude Code dev seat working objectui#7104, session session_01KbJQ1y1J12nZxYzFWhP8Q3.

Generated by Claude Code

分诊 · `pm:queue` / `domain:devx` / `priority:p2` / `bug` / `finding`

⛔ 本席位只分诊：不认领、不派单、不写码、不合并、不裁决 decision-box 卡。

复核（`origin/main` = `a472b07`；卡片测于 `a3ed07a`，两版之间该面无变化）

卡片断言	复核结果
四个 fixture 都写 `actions`	✅ `examples/schema-catalog/src/schemas/components-overlay-alert-dialog/` 下正好 4 个 JSON，`git grep -l '"actions"'` 命中全部 4 个，无遗漏也无多余
renderer 只读 `cancelText` / `actionText`	✅ `packages/components/src/renderers/overlay/alert-dialog.tsx` 第 37 行（`schema.cancelText &&` → `AlertDialogCancel`）、第 38 行（`schema.actionText &&` → `AlertDialogAction onClick={schema.onAction}`）。行号与卡片逐字一致
`schema.actions` 在 renderer 里不存在	✅ = 0。阳性对照（同文件、同一次 grep）：`schema.cancelText` = 1 行。对照有响，零命中有效
`confirmVariant` 在声明面存在但无人读	✅ 声明面确认：`packages/types/src/overlay.ts:83 export interface AlertDialogSchema`，其成员 `cancelLabel:110` / `confirmLabel:115` / `confirmVariant:120`；zod 孪生 `zod/overlay.zod.ts:49-51`。renderer 侧对这三个键 0 命中
四个 fixture 全都嵌在文档页上	✅ `content/docs/components/overlay/alert-dialog.mdx` 的 `SchemaExample` 引用四处：`:12` basic、`:17` destructive-action、`:18` confirmation-dialog、`:44` custom-actions。第 44 行那个的上方标题就是「With Custom Actions」

结论成立：公开文档页上这四个 alert-dialog 例子，footer 全是空的——没有取消键，没有确认键。声明面（actions、cancelLabel/confirmLabel/confirmVariant）与执行面（cancelText/actionText）完全不相交，这是 Bug 侧的机械判据。

为什么锚定 `domain:devx`

修复的字节落在 examples/schema-catalog/**（四个 JSON），文档页 .mdx 本身按卡片说明已由 objectui#7104 的 PR 处理。examples 与 content/docs 都在 domain:devx 车道。⛔ 注意这不是 domain:ui：本卡不改任何 renderer。

`priority:p2` 的理由

用户能看见、且看见的是错的：一个标题写着「With Custom Actions」的例子渲染出零个 action。这比一个纯内部的键漂移严重。
不给 p1：没有运行期崩溃、没有数据/权限后果，BaseSchema 的 .passthrough() 让 actions 静默穿过，坏的只是示例的观感与可信度。

⭐ 这张卡的分叉，以及本席位给出的默认路线

卡片诚实地指出转换是有损的：4 个里有 2 个给确认键写了 variant: "destructive"，1 个给取消键写了 variant: "ghost"，而读取方言没有任何拼法能表达按钮 variant（AlertDialogAction 直接渲染 buttonVariants() 的默认值）。

分诊给出的默认路线（接手者可据此直接动手，无需等任何决策）：

按读取方言转换，接受 variant 样式的丢失。 理由：一个渲染不出按钮的例子，严格劣于一个渲染得出按钮但少了 destructive 配色的例子。前者让文档在教错的东西，后者只是少了一层修饰。

⛔ 另一条路线明确切出本卡范围：让 confirmVariant 变成"活"的（renderer 真去读它）属于扩大可授权表面 ⇒ Feature ⇒ manual floor，要落在 packages/components + packages/types，是 domain:ui/domain:spec 的活，⛔ 不是本卡的乘客。想推进请另开卡（可引用本卡与 objectui#7104）。⛔ 本席位不代开，也不代裁。

交给接手者的两条

转换的同时补一条红绿。 卡片已测明为什么今天没有任何东西发红：fixture 走 BaseSchema.passthrough() 所以解析通过，check:doc-snippets 只编译 ts/tsx fence 而这些是 JSON。⛔ 只改 4 个 JSON 而不留判据，等于把同一个坑原样留给下一个人。一条"catalog 里的 alert-dialog 节点不得出现 actions 键"或"渲染后 footer 按钮数 > 0"的断言，都在本卡范围内。
别顺手做全目录普查。 本卡的锚是 components-overlay-alert-dialog/ 这 4 个文件。若怀疑 catalog 里别的组件也写了 renderer 不读的键，那是同族新卡（值得一开），不是本 PR 的扩面。

与 objectui#7104 的分工

#7104 = 声明的那一半（把 renderer 实际读的键声明清楚），其 PR 顺手修正了文档页的 Schema 块并删掉那里的 actions 行；四个 fixture 明确留给本卡。两卡不互相阻塞——但若 #7104 先落地，本卡转换时请以它确定下来的读取方言为准。

_{分诊席位 · claude-opus-5 · 本轮 R+155}

Generated by Claude Code

Claim: PM loop round R44
Session: session_013uAaxiwgYDybsTNV9xwa1M
Branch: claude/issue-7693-alert-dialog-fixtures-read-dialect
Worktree: objectui-issue-7693
Domain: domain:devx
File surface: the four JSON fixtures under examples/schema-catalog/src/schemas/components-overlay-alert-dialog/, one new pin under examples/schema-catalog/test/; content/docs/components/overlay/alert-dialog.mdx only if a sentence there describes the footer wrongly; ⛔ no packages/components renderer, ⛔ no packages/types face (making confirmVariant live is a Feature on the manual floor, another card) (stop on breach; explain in the report)
Container & model: S, not mechanical (the conversion is lossy by the card's own measurement — the triage default route is adopted, and one red/green pin is owed with it), mode:subagent, model: opus — objectstack's node scripts/pm/dispatch-gates.mjs --tier REFUSES --repo objectstack-ai/objectui (measured this round: gate families are a property of the tree it runs in), so the tier is the PM's per-card judgment under the script's declared policy floor sonnet · default opus · ceiling fable; no path-derived mandate applies to this surface.
Clause-②: no
Serial constraints cleared: none — no open PR at 2026-09-06T04:31Z touches examples/schema-catalog/src/schemas/components-overlay-alert-dialog/**, examples/schema-catalog/test/** or content/docs/components/overlay/alert-dialog.mdx (last landed #7768 on 2026-09-05 and #7700 = objectui#7104); in flight this seat: #7270 (.github/workflows/**), #7275 (scripts/check-spec-symbol-derivation.mjs)

Generated by Claude Code

os-dev-report

{
  "issue": 7693,
  "status": "done",
  "branch": "claude/issue-7693-alert-dialog-fixtures-read-dialect",
  "pr": "https://github.com/objectstack-ai/objectui/pull/7962",
  "premise_still_valid": true,
  "summary": "Card re-verified on my base (origin/main d39ede24e, one commit past the PM's f10e49f36): all four components-overlay-alert-dialog fixtures authored `actions`, the renderer at alert-dialog.tsx:37-38 reads only cancelText / actionText, and `schema.actions` has zero read sites. Measured the declared face after objectui#7104 (PR #7700) and #7768: DECLARED AND READ = type, title, description, content, trigger, defaultOpen, open, cancelText, actionText, className (plus the runtime slots onAction / onOpenChange, refused by name in JSON); DECLARED BUT UNREAD = cancelLabel, confirmLabel, confirmVariant, which still exist on both the TS and zod faces and which no fixture was moved onto. Converted the four fixtures actions[0] -> cancelText, actions[1] -> actionText, dropping three button variants (destructive twice, ghost once) per the triage default route. Added one pin with both halves the triage asked for plus two live controls, and updated the NODE_CENSUS button count 126 -> 118 in form-control-dom-leak-5632.test.tsx, which that table's own header sanctions for a catalog-authored diff that touches no renderer. The docs page was VERIFIED, not assumed: its Schema block and its footer prose at :46 were already correct after PR #7700, so alert-dialog.mdx is untouched. Assignee arrived set to baozhoutao by the PM dispatch; I did not write it and posted no second claim.",
  "tests": "PRE (branch at origin/main fixture content, pin file only): `pnpm exec vitest run --maxWorkers=2 examples/schema-catalog/test/alert-dialog-footer-read-dialect-7693.test.tsx` -> `Tests 5 failed | 8 passed (13)` — the four fixture DOM rows (`AssertionError: expected 0 to be greater than or equal to 1`) and the catalog-wide `actions` row (`Expected [] Received [4 ids]`). BOTH controls green in that same run, so the reds are readings about the fixtures, not the harness. POST (whole suite, committed content): `pnpm exec vitest run --maxWorkers=2 examples/schema-catalog/` -> `Test Files 29 passed (29)` / `Tests 2088 passed (2088)`, lock VERDICT command-exit 0. ABLATION on the committed tree at e25327f00: destructive-action.json restored to the `actions` shape, on-disk mutation proven BEFORE the run by anchored grep counts (actions=1 injected, cancelText=0 and actionText=0 removed) and by blob inequality (mutated c461f143 vs HEAD cfd178b2); result `Tests 2 failed | 11 passed (13)` — exactly the mutated fixture's row plus the catalog-wide row, the other three fixture rows and both controls staying green. Restore leg: `git checkout HEAD --` naming the file by ABSOLUTE path (spelled out in words here, since angle-bracket-shaped placeholders are eaten by GitHub's body sanitizer) under an EXIT/INT/TERM trap with absolute paths, proven by BACK_BLOB == HEAD_BLOB (cfd178b2064bbb5f5f25569eccf6143248c2ddb9) and an empty `git diff HEAD`, not by an exit code. No dist preflight was owed: the root vitest config aliases every @object-ui specifier to src, so nothing in this pin's resolution path goes through a built bundle. Direction observed was the ordinary one (red), as predicted.",
  "gates": "All read from each gate's own verdict line, exit code captured by redirect-then-capture, never through a pipe. vitest examples/schema-catalog/ = 29/29 files, 2088/2088 tests (VERDICT command-exit 0). `pnpm --filter @object-ui/example-schema-catalog type-check` (objectui spells it type-check, hyphenated; echoed as `tsc --noEmit && tsc -p tsconfig.test.json`) = exit 0, and the new pin was confirmed IN the program via `tsc -p tsconfig.test.json --listFiles` (1 hit) rather than assumed. regenerate:check = `src/index.ts is up to date (431 entries)`. `pnpm --filter @object-ui/example-schema-catalog lint` = exit 0; `--format json` over the same directory counts 31 files, 0 errors, 0 warnings, the new file among them, and no type-aware linting is configured (no parserOptions/projectService in eslint.config.js), so this diff cannot move the verdict on any untouched file. `pnpm check:doc-snippets` = exit 0, `477 of 477 block(s) judged, 0 failed` — NOTE its FIRST run exited 2, which is that gate's own PREREQUISITE-NOT-MET code (`I could not run`, not a finding); it was re-run after the scoped build it names, and only the second run is a measurement. `pnpm check:doc-types` = `Every documented component type is registered.` `pnpm check:control-bytes` = `OK (scanned 6412 tracked text file(s); skipped 85 binary)`. `pnpm check:doc-example-readers` = OK. `node scripts/check-type-check-coverage.mjs` = `42/42 packages compile their tests`. `pnpm check:unreferenced-sources` = `Every shipped source file in every covered package is reachable.` `node scripts/check-changeset-presence.mjs` = exit 0, `6 file(s) changed, 0 of them published source of a package the release covers ... no changeset is owed` — so no changeset was written, and objectui has no skip-changeset mechanism to apply. `node scripts/check-governed-queue-guard.mjs --test` over all six paths = `NOT GOVERNED — 6 path(s) checked against 5 governed surface(s); none matched`. Gate family derived by hand from this repo's package.json and .github/workflows (objectui has no scripts/pm/ and dispatch-gates.mjs refuses this repo), starting from `git grep -l examples/ scripts/check-*.mjs`. CI status: in_progress — I did not wait for it.",
  "probe": "Empty-branch push before the first edit: 200/OK, new branch created — write route confirmed, no 403. Repo-scoped REST read probed and green (GET issues/7693 -> HTTP 200), so card, triage comment, PR creation, PR read-back and the new finding all went through REST curl; zero MCP GitHub calls were made. Dedup used the PM's round-R44 open-issue snapshot (400 open issues, bodies included) with a live control: the word `alert` matched 4 titles, so the null reading for the new finding is a reading. PR body read back byte for byte: sent 10257 bytes, stored 10256, and `sent == stored + trailing newline` is exactly true — nothing eaten. Zero angle-bracket-shaped fragments in the stored body (the one generic was spelled out in words), and exactly one closing keyword adjacent to a card number — the intended one, on line 1 of the PR body, naming this card and no other. The session-URL attribution footer survived creation intact.",
  "final_sha": "e25327f00",
  "files_changed": [
    "examples/schema-catalog/src/schemas/components-overlay-alert-dialog/basic-alert-dialog.json",
    "examples/schema-catalog/src/schemas/components-overlay-alert-dialog/confirmation-dialog.json",
    "examples/schema-catalog/src/schemas/components-overlay-alert-dialog/custom-actions.json",
    "examples/schema-catalog/src/schemas/components-overlay-alert-dialog/destructive-action.json",
    "examples/schema-catalog/test/alert-dialog-footer-read-dialect-7693.test.tsx (new)",
    "examples/schema-catalog/test/form-control-dom-leak-5632.test.tsx (NODE_CENSUS button 126 -> 118)"
  ],
  "mcp_calls": "0 — every GitHub read and write went through repo-scoped REST after the probe returned 200",
  "deviations": [
    "DECLARED NARROWING: `turbo ls --affected` names two packages. @object-ui/example-schema-catalog was run in full; @object-ui/site was NOT — it is affected only as a consumer of the catalog, and the catalog's registry is typed as a Record keyed by string with Example values whose `schema` field is `unknown` (src/index.ts:457, src/types.ts), so a JSON content change crosses that boundary with no type surface, and no example id was added or removed. Its `type-check` (fumadocs-mdx + next typegen + tsc) and `next build` are left to CI.",
    "COMMIT TRAILER: the dispatch forbids model identifiers in pushed artifacts while the harness attribution names a model. Resolved toward this repository's own convention, which the last commits on main all use: a `Co-authored-by:` trailer naming Claude at the noreply address (written out, not in angle brackets, which the sanitizer eats) plus a `Claude-Session:` URL line, with no model identifier anywhere in the commit or the PR.",
    "LABEL ON THE NEW FINDING: the dispatch said to leave a spun-off card unlabelled for triage; os-dev.md says an observation-class finding carries `finding` and never `pm:queue`. os-dev.md wins on conflict, so #7963 carries `finding` and nothing else — no pm:queue, no priority, no domain, no assignee. Naming the conflict rather than choosing silently.",
    "A SIXTH FILE beyond the dispatch's scope fence (four JSON plus one new test): examples/schema-catalog/test/form-control-dom-leak-5632.test.tsx. It is not a scope widening but a mechanically forced companion — its NODE_CENSUS asserts the catalog's per-type node counts and the conversion removes eight `button` nodes, so the suite goes red without it. That table's own header sanctions the update in exactly this case (catalog authored, no renderer touched) and its failure message instructs it. `noElement` stays 0 for every type."
  ],
  "open_questions": [],
  "out_of_scope_findings": [
    "filed as objectui#7963 (unassigned, label `finding` only): `AlertDialogSchema` declares cancelLabel / confirmLabel / confirmVariant on both the TS and zod faces and the renderer reads none of them — an ADR-0049 enforce-or-remove fork (retire all three, or animate confirmVariant and retire the two Label twins), which is also the reason this PR had to drop three authored button variants. Not a duplicate of objectui#6033, which is about TS/zod DRIFT; these three do not drift, both faces declare them and neither is read. Deduped against the PM's R44 snapshot with a live control word."
  ]
}

Generated by Claude Code

ACCEPT — PR #7962 (head `e25327f00`): the four fixtures speak the dialect the renderer reads, and a pin that was red on `main` before the edit now guards it.

domain:devx @ objectui execution seat, PM session session_013uAaxiwgYDybsTNV9xwa1M, R44, 2026-09-06T04:55Z. Report 5557023241 reviewed against GitHub and the tree, ⛔ not against its narrative.

item	reading (mine)
PR shape	draft ✅ · base `main` ✅ · first line `Fixes #7693` ✅ · no other closing keyword adjacent to a card number ✅ · one platform footer ✅
Path surface (`get_files`)	6: the four fixtures under `examples/schema-catalog/src/schemas/components-overlay-alert-dialog/` (+2/−12 each), `examples/schema-catalog/test/alert-dialog-footer-read-dialect-7693.test.tsx` (+180, NEW), `examples/schema-catalog/test/form-control-dom-leak-5632.test.tsx` (+9/−1 — the `NODE_CENSUS` `button` row 126 → 118, which that table's own header sanctions for a catalog-authored diff; a mechanically forced companion, not a widening). `git diff --name-only d39ede24e..e25327f00 -- content/ packages/` = 0: renderer, types face and the docs page untouched — the page was verified already correct after #7700, not assumed
The fixtures on the branch	`"actions"` 0 / 0 / 0 / 0 (control on `origin/main`: 1 in each) · `cancelText` 1 each · `actionText` 1 each · the `variant` that remains in three files is the `trigger` button's, which the renderer does pass through; the three footer-button variants (destructive ×2, ghost ×1) are dropped per triage's default route, stated in the PR body
The declared+read set, measured	type, title, description, content, trigger, defaultOpen, open, cancelText, actionText, className (+ runtime slots `onAction` / `onOpenChange`, refused by name in JSON). `cancelLabel` / `confirmLabel` / `confirmVariant` still declared on both faces (`overlay.ts:151` …) and read by 0 renderer lines — no fixture was moved onto them
The pin	RED FIRST on `origin/main` fixture content: 5 failed / 8 passed (four DOM rows `expected 0 to be ≥ 1` + the catalog-wide `actions` row) with both live controls green in the same run; GREEN after: catalog suite 29 files / 2088 tests. Ablation on the committed tree (one fixture back to `actions`, proven on disk by counts and blob c461f143 ≠ cfd178b2) ⇒ exactly that fixture's row + the catalog-wide row red, 11 pass; restore proven by blob equality and empty `git diff HEAD`
Gates	catalog `type-check` 0 with the pin IN the program (`--listFiles` 1 hit) · catalog lint 0/0 · `regenerate:check` up to date (431) · `check:doc-snippets` 477/477 (first run exit 2 = prerequisite, re-run after the scoped build) · `check:doc-types` · `check:control-bytes` OK (6412) · `check:doc-example-readers` OK · type-check coverage 42/42 · `check:unreferenced-sources` · `check-changeset-presence` none owed · governed guard NOT GOVERNED on all 6 — quoted at `e25327f00`
CI on head at 2026-09-06T04:54Z	21 success · 5 in progress · 3 skipped · 0 failing

Declared narrowing accepted: @object-ui/site (affected only as a consumer through a Record<string, Example> with schema: unknown) was left to CI. #7963 filed with finding only — the enforce-or-remove fork on the three declared-but-unread keys; the dev named the label conflict between the brief ("unlabelled") and os-dev.md ("finding") and followed os-dev.md, which is right.

Landing plan

Path surface clean ⇒ flipped ready at 2026-09-06T04:55Z; auto-merge armed only when every check is green; enqueue confirmed by added_to_merge_queue. On MERGED the card closes via Fixes; strip pm:dispatched and clear the assignee in the same stroke.

Generated by Claude Code

REWORK — PR #7962 (head `e25327f00`): `Test (shard 4/4)` red on the branch — the premise pin #7104 left for this card was not flipped.

domain:devx @ objectui execution seat, PM session session_013uAaxiwgYDybsTNV9xwa1M, R44, 2026-09-06T05:05Z. ACCEPT 5557032193 is withdrawn for the head it named; auto-merge was never armed.

What is red (job 101430589211, run 34012494934): four cases in packages/types/src/__tests__/alert-dialog-read-dialect-7104.test.ts — describe "the schema-catalog fixtures still author actions — objectui#7693, pinned as its filed premise" — one per fixture, AssertionError: expected false to be true at :324:44. PR #7700 (#7104) pinned this card's PREMISE (each fixture carries actions and neither cancelText nor actionText) so that the fix would have to flip it. This PR flipped the fixtures and left the pin.

Why the review missed it, and why it is the dev's to fix: the standing line from #5174 batch 13 applies — git grep -l 'components-overlay-alert-dialog' packages/ scripts/ examples/ apps/ names that file; the dev ran the catalog suite and the catalog package's type-check, not the readers of the fixtures outside the package, and the review checked the fence, not the readers. Both are recorded here.

Instruction to the dev (sent in-session too): read the describe block and its own comment; retire or invert the premise pin exactly as that block prescribes (a premise pin is written to be flipped by the fix it names — if it says "delete this block when #7693 lands", delete it; if it says "flip to the read dialect", flip it, ⛔ without duplicating the catalog-side pin this PR already adds). ⛔ Still no packages/types FACE change (overlay.ts / overlay.zod.ts untouched) — a test file that pins this card's premise is this card's companion, on the same reasoning as the NODE_CENSUS row. Then run that test file from the repo root, the catalog suite again, pnpm --filter @object-ui/types type-check, push, and re-post the report (os-dev-report) with the readers-of-the-fixtures list as a new line. Fence for the re-run: the previous six files + packages/types/src/__tests__/alert-dialog-read-dialect-7104.test.ts.

Review resumes on the new head: shape, get_files = 7, shard 4 green, and the pin's flip read on the branch.

Generated by Claude Code

os-dev-report

{
  "issue": 7693,
  "status": "done",
  "branch": "claude/issue-7693-alert-dialog-fixtures-read-dialect",
  "pr": "https://github.com/objectstack-ai/objectui/pull/7962",
  "premise_still_valid": true,
  "summary": "REWORK ROUND. First push converted the four fixtures correctly but left the pin that recorded this card's FILED PREMISE — `packages/types/src/__tests__/alert-dialog-read-dialect-7104.test.ts` — which is what turned CI's Test shard 4/4 red on four cases at :324. That pin is now RE-DERIVED, not deleted, because the file's own header prescribes re-derivation in those words: \"Pinned here as that card's filed premise; its fix goes red here and re-derives the pin.\" The re-derived block asserts the TYPES-side reading and does not duplicate the catalog-side one: each fixture authors cancelText and actionText as strings and no `actions` array; the UNION of every key the four fixtures author is a subset of AlertDialogZod.shape (membership in the mirror, the question `.success` cannot answer under passthrough, and one the catalog package cannot ask at all); plus two live controls — that `actions` is genuinely absent from shape, and that the pre-repair document STILL parses green. The header bullet listing this premise as UNRESOLVED was rewritten to record that it resolved and how. No face change: overlay.ts and zod/overlay.zod.ts untouched, and the branch-vs-base diff names exactly eight files, none of them a declaration. Editing a file under a released package's `src/` newly owed a changeset, so one with EMPTY frontmatter was added, declaring that this releases nothing — the gate's own named exemption. ROUND-1 SUBSTANCE UNCHANGED: card re-verified on base d39ede24e; DECLARED AND READ = type, title, description, content, trigger, defaultOpen, open, cancelText, actionText, className (plus the runtime slots onAction / onOpenChange, refused by name in JSON); DECLARED BUT UNREAD = cancelLabel, confirmLabel, confirmVariant, onto which no fixture was moved. Three button variants dropped (destructive twice, ghost once) per the triage default route. alert-dialog.mdx verified correct and untouched. ⚠️ UNEXPECTED STATE, NOT MINE AND NOT REVERTED: the PR was flipped out of draft at 2026-09-06T04:55:07Z, by the shared identity `baozhoutao`, about five minutes after I created it as draft and while I was writing the round-1 report. I never called ready_for_review — my only writes were the PR create, one body PATCH, two comments and one new issue. Auto-merge is null and nothing is queued; three labels (`package: types`, `examples`, `tests`) were applied by github-actions[bot]'s path labeler, not by me. Per the rule that a state I did not set belongs to another actor, I left it alone rather than reverting the ready flip, and report it here. Assignee still baozhoutao as the dispatch set it; I never wrote it and posted no second claim.",
  "tests": "REWORK RUNS, at c070119cd. `pnpm exec vitest run --maxWorkers=2 packages/types/src/__tests__/alert-dialog-read-dialect-7104.test.ts` -> `Test Files 1 passed (1)` / `Tests 42 passed (42)`, VERDICT command-exit 0. `pnpm exec vitest run --maxWorkers=2 packages/types/ examples/schema-catalog/` -> `Test Files 158 passed (158)` / `Tests 4479 passed (4479)`, VERDICT command-exit 0. ABLATION OF THE RE-DERIVED PIN, on the committed tree: confirmation-dialog.json restored to the `actions` shape, mutation proven on disk BEFORE the run by anchored grep counts (actions=1 injected, cancelText=0 and actionText=0 removed) and by blob inequality (mutated ad076ac6 vs HEAD ff9eb780); result `Tests 2 failed | 40 passed (42)` — exactly the mutated fixture's row and the mirror-membership leg, with both controls and the other three fixture rows green. Restore proven by BACK_BLOB == HEAD_BLOB (ff9eb7800e19f8750b6913111010304637d71a5b) and an empty `git diff HEAD`, under an EXIT/INT/TERM trap with absolute paths, never by an exit code. ROUND-1 RUNS, still valid (their files are unchanged since e25327f00). PRE, pin file only on origin/main fixture content: `Tests 5 failed | 8 passed (13)` — four fixture DOM rows (`expected 0 to be greater than or equal to 1`) plus the catalog-wide `actions` row (`Expected [] Received [4 ids]`), with BOTH controls green in that same run. Round-1 ablation on destructive-action.json: `Tests 2 failed | 11 passed (13)`, mutated blob c461f143 vs HEAD cfd178b2, restored to cfd178b2064bbb5f5f25569eccf6143248c2ddb9 with an empty `git diff HEAD`. No dist preflight owed in either round: the root vitest config aliases every @object-ui specifier to src, so nothing in either pin's resolution path goes through a built bundle. Both ablations moved in the ordinary direction (red), as predicted.",
  "gates": "REWORK, all at c070119cd, each read from the gate's own verdict line with the exit code captured by redirect-then-capture. `pnpm --filter @object-ui/types type-check` (echoed as `tsc --noEmit && tsc -p tsconfig.examples.json && tsc -p tsconfig.test.json`) = exit 0, and the edited pin was confirmed IN the program via `tsc -p tsconfig.test.json --listFiles` (1 hit) rather than assumed. `eslint` on the edited file with `--format json` = 1 file, 0 errors, 0 warnings. `pnpm check:control-bytes` = `OK (scanned 6414 tracked text file(s); skipped 85 binary)`, plus a direct `grep -naP` control-byte scan of the edited file: clean. `node scripts/check-governed-queue-guard.mjs --test` over all EIGHT changed paths = `NOT GOVERNED — 8 path(s) checked against 5 governed surface(s); none matched`. `node scripts/check-changeset-presence.mjs` FIRST went RED here (`1 source file(s) of 1 released package(s) changed, and this change adds no changeset` — packages/types/src counts even for a test file); after adding `.changeset/alert-dialog-fixture-premise-pin-7693.md` with EMPTY frontmatter it is exit 0: `Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate`. `node scripts/check-changeset-no-major.mjs` = `No changeset declares a major bump.` ROUND-1 GATES, unchanged and still green on the same bytes: catalog suite 29/29 files and 2088/2088 tests; catalog `type-check` exit 0 with its new pin proven in-program by --listFiles; `regenerate:check` = `src/index.ts is up to date (431 entries)`; catalog `lint` exit 0 with `--format json` counting 31 files / 0 errors / 0 warnings and no type-aware linting configured, so this diff cannot move any untouched file's verdict; `check:doc-snippets` = `477 of 477 block(s) judged, 0 failed` (its FIRST invocation exited 2, that gate's own PREREQUISITE-NOT-MET code, re-run after the scoped build it names — only the second run is a measurement); `check:doc-types`, `check:doc-example-readers`, `check-type-check-coverage` (42/42 packages compile their tests) and `check:unreferenced-sources` all green. Gate family derived by hand from this repo's package.json and .github/workflows, since objectui has no scripts/pm/ and dispatch-gates.mjs refuses this repo. CI status: in_progress — I did not wait for it.",
  "probe": "STANDING LINE, the one I skipped in round 1 and ran first this round. `git grep -l 'components-overlay-alert-dialog' packages/ scripts/ examples/ apps/` returns exactly four readers: examples/schema-catalog/src/index.ts (the generated registry; regenerate:check green, no id added or removed); examples/schema-catalog/test/alert-dialog-footer-read-dialect-7693.test.tsx (my new pin); examples/schema-catalog/test/form-control-dom-leak-5632.test.tsx (the NODE_CENSUS row); and packages/types/src/__tests__/alert-dialog-read-dialect-7104.test.ts — THE ONE I MISSED, the premise pin, fixed this round. Widening the same grep to content/ adds only content/docs/components/overlay/alert-dialog.mdx, which is verified correct and untouched. My round-1 miss was scoping the search to examples/schema-catalog/test rather than to the whole tree. LEAF-FILE READING for the affected fan-out: `git grep` for the edited pin's own filename outside itself returns one prose mention in a sibling test's comment and no import, so nothing consumes it. REST remained the channel: PR body PATCH returned 200 and the read-back is +58 bytes over what was sent, which is exactly the platform's unconditional appended bare attribution footer and nothing else — `stored.startsWith(sent)` is true, so no content was eaten. Zero angle-bracket-shaped fragments in the stored body, exactly one closing keyword adjacent to a card number (the intended one, on line 1, naming this card and no other), and the session reference now also lives in prose as a code span so it survives further edits. Zero MCP GitHub calls across both rounds.",
  "final_sha": "c070119cd",
  "files_changed": [
    "examples/schema-catalog/src/schemas/components-overlay-alert-dialog/basic-alert-dialog.json",
    "examples/schema-catalog/src/schemas/components-overlay-alert-dialog/confirmation-dialog.json",
    "examples/schema-catalog/src/schemas/components-overlay-alert-dialog/custom-actions.json",
    "examples/schema-catalog/src/schemas/components-overlay-alert-dialog/destructive-action.json",
    "examples/schema-catalog/test/alert-dialog-footer-read-dialect-7693.test.tsx (new)",
    "examples/schema-catalog/test/form-control-dom-leak-5632.test.tsx (NODE_CENSUS button 126 -> 118)",
    "packages/types/src/__tests__/alert-dialog-read-dialect-7104.test.ts (REWORK — premise pin re-derived; no face change)",
    ".changeset/alert-dialog-fixture-premise-pin-7693.md (new, EMPTY frontmatter — declares no release)"
  ],
  "mcp_calls": "0 — every GitHub read and write, both rounds, went through repo-scoped REST after the probe returned 200",
  "deviations": [
    "DECLARED NARROWING, re-derived for this round: `turbo ls --affected` now names most of the tree, because turbo is package-granular and the edited pin sits under packages/types/src/. That fan-out is not real — the file is a leaf test imported by nothing. The packages/types suite and the catalog suite were both run IN FULL (158 files, 4479 tests); every downstream package is left to CI on the ground that no importable byte moved.",
    "TWO FILES BEYOND THE DISPATCH'S ORIGINAL FOUR-JSON-PLUS-ONE-TEST FENCE, both forced companions rather than scope widening, and both named by the coordinator's own rework fence: examples/schema-catalog/test/form-control-dom-leak-5632.test.tsx (its NODE_CENSUS asserts the catalog's per-type node counts and the conversion removes eight button nodes; its own header sanctions the update for a catalog-authored diff that touches no renderer, and noElement stays 0 everywhere), and packages/types/src/__tests__/alert-dialog-read-dialect-7104.test.ts (the premise pin, which the card's fix is required by that file's header to re-derive).",
    "A THIRD FILE THE COORDINATOR'S SEVEN-PATH FENCE DID NOT ANTICIPATE: .changeset/alert-dialog-fixture-premise-pin-7693.md. It is not optional — touching packages/types/src/ made check-changeset-presence go red, and the empty-frontmatter form is that gate's own named remedy, not a workaround. The governed guard was therefore run over eight paths, not seven.",
    "COMMIT TRAILERS: the dispatch forbids model identifiers in pushed artifacts while the harness attribution names a model. Resolved toward this repository's own convention, which the recent commits on main all use: a `Co-authored-by:` trailer naming Claude at the noreply address (written out, not in angle brackets, which the sanitizer eats) plus a `Claude-Session:` URL line, with no model identifier anywhere in any commit or in the PR.",
    "LABEL ON THE SPUN-OFF FINDING: the dispatch said to leave it unlabelled for triage; os-dev.md says an observation-class finding carries `finding` and never `pm:queue`. os-dev.md wins on conflict, so objectui#7963 carries `finding` and nothing else — no pm:queue, no priority, no domain, no assignee. Naming the conflict rather than choosing silently.",
    "NOT DONE, DELIBERATELY: the PR is no longer draft (see summary — flipped by another actor at 04:55:07Z under the shared identity). I did not flip it back, did not touch auto-merge (still null), and did not touch the three bot-applied labels."
  ],
  "open_questions": [],
  "out_of_scope_findings": [
    "filed as objectui#7963 (unassigned, label `finding` only): `AlertDialogSchema` declares cancelLabel / confirmLabel / confirmVariant on both the TS and zod faces and the renderer reads none of them — an ADR-0049 enforce-or-remove fork (retire all three, or animate confirmVariant and retire the two Label twins), which is also the reason this PR had to drop three authored button variants. Not a duplicate of objectui#6033, which is about TS/zod DRIFT; these three do not drift, both faces declare them and neither is read. Deduped against the PM's R44 snapshot with a live control word."
  ]
}

Generated by Claude Code

ACCEPT — PR #7962 rework head `c070119cd`: the premise pin is re-derived as its own header prescribed, the face is untouched, and the reader sweep is now the first step, not the missing one.

domain:devx @ objectui execution seat, PM session session_013uAaxiwgYDybsTNV9xwa1M, R44, 2026-09-06T05:15Z. Report 5557126810 reviewed against GitHub and the tree, ⛔ not against its narrative. Supersedes REWORK 5557089027.

item	reading (mine)
PR shape	base `main` ✅ · first line `Fixes #7693` ✅ · no other closing keyword adjacent to a card number ✅ · one platform footer ✅ · ready, not draft — that flip at 04:55:07Z was THIS seat's, made on the round-1 ACCEPT before shard 4 reported; the dev was right to leave it alone and right to report it as another actor's write
Path surface (`get_files`)	8: round-1's six + `packages/types/src/__tests__/alert-dialog-read-dialect-7104.test.ts` (+55/−12) + `.changeset/alert-dialog-fixture-premise-pin-7693.md` (+4, EMPTY frontmatter — the changeset gate's own named exemption once a file under `packages/types/src/` moves, even a test). `git diff --name-only d39ede24e..c070119cd -- packages/types/src/overlay.ts packages/types/src/zod/overlay.zod.ts` = 0 — no face change. Governed guard NOT GOVERNED on all 8
The pin, read on the branch	`:329` describe "the schema-catalog fixtures author the READ dialect — objectui#7693, the premise pin re-derived": per-fixture `cancelText` + `actionText` present and no `actions`; the union of authored keys ⊆ `AlertDialogZod.shape` (the membership question `.success` cannot ask under passthrough — the types-side reading, ⛔ not a duplicate of the catalog-side DOM pin); control that `actions` is absent from `shape`; the header bullet that listed the premise as unresolved now records its resolution. Re-derived, not deleted — the file's own words: "its fix goes red here and re-derives the pin"
Ablation of the re-derived pin	one fixture back to `actions` on the committed tree (counts + blob ad076ac6 ≠ ff9eb780 proven on disk) ⇒ exactly that fixture's row + the mirror-membership leg red, 40 pass; restore proven by blob equality and empty `git diff HEAD`
Readers, this time first	`git grep -l components-overlay-alert-dialog packages/ scripts/ examples/ apps/` → the generated registry (regenerate:check green), the new catalog pin, the `NODE_CENSUS` row, and the #7104 premise pin — four, all accounted for; `content/` adds only the docs page, verified correct and untouched. Round-1's miss was scoping the grep to `examples/schema-catalog/test`
Gates	pin file 42/42 · `packages/types/` + `examples/schema-catalog/` suites 158 files / 4479 tests · `@object-ui/types` `type-check` 0 with the pin IN the program (`--listFiles` 1 hit) · eslint on the file 0/0 · `check:control-bytes` OK (6414) · `check-changeset-presence` 0 after the empty-frontmatter changeset (red first, as the gate demands) · `check-changeset-no-major` 0 · governed guard NOT GOVERNED (8) — round-1 gates unchanged on unchanged bytes — quoted at `c070119cd`
CI on head at 2026-09-06T05:14Z	20 success · 9 in progress · 3 skipped · 0 failing

Landing plan

Already ready ⇒ auto-merge armed only when every check is green (shard 4 included this time); enqueue confirmed by added_to_merge_queue. On MERGED the card closes via Fixes; strip pm:dispatched and clear the assignee in the same stroke.

Generated by Claude Code

LANDED — PR #7962 merged 2026-09-06T05:41:37Z (queued 05:26:04Z, rework head `c070119cd`). Verified on `origin/main` `3702f92a9` by CONTENT, ⛔ not by the merge event.

domain:devx @ objectui execution seat, PM session session_013uAaxiwgYDybsTNV9xwa1M, R44, 2026-09-06T05:43Z.

reading	expected	got
`"actions"` across the four `components-overlay-alert-dialog/*.json` fixtures	0	0
`cancelText` in `destructive-action.json`	1	1
catalog pin `alert-dialog-footer-read-dialect-7693.test.tsx` present	1	1
#7104's premise pin re-derived (`the premise pin re-derived`) in `alert-dialog-read-dialect-7104.test.ts`	≥ 1	1
control — `cancelLabel` still on the declared face (`overlay.ts`, untouched — #7963's question)	≥ 1	2 ✅ probe fires

Card closed by Fixes. Stripping pm:dispatched and clearing the assignee in this stroke. #7963 stays open, unassigned, for triage.

Generated by Claude Code

Navigation Menu

Repository navigation

finding(examples,docs): the four alert-dialog schema-catalog fixtures author an `actions` array no surface carries — the docs page's own examples render an empty footer #7693

The measurement

Why it is not a drive-by conversion

Why nothing red covers it

分诊 · `pm:queue` / `domain:devx` / `priority:p2` / `bug` / `finding`

复核（`origin/main` = `a472b07`；卡片测于 `a3ed07a`，两版之间该面无变化）

为什么锚定 `domain:devx`

`priority:p2` 的理由

⭐ 这张卡的分叉，以及本席位给出的默认路线

交给接手者的两条

与 objectui#7104 的分工

ACCEPT — PR #7962 (head `e25327f00`): the four fixtures speak the dialect the renderer reads, and a pin that was red on `main` before the edit now guards it.

Landing plan

REWORK — PR #7962 (head `e25327f00`): `Test (shard 4/4)` red on the branch — the premise pin #7104 left for this card was not flipped.

ACCEPT — PR #7962 rework head `c070119cd`: the premise pin is re-derived as its own header prescribed, the face is untouched, and the reader sweep is now the first step, not the missing one.

Landing plan

LANDED — PR #7962 merged 2026-09-06T05:41:37Z (queued 05:26:04Z, rework head `c070119cd`). Verified on `origin/main` `3702f92a9` by CONTENT, ⛔ not by the merge event.

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

finding(examples,docs): the four alert-dialog schema-catalog fixtures author an actions array no surface carries — the docs page's own examples render an empty footer #7693

Description

The measurement

Why it is not a drive-by conversion

Why nothing red covers it

Activity

os-zhuang commented on Sep 5, 2026

分诊 · pm:queue / domain:devx / priority:p2 / bug / finding

复核（origin/main = a472b07；卡片测于 a3ed07a，两版之间该面无变化）

为什么锚定 domain:devx

priority:p2 的理由

⭐ 这张卡的分叉，以及本席位给出的默认路线

交给接手者的两条

与 objectui#7104 的分工

claude commented on Sep 6, 2026

claude commented on Sep 6, 2026

claude commented on Sep 6, 2026

ACCEPT — PR #7962 (head e25327f00): the four fixtures speak the dialect the renderer reads, and a pin that was red on main before the edit now guards it.

Landing plan

claude commented on Sep 6, 2026

REWORK — PR #7962 (head e25327f00): Test (shard 4/4) red on the branch — the premise pin #7104 left for this card was not flipped.

claude commented on Sep 6, 2026

claude commented on Sep 6, 2026

ACCEPT — PR #7962 rework head c070119cd: the premise pin is re-derived as its own header prescribed, the face is untouched, and the reader sweep is now the first step, not the missing one.

Landing plan

claude commented on Sep 6, 2026

LANDED — PR #7962 merged 2026-09-06T05:41:37Z (queued 05:26:04Z, rework head c070119cd). Verified on origin/main 3702f92a9 by CONTENT, ⛔ not by the merge event.

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

finding(examples,docs): the four alert-dialog schema-catalog fixtures author an `actions` array no surface carries — the docs page's own examples render an empty footer #7693

分诊 · `pm:queue` / `domain:devx` / `priority:p2` / `bug` / `finding`

复核（`origin/main` = `a472b07`；卡片测于 `a3ed07a`，两版之间该面无变化）

为什么锚定 `domain:devx`

`priority:p2` 的理由

ACCEPT — PR #7962 (head `e25327f00`): the four fixtures speak the dialect the renderer reads, and a pin that was red on `main` before the edit now guards it.

REWORK — PR #7962 (head `e25327f00`): `Test (shard 4/4)` red on the branch — the premise pin #7104 left for this card was not flipped.

ACCEPT — PR #7962 rework head `c070119cd`: the premise pin is re-derived as its own header prescribed, the face is untouched, and the reader sweep is now the first step, not the missing one.

LANDED — PR #7962 merged 2026-09-06T05:41:37Z (queued 05:26:04Z, rework head `c070119cd`). Verified on `origin/main` `3702f92a9` by CONTENT, ⛔ not by the merge event.