finding(plugin-grid): ObjectGrid draws a hand-rolled em-dash at three cell sites instead of the shared EmptyValue, so those empty cells carry no aria-label #8491

Activity

1. os-justin

   added

   bugSomething isn't workingSomething isn't working

   plugin

   pm:dispatched

   finding

   priority:p3

   domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatobjectui ui stream: fix lands on the published library or apps — objectui execution seat

   on Sep 8, 2026
2. os-justin

   self-assigned this

   on Sep 8, 2026
3. os-justin commented on Sep 8, 2026

   

   os-justin

   on Sep 8, 2026 – with Claude

   CollaboratorAuthor

   More actions

   Claim: session session_01YBWFb5YgMU5dw8p2VKj16S · branch claude/issue-8491-handrolled-empty-placeholders

   PM dispatch (domain:ui seat). The assignee and this comment are set by the PM on the dev's behalf — the dev inherits both, posts no second claim, and never writes the assignee field.

   Dispatched because your own report says the class can be RETIRED COMPLETELY, not merely reduced: a repo-wide grep found ObjectGrid (three sites) and RelatedList (objectui#8475) to be the only carriers. A class with exactly two carriers and a shared replacement already in hand is worth closing rather than tracking.

   ⇒ fold objectui#8475 into this branch and close both. Say so in the PR body and reference both cards.

   Decision frame

   Settled: these sites should use the shared EmptyValue from @object-ui/components rather than a hand-rolled span. The accessibility gap decides it — the hand-rolled ones carry no aria-label, so an empty cell has no accessible name while its renderer-supplied neighbours do.

   Yours to measure: whether EmptyValue is reachable from both call sites without a new dependency edge, and what the visual delta actually is (your report says the hand-rolled ones render one size smaller and italic — say whether adopting the shared one is a deliberate visual change or a no-op). Measured cost is the whole basis.

   ⚠️ Verify the grep's completeness before trusting "only two carriers". That claim is what justifies retiring the class, so it needs a census by mechanism — the em-dash character, the muted-foreground class pattern, and any No value string — each with a lit control, not one pattern. objectui#8394 found a fifth spelling its own census missed because the operands were reversed; objectui#8481 found three renderers where the card named one.

   ⚠️ Ask which of your cases an implementation that renders EmptyValue everywhere, including for filled cells, would still pass. A "the cell has an accessible name" assertion passes on that caricature. Pin a filled cell as the non-regression half.

   ---

   Generated by Claude Code
4. os-justin commented on Sep 8, 2026

   

   os-justin

   on Sep 8, 2026 – with Claude

   CollaboratorAuthor

   More actions

   os-dev-report

   {
     "issue": 8491,
     "status": "done",
     "branch": "claude/issue-8491-handrolled-empty-placeholders",
     "pr": "https://github.com/objectstack-ai/objectui/pull/8503",
     "premise_still_valid": false,
     "summary": "IMPLEMENTED: the three named ObjectGrid cell sites, a FOURTH ObjectGrid site the card's census missed, and RelatedList (objectui#8475, folded in as dispatched) now render the shared EmptyValue. Both cards close from PR #8503. REACHABILITY, MEASURED: no new dependency edge on either side — plugin-grid already declares @object-ui/components as a dependency and ObjectGrid.tsx already imported EmptyValue (its no-renderer default branch has always used it, line ~2541); plugin-detail already declares it as peerDependency plus devDependency and RelatedList.tsx already imported from the same module. No manifest changed. VISUAL DELTA: DELIBERATE at four sites, ZERO at one. The three cell sites and RelatedList drop `text-xs italic` and take the shared typography — that is the point, because ObjectGrid's own default branch already drew the shared placeholder, so one table showed a 12px italic placeholder in one column and the shared upright one in the next. The fourth site (the record-detail drawer) keeps its rendered text and `text-sm italic` through `glyph` and `className`, so its delta is purely additive (data-slot, aria-label, select-none, no-underline, pointer-events-none). PREMISE FALSE: `premise_still_valid: false` refers to the dispatch's stated JUSTIFICATION, not its instruction — see the census below. The instruction (fold both, close both) was right and is done.",
     "census_by_mechanism": {
       "base_sha_named_literally_on_every_base_side_read": "61e649ab1e7697bf54e2d651c383d31f282678f4",
       "scope": "packages/, apps/, examples/ — tests, __tests__, .md, .snap excluded",
       "instrument_1_the_cards_own_exact_class_string": "text-muted-foreground/50 text-xs italic -> 2 files, 4 sites. REPRODUCES THE CARD EXACTLY, and that is the warning sign: it grepped for the string the card had already found.",
       "instrument_2_any_muted_foreground_50_order_independent": "3 files, 5 sites. FOUND A FOURTH SITE IN ObjectGrid.tsx ITSELF (the record-detail drawer, spelled text-sm not text-xs, holding t('grid.empty') not an em-dash). Same class, same missing aria-label, same missing data-slot. FIXED HERE.",
       "instrument_3_class_agnostic_span_or_createElement_whose_only_child_is_a_bare_em_dash": "11 files, 13 sites. PREMISE REFUTED. Beyond the two cards: ResourceListPage.tsx defaultCell, RecordDetailDrawer.tsx, AuditPanel.tsx, ImportWizard.tsx, PublicFormsPage.tsx, AiPendingActionsInbox.tsx (none with an accessible name), plus DetailSection.tsx and HeaderHighlight.tsx (hand-rolled but these two DO carry aria-label). objectui#8475's OWN BODY names DetailSection, so objectui#8491's 'only two carriers' table contradicted the sibling card it cited.",
       "instrument_4_bare_em_dash_as_a_ternary_or_nullish_fallback_no_span_at_all": "33 files, 41 sites (locale packs excluded). PREMISE REFUTED DECISIVELY — including FOUR MORE SITES INSIDE ObjectGrid.tsx, in the mobile card layout, as bare strings with no span and therefore not even a muted class.",
       "instrument_5_the_literal_string_No_value": "fired; surfaced DetailSection.tsx and HeaderHighlight.tsx as the two hand-rolled placeholders that DO carry an accessible name, i.e. the milder half of the class.",
       "controls": "Every instrument that could have returned zero carries a lit control that fired. Instrument B (a span whose only child is a bare HYPHEN) returned 1 hit; its control — the same regex with the em-dash — fired on 11 files. The correct-usage control (EmptyValue call sites in src) fired on 37 files, 24 of them in @object-ui/fields alone, with plugin-grid at 1 and plugin-detail at 0 — which is itself the shape of the defect. The control-byte scan's control was a real U+0001 written to a scratch file (it fired); a TAB was checked and correctly did NOT fire, so it would have been a dead instrument.",
       "verdict": "ONLY TWO CARRIERS DID NOT SURVIVE. This PR takes the class from 13 carriers to 8. It REDUCES the class; it does not retire it."
     },
     "which_cases_discriminate": {
       "method": "The caricature was RUN, not reasoned about — EmptyValue returned unconditionally at all five sites, filled cells included (ablation B).",
       "measured_result": "8 of the 12 grid cases red, 4 GREEN. 3 of 3 RelatedList cases red.",
       "green_under_the_caricature_labelled_as_scope_declarations_in_the_files": [
         "THE DEFECT — an empty LINK+ACTION cell",
         "THE DEFECT — the auto-linked PRIMARY cell",
         "AGREEMENT — the linked branch and the no-renderer default branch draw the IDENTICAL placeholder",
         "MOBILE CARD VIEW — the card layout OMITS an empty field"
       ],
       "refuse_it_by_their_own_headline_assertion": [
         "NON-REGRESSION — a FILLED linked cell",
         "NON-REGRESSION — a FILLED link+action cell",
         "NON-REGRESSION — a FILLED primary cell",
         "NON-REGRESSION — a FILLED card field",
         "THE DRAWER — a FILLED field",
         "RelatedList NON-REGRESSION — a FILLED cell"
       ],
       "refuse_it_only_through_a_value_bearing_CONTROL": "THE DEFECT — an empty LINK cell, both empty-drawer cases, RelatedList THE DEFECT and THE AGREEMENT. Without those controls they would have joined the green four. Stated rather than implied, because the brief's prediction and my own were BOTH wrong in this direction — I had predicted every THE DEFECT case would stay green.",
       "the_pin_answers_the_brief_directly": "An EmptyValue-everywhere implementation still passes the two most quotable assertions in the file. The filled-cell half is the whole instrument, exactly as objectui#8474 and objectui#8481 each measured."
     },
     "tests": "COMMANDS, all from the REPO ROOT with paths relative to it and nothing after a bare double-dash. (1) closure build first: pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-grid^...' --filter '@object-ui/plugin-detail^...' build -> exit 0. (2) pnpm exec vitest run packages/plugin-grid/ packages/plugin-detail/ -> 'Test Files 254 passed (254) / Tests 2297 passed (2297)', exit 0. (3) type-check (objectui spells it with a hyphen): pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-grid' --filter '@object-ui/plugin-detail' run type-check -> exit 0, both 'Done'. Each package's script is `tsc --noEmit && tsc -p tsconfig.test.json`, so the pins ARE type-checked — PROVEN rather than assumed by counting them in --listFiles: 1 and 1. (4) lint, the package-scoped eslint reading: same filter, run lint -> exit 0; plugin-detail 911 problems / 0 errors, plugin-grid 778 problems / 0 errors. --no-inline-config was never used. (5) gates: check:control-bytes exit 0 ('scanned 6722 tracked text file(s)'), plus a direct grep of the five changed paths -> 0 hits with a lit control that fired; check:i18n-keys, check:i18n-drift ('0 en value(s) changed'), check:i18n-dead-keys (report-only; grid.empty NOT reported dead, i.e. its call site survived), check:self-import, check:vi-mock-specifiers, check:unreferenced-sources, check:handler-key-reads -> all exit 0. check:governed-queue-guard --test over the changed paths -> 'NOT GOVERNED, 7 path(s) checked against 5 governed surface(s)'. node scripts/check-changeset-presence.mjs -> exit 0, verdict quoted in the PR. ABLATIONS — five legs, each from the COMMITTED implementation, each under trap on EXIT INT TERM with ABSOLUTE paths, each mutation proved on disk by git hash-object differing from git rev-parse HEAD:PATH AND by removed/injected grep counts in BOTH directions with the matched line printed, each restore verified BY STATE (git diff HEAD empty AND hashes equal), never by an exit code. HEAD blobs, re-verified at the FINAL head 6b840cb69 after the second commit: ObjectGrid.tsx 31e93c11b393529fcd45e8d3d76aadab6afcb585, RelatedList.tsx e08d9c6da660feb8ede751b416b058a9f0630cfb. A (the three hand-rolled cell spans restored verbatim) grid blob 0b1fc75ad61c2cf940cc586a46cfc467ebaab3e0 -> 4/12 red BY NAME: the three 'THE DEFECT' cell cases plus 'AGREEMENT'. B (EmptyValue everywhere) grid blob 9c6f315e89f9a5e135530c4de7232f560791ea98 and list blob 43f69440b7bcf3dc6d40d28bc685a744eb3d5b88 -> 8/12 grid and 3/3 list red BY NAME. C (the drawer's hand-rolled span restored verbatim) grid blob d0c8569e3bf33eb5e6066f7180f3f1bc43626ef8 -> 2/12 red BY NAME: both 'THE DRAWER' placeholder cases; 'THE DRAWER — a FILLED field' correctly stays green. D (RelatedList's hand-rolled span restored verbatim) list blob 9bd5c5c192c8e04564c25935efa3e500de603c40 -> 2/3 red BY NAME: 'THE DEFECT' and 'THE AGREEMENT'. E (the drawer adopts the BARE shared component, stranding grid.empty) grid blob 9b734190d7f024a00e4e62fd32bf09baf716a8e5 -> exactly 1/12 red BY NAME: 'THE DRAWER — the rendered TEXT is unchanged', which is what makes that case a real instrument for the glyph decision rather than decoration. ONE FALSE START, RECORDED: the driver's first `prove` call passed the same pattern as both the removed and the injected operand, so it failed in one direction and refused to run — the trap restored the tree and `git diff HEAD` was empty. The leg was re-run with correct operands rather than loosened. NOT MEASURED (not red, and not counted as a passing measurement): no repo-wide `pnpm test` and no full `pnpm lint` — left to CI.",
     "mcp_calls": "4 — one targeted search_issues (RATE-LIMITED, see below), create_pull_request, one pull_request_read to read the PR body back in full, and this comment. Everything else went through zero-quota channels: the public-repo single-card embedded JSON payload for issue 8491, 8475, 8481 and 8474 (raw body plus all comments), and git for every base-side read. A repo-scoped REST probe was run first and returned 403 'GitHub access is not enabled for this session', so the REST bucket was unavailable for the whole run — declared channel switch.",
     "open_questions": [
       {
         "question": "The class has 8 remaining carriers after this PR and objectui#8491's retire-the-class premise is refuted. Should the rest be closed, and at what granularity?",
         "options": [
           "A — one card per remaining carrier (8 cards). Cost: 8 dispatches for what is one mechanical swap each; the census work is duplicated 8 times.",
           "B — ONE card for the six no-accessible-name carriers (ResourceListPage defaultCell, RecordDetailDrawer, AuditPanel, ImportWizard, PublicFormsPage, AiPendingActionsInbox), and a SEPARATE one for the two that already carry an aria-label (DetailSection, HeaderHighlight), because those two are a different decision: they would lose a deliberate `title` and change opacity, so they are not a mechanical swap.",
           "C — a lint rule instead of a card: forbid a bare em-dash as a rendered placeholder outside packages/components, and let it name its own violations. Cost: it has to distinguish an empty-VALUE placeholder from the 41 ternary fallbacks that are legitimately something else (a Select option label, a duration dash, a markdown table cell)."
         ],
         "recommendation": "B, then C as a follow-up once B has drained the population. The measured constraint that rules out C-first: instrument 4's 41 sites across 33 files are NOT one class — they include `option value='' label='—'` in a Select, a `${ms} ms` duration fallback, and codegen writing markdown table cells. A rule written before the triage would either fire on all of them or need an exemption list longer than the fix. B is also what keeps the aria-label question honest: DetailSection's `title` was put there deliberately (it sits next to objectui#8376's copy-affordance reasoning) and deserves its own decision rather than being swept into a mechanical pass."
       }
     ],
     "out_of_scope_findings": [
       "NOT FILED — MCP search_issues returned 'API rate limit already exceeded for user ID 323634890' and REST is 403 from this container, so per the dispatch contract I neither filed unsearched nor dropped it. FOR THE PM TO FILE (1/3): six more carriers of this exact class with NO accessible name — app-shell views/metadata-admin/ResourceListPage.tsx defaultCell, plugin-dashboard/src/RecordDetailDrawer.tsx, app-shell views/metadata-admin/AuditPanel.tsx, plugin-grid/src/ImportWizard.tsx, apps/console pages/developer/PublicFormsPage.tsx, plugin-chatbot/src/AiPendingActionsInbox.tsx; plus two milder ones that DO carry aria-label, plugin-detail/src/DetailSection.tsx and plugin-detail/src/HeaderHighlight.tsx.",
       "NOT FILED (2/3): four bare em-dash fallbacks inside ObjectGrid.tsx's OWN mobile card layout — no span, no muted class, no accessible name. Same file as this card, different shape (a bare string nested inside an already-styled span) and a surface the card never mentions, so deliberately left out of this PR rather than swept in.",
       "NOT FILED (3/3): the wider population instrument 4 measured — 41 em-dash ternary/nullish fallbacks across 33 files. Needs a triage pass, not a bulk fix: several are legitimately not empty-value placeholders.",
       "NOT FILED (documentation defect, and it cost a red test before I caught it): objectui#8475's body attributes the reachable EmptyValue branch to DateCellRenderer, quoting `if (date === null || isNaN(date.getTime()))`. That line is DateTimeCellRenderer's. DateCellRenderer's only EmptyValue branch is `if (!value)`, which RelatedList's isValueEmpty already intercepts, so an unparseable `date` never reaches the shared component. The card's conclusion is real; only its attribution was wrong. Since #8475 closes with this PR, this is worth a line in the PR record rather than a card — already written into the pin's docblock and the PR body."
     ],
     "contradicts_the_brief": [
       "MOST VALUABLE — the brief's REASON is refuted while its CONCLUSION stands. The dispatch says the class has 'exactly two carriers' and is therefore 'worth closing, not tracking'. A census by mechanism finds 13 carriers across 11 files by the class-agnostic em-dash instrument, and 41 across 33 by the bare-fallback instrument — including FOUR MORE inside ObjectGrid.tsx itself that the card never counted. The card's own grep returned exactly what it predicted because it searched for the string it had already found. The INSTRUCTION (fold objectui#8475 in, close both here) is still right and is done; only 'the class can be retired' was false. That is why premise_still_valid is false while status is done.",
         "SECOND — the brief required pinning the mobile card layout as 'a second independent read path' for any site both paths reach. MEASURED BY RENDERING: it is not one for these three cell sites. The card layout does call the same col.cell renderers, but its secondary-field loop drops empty values BEFORE the call ('hide empty values on mobile'), so an empty field is omitted from the card entirely — label and all — and no placeholder of either spelling has ever reached it. It IS a genuine second read path for the POPULATED half, and both viewports are pinned explicitly. The empty-side case was rewritten from an assertion into a labelled scope declaration rather than deleted.",
         "THIRD — the card counts THREE sites in ObjectGrid.tsx. There are FOUR. The record-detail drawer carries the identical defect in a text-sm spelling, missed because the census grepped one exact class string. Fixed here as part of this card, not filed separately: it is the card's own defect in the card's own file.",
         "FOURTH, a small one in my favour — the brief warns that a type-check may exclude test files. Both packages' type-check scripts run `tsc -p tsconfig.test.json` as a second pass, and --listFiles confirms each new pin is in it (1 and 1). So the pins are type-checked, and I did not have to declare that surface NOT MEASURED."
     ]
   }

   ---

   Generated by Claude Code
5. os-justin commented on Sep 8, 2026

   

   os-justin

   on Sep 8, 2026 – with Claude

   CollaboratorAuthor

   More actions

   Contract review — accepted. PR #8503 is out of draft and armed.

   I re-measured the three load-bearing claims from origin/main independently, with a lit control on every instrument that could have returned zero. All three hold.

   1. The fourth site the card missed — confirmed

   On origin/main the carrier shape is exactly five sites in two files:

   site	spelling
   RelatedList.tsx:1007	text-xs italic
   ObjectGrid.tsx:2479 / :2497 / :2697	text-xs italic — the card's three
   ObjectGrid.tsx:4362	text-sm italic + t('grid.empty')

   The fourth is invisible to the card's own instrument: grepping the text-xs string the card supplies cannot reach a text-sm spelling. On the branch all five are gone, and every remaining muted-foreground/50 hit is a grip handle, a separator dot or a search icon — noise you excluded correctly.

   One correction. Your instrument-2 line reads "3 files, 5 sites". The carriers are 5 sites in 2 files; the diffstat agrees (two source files changed). If the third file in that count is components/src/custom/empty.tsx — the authority itself, correctly not a carrier — say so, or a reader will hunt for a sixth carrier that does not exist.

   2. "Reduces the class, does not retire it" — confirmed on a second instrument

   You report 13 → 8. My regex is narrower (em-dash as the span's entire single-line content) and gives 9 → 6 across 7 → 6 files. The gap is regex breadth, not a disagreement: yours also catches {'—'} and multi-line forms.

   Both instruments agree on the thing that matters, which is the part that refutes my dispatch: the class shrinks and survives. "Exactly two carriers, so the class is worth closing" was my justification and it was false. premise_still_valid: false with status: done is the right pair — the instruction was sound, the reason I gave for it was not.

   3. The DateCellRenderer / DateTimeCellRenderer documentation defect — confirmed

   Both renderers own an EmptyValue branch, which is exactly why a line citation can slip between them:

   • DateCellRenderer — packages/fields/src/index.tsx:832
   • DateTimeCellRenderer — :874 and :877

   The line objectui#8475 cites is DateTimeCellRenderer's. Recording that it cost a red test before you caught it is the useful half of that report.

   The measurement that matters most here

   You ran the caricature instead of reasoning about it, and it took down two of your own showpiece cases:

   THE DEFECT — an empty LINK+ACTION cell and THE DEFECT — the auto-linked PRIMARY cell stay green against an implementation that renders EmptyValue unconditionally — because "the cell has an accessible name" is also true of a grid that has stopped rendering values at all.

   The load-bearing refusals are the five plain NON-REGRESSION — a FILLED … cases, plus three that redden only through their value-bearing controls rather than their headline assertion. Labelling the four survivors as SCOPE DECLARATIONs in the docblock, and committing the rewrite separately as "state the MEASURED discrimination, not the predicted one", is the right disposal.

   That is the fourth independent measurement of this in as many days (objectui#8474, objectui#8481, objectui#8450, here). It is no longer a lesson; it is a property of pins:

   The vivid assertion is rarely the discriminating one. Run the caricature; do not predict it.

   Carrying objectui#8495's scoped-lookup lesson (emptyIn / valueIn never read the whole container) into this file without being told is the other thing worth naming.

   Ruling on your open question — B, then triage. C is not yet fileable.

   B is right, and the seam you picked is the right one. The six with no accessible name are one class: same defect, same repair, one to three lines each. Six cards would put roughly twelve lines through the merge queue as six PRs. DetailSection / HeaderHighlight split off correctly — they already carry aria-label, and the swap drops a deliberate title and shifts opacity, so it is a behaviour change needing its own judgement, not a mechanical substitution. Split on "does the swap change behaviour", which is what you did.

   C is not a card yet, and I am not filing it as one — on your own measurement. Instrument 4's 41 sites across 33 files are not one class: a Select option label, a duration fallback and codegen writing markdown cells are in there. A lint rule's scope is therefore the open question, not its implementation, and a rule written before triage needs an exemption list longer than the fix. So the order is B → a triage card for the 41 → only then a decision about C, not B → C. I will file B and the triage card; C stays out of the backlog until the triage says what it would forbid.

   Your three unfiled findings

   Correct call under the contract — searched-then-filed or handed back, never filed blind and never dropped. The API limit that blocked your search_issues blocked me for the last hour too. They are mine now; I will search and file them.

   ---

   Generated by Claude Code
6. os-justin

   closed this as completedin #8503on Sep 8, 2026