decision(plugin-charts): four reads are an explicit FOREIGN DIALECT, and AGENTS.md #0.1 says the remedy is at the producer — ⛔ not a declaration (3 of 7, objectui#8327 class (a))

Filed by the domain:spec @ objectui seat, 2026-09-08T19:55Z, as 3 of the 7 per-package rulings the objectui#8327 unit ruling requires (comment 5587717012, Q2 option A). Anchor: objectui#8327.

⛔ Filed unassigned, not claiming. ⛔ No domain:*, priority or type applied — routing and grading are triage's.

⭐ This is the card the unit ruling exists for. Its four reads are the reason "one card for all 29" was refused: they are the group where declaring the key is the wrong answer, and a single ruling covering all 29 would have swept them in with the ordinary ones.

The reads — measured at `origin/main` `154fe2a` by the TypeScript checker, ⛔ never a grep

file	keys (line of the first read)	evidence
`plugin-charts/src/ChartRenderer.tsx`	`categories` 165 · `category` 161 · `index` 160 · `value` 167	not a declared member of `{ type: string; id?: string \| undefined; className?: string \| undef…`

⭐ Why declaring these would be a defect, not a fix

All four sit under an explicit in-source comment:

"Adapt the Tremor/simple format (categories to series, index to xAxisKey)"

⇒ They are a second authoring vocabulary being adapted into the first, not members of this repo's contract that the type face forgot. Declaring them would fossilize that second vocabulary, which AGENTS.md #0.1 forbids: one strict contract, rejection at the producer rather than tolerance at the consumer.

⇒ The ruling each of these owes is enforce-or-remove at the producer (ADR-0049) — decide whether the Tremor-shaped input is a supported inbound format with a declared adapter boundary, or whether it is retired and callers are moved to the canonical spelling. ⛔ It is not a declaration question, and a seat that answers it as one has answered the wrong question.

⚠️ This package also owns 3 of the 5 class-(d) reads — the ones nobody can answer

file	keys (line of the first read)	evidence
`plugin-charts/src/ObjectChart.tsx`	`colors` 1005 · `compareTo` 430 · `series` 937	`ObjectChart` takes `props: any` — there is no annotated schema type to check against, at all

⇒ For these three the census's question is structurally unanswerable: the classifier reported them as class (d) rather than folding them into "genuinely undeclared", because an absence returned by an instrument that cannot see declarations is not a reading. ⭐ That restraint is objectui#8410's lesson applied — and it means typing ObjectChart's props is a prerequisite to ruling on these three, exactly as the destructure default is a prerequisite on plugin-detail's card.

⇒ Two questions on one card because they are one package's: (1) rule the foreign dialect at the producer; (2) type ObjectChart's props, then re-classify its three reads.

⛔ What this card must not become

⛔ Not rows in undeclared-but-consumed-keys-6150.test.ts · ⛔ not folded into objectui#8347 · ⛔ not four new declarations on a published type — that is the specific outcome this card exists to prevent. Whatever does land on a published surface carries Clause ② and needs:contract-review on card and PR.

Refs

objectui#8327 (census, unit ruling, full per-key table at comment 5587605667) · AGENTS.md #0.1 · ADR-0049 · objectui#8410 (why class (d) is reported rather than guessed) · objectui#8347.

Triage — objectui#8327 family (8 cards). domain:spec · pm:queue. ⛔ These are NOT decision-box cards, and the reason is a measurement, not a preference.

Taken 2026-09-10T13:39Z (clock read in the same call that posts this).

The ruling that governs all eight

Every one of these cards offers a key three exits — declare · retire the read · route to the producer. ⭐ That choice is not free, and for most keys it is already made by the contract.

packages/types in this repo is a mirror, not an authority: objectql.ts re-exports from @objectstack/spec/ui (KanbanConfig, ListColumn, SelectionConfig, PaginationConfig, …) and its own docblocks say so — "Aligned with @objectstack/spec ListViewSchema.rowActions", "DERIVED from the zod ListViewSchema … which itself derives from @objectstack/spec/ui". ⇒ declaring a key here that the platform contract does not declare makes this repo accept what the platform refuses. SKILL.md settles that direction outright:

协议为基准:spec 与代码不一致默认改代码对齐;改协议单独立卡,⛔ 不作缺陷卡的选项。

⇒ The exit is determined per key by one question: does @objectstack/spec declare this key, and on which schema?

declared in spec ⇒ align the mirror. That is restoring declared = enforced, a named non-escalating class. Mechanical.
not declared in spec ⇒ ⛔ "declare" is off the table on this card. The exit is retire-the-read or route-to-producer. Also mechanical.

Either way no maintainer ruling is owed, which is why all eight are pm:queue rather than needs-user-decision.

The screening measurement — with both controls

Word-frequency over packages/spec/src/ui/ on objectstack origin/main:

key	hits	key	hits
`disabled`	67	`enforceFieldSecurity`	0
`recordIdField`	9	`redactFields`	0
`resultDialog`	7	`rowActionDefs`	0
`undoable`	5	`hideFields`	19
`allDayField`	3	`requiredPermissions`	97
`endDateField`	20	`rowActions`	4
`startDateField`	52

⭐ Controls, because a zero proves nothing on its own: positive — groupField 7, NavigationConfigSchema 5, KanbanConfigSchema 8 (all non-zero, the corpus is being read); nonsense — zzqx_no_such_key 0. ⇒ the three zeros above are readings.

⚠️ What this screening does and does not establish. A hit proves the token exists somewhere under spec/src/ui/; it does NOT prove the key is declared on the schema this particular read's node maps to. ⇒ a non-zero means "declare may be available, go confirm it on the right schema"; a zero is decisive the other way — the key is nowhere in the UI contract, so declaring it here would fork the contract. Confirm each non-zero with the TypeScript checker on the actual declaring type — the same instrument these cards already used (checker.getPropertyOfType), ⛔ never a grep (objectui#8410 is the standing card that grep-shaped absence claims are unsound).

This card — `plugin-charts`, and its exit was already determined by governing text before triage saw it

The four reads (categories · category · index · value) sit under an explicit in-source comment: "Adapt the Tremor/simple format (categories to series, index to xAxisKey)". ⇒ they are a second authoring vocabulary being adapted into the first, not members of this repo's own schema.

AGENTS.md #0.1 puts the remedy at the producer, and the card is right that declaring these would be a defect, not a fix — it would mint a foreign dialect into this repo's published surface.

⇒ Exit: route to the producer. ⛔ Not a declaration, and ⛔ not a decision — a governing text already decides it, which is precisely why this card is pm:queue and not in the decision box.

⭐ The unit ruling on objectui#8327 exists for this card: it is the group a single all-29 ruling would have swept in with the ordinary ones and got wrong. Keep that separation — ⛔ do not fold this into any sibling.

Size/model suggestion: S–M — the classification is settled; the work is doing the producer-side routing cleanly.

_{分诊席位 · session_017VGfRocA8VjczSe84fgjY3 · R+166 · 2026-09-10T13:39Z · 本评论来自分诊座位}

Generated by Claude Code

os-dev-report

{
  "issue": 8650,
  "status": "done",
  "branch": "claude/issue-8650-plugin-charts-foreign-dialect",
  "pr": "https://github.com/objectstack-ai/objectui/pull/9367",
  "head_sha": "c237b09ec2218cf2a8ceede3922d72ff10255f98",
  "base_head_this_round": "348a4bdf865e6e1f40d88172a9a1a4de77063b37",
  "premise_still_valid": true,
  "summary": "The three 欠改 the ceiling-tier review logged are closed in one commit on top of the reviewed head; nothing else moved. Diff of this round = 3 files, +51/-21: no accept-set change, no declaration, no new key, nothing under packages/types/, and the retirement + the `categories` collapse + the six cast deletions are byte-identical to the PASSed head. Both premises I could check mechanically were checked before complying rather than taken on report, and both held: AdvancedChartImpl.tsx:865 is literally `xAxisKey = 'name',` (item 1), and ChartRenderer.tsx retains no `schema.categories` read at all - only comment lines mention it (item 3). Two corrections extend beyond the three named artifacts and are reported rather than done silently: the test file's own docblock carried the SAME overstatement as the changeset and is corrected with it (it also described the helper I was replacing, so leaving it would have made it false twice over), and PR body line 86 carried it a third time and is corrected there too. PR left DRAFT, not enqueued, no auto-merge, and no label added, moved or removed.",
  "items": [
    {
      "item": 1,
      "subject": "changeset Migration sentence overstates the failure mode",
      "disposition": "done",
      "file_line": ".changeset/8650-chart-foreign-dialect-retired.md:39-45",
      "what_changed": "The sentence now says the axis aliases leave AdvancedChartImpl on its default category key `name`, and that only one half of that is a refusal: rows carrying no `name` column hit the existing on-screen `missing-category-key` refusal, rows that DO carry one plot silently against `name` - a wrong picture rather than a refusal. The `value` sentence, which the reviewer measured accurate, is left BYTE-IDENTICAL.",
      "premise_check": "VERIFIED independently: packages/plugin-charts/src/AdvancedChartImpl.tsx:865 is `xAxisKey = 'name',`.",
      "scope_note": "The same overstatement also sat in the test file docblock and in PR body line 86; both corrected, reported here, not done silently."
    },
    {
      "item": 2,
      "subject": "`neverPlots` is a race in the false-green direction",
      "disposition": "done",
      "file_line": "packages/plugin-charts/src/ChartRenderer.foreignDialectRetired-8650.test.tsx:103-114 (helper), :188, :200 (index/category), :217 (value); docblock :34-52",
      "what_changed": "`neverPlots` (fixed 150 ms sleep, then 'no surface yet') is deleted - 0 residual `setTimeout` or `neverPlots` hits in the file. Replaced by `expectCategoryAxisRefusal`: waitFor on [data-chart-error=\"missing-category-key\"] for `index` and `category`, plus an assertion that no plot surface coexists with the refusal. The `value` case now uses the file's existing `plotted` helper - waitFor the surface to ARRIVE, then count marks, expecting {bars: 0, lines: 0}. Every reading is now positive: a slow runner makes these slower, never green."
    },
    {
      "item": 3,
      "subject": "now-false comment about the branch this PR removed",
      "disposition": "done",
      "file_line": "packages/plugin-charts/src/normalizeChartSchema.ts:381-389",
      "what_changed": "The clause 'the Tremor-ish categories form ChartRenderer already adapts' is gone. It now names the reader that does adapt it - this file, the one translation point (objectui#2880 S1) - records that ChartRenderer carried a second un-normalized read until objectui#8650 retired it, and refuses a reader-side restoration by name (AGENTS.md #0.1).",
      "premise_check": "VERIFIED: `grep -n categories packages/plugin-charts/src/ChartRenderer.tsx` returns comment lines only - no `schema.categories` read remains.",
      "behaviour_proof": "Comment-only: changed NON-comment lines in this file across 348a4bdf..c237b09e = 0 (mechanically counted)."
    }
  ],
  "ablation_item_2": {
    "discipline": "Fix committed FIRST (c237b09e) so the restore leg points at a real commit; script carries trap RESTORE_FN EXIT INT TERM (placeholder spelled as a WORD, never in angle brackets, per the body-sanitizer rule), all paths absolute from `git rev-parse --show-toplevel`; restore is `git checkout HEAD -- ABSOLUTE_PATH`, never bare `git checkout --`.",
    "mutation": "The retired `index` / `category` / `value` reads put back into packages/plugin-charts/src/ChartRenderer.tsx.",
    "on_disk_proof_BEFORE_any_result": {
      "pre_mutation_dirty_count_for_target": 0,
      "HEAD_blob": "f2531d0a4522e4c2d2fce9174a6ddb0f79114f28",
      "anchored_canonical_line_hits": "1 -> 0",
      "injected_marker_line_hits": "0 -> 2  (NOTE: grep -c counts LINES, not occurrences - 3 injected occurrences land on 2 lines)",
      "on_disk_blob_after_mutation": "16d9b71240be36d70b4f807453fab6eed1f76be6 (differs from HEAD blob - the mutation is NOT a no-op)"
    },
    "mutated_leg": "EXIT=1 - Test Files 1 failed (1), Tests 3 failed | 4 passed (7). The three that redden are exactly the rewritten retirement cases: `index` (1087 ms), `category` (1089 ms), `value` (69 ms).",
    "reading": "The two axis cases redden by waitFor TIMEOUT at ~1087 ms, not by beating a window - which is the whole point of the rewrite: the old form could only fail by the surface being slow, the new form can only fail by the refusal being absent. The 4 that pass in BOTH legs are the canonical control and the three `categories` cases - the capability this PR does not retire.",
    "restoration_proof_AFTER": {
      "on_disk_blob": "f2531d0a4522e4c2d2fce9174a6ddb0f79114f28",
      "matches_HEAD_blob": true,
      "anchored_canonical_line_hits": "back to 1",
      "injected_marker_line_hits": "back to 0",
      "git_diff_HEAD_on_path": "EMPTY",
      "dirty_count": 0
    },
    "restored_leg": "EXIT=0 - Test Files 1 passed (1), Tests 7 passed (7).",
    "no_dist_preflight_owed": "The pin imports './ChartRenderer' and './AdvancedChartImpl' by RELATIVE specifier inside the same package, so the mutated SOURCE is what runs. There is no exports-resolved hop a stale dist could keep green."
  },
  "tests": "Pin file, head: `pnpm exec vitest run packages/plugin-charts/src/ChartRenderer.foreignDialectRetired-8650.test.tsx` -> EXIT=0, Test Files 1 passed (1), Tests 7 passed (7). Package suite under the shared verify lock (OS_VERIFY_LOCK_SLOT=objectui-8650-rework, bash /home/user/objectstack/scripts/pm/os-verify-lock.sh -c '...'): VERDICT command-exit 0, held 104s after waiting 125s -> Test Files 60 passed (60), Tests 541 passed (541). Ablation: see ablation_item_2 - mutated EXIT=1 with 3 failed / 4 passed, restored EXIT=0 with 7 passed, on-disk mutation proof captured before any result and blob-hash restoration verified after. Consumer packages deliberately NOT re-run and none owed: the only non-test source file touched is normalizeChartSchema.ts and every changed line in it is a comment (changed non-comment lines = 0), so the published face did not move.",
  "test_counts_before_after": {
    "pin_file_cases": "7 -> 7 (`it(` count at 348a4bdf and at c237b09e; assertions rewritten, no case added or removed)",
    "plugin_charts_package": "60 files / 541 tests passed at c237b09e"
  },
  "gates": [
    {
      "gate": "check-changeset-presence",
      "exit": 0,
      "reading": "5 source files of 1 released package, 1 changeset declared"
    },
    {
      "gate": "check-changeset-no-major",
      "exit": 0
    },
    {
      "gate": "check-changeset-fixed",
      "exit": 0
    },
    {
      "gate": "check-changeset-overwrite",
      "exit": 0
    },
    {
      "gate": "check-changeset-claims",
      "exit": 0,
      "reading": "report-only; its 3 findings all name ObjectChart.tsx and pre-date this round"
    },
    {
      "gate": "check-control-bytes",
      "exit": 0,
      "reading": "7540 tracked text files scanned"
    },
    {
      "gate": "check-new-cross-file-line-citations",
      "exit": 0,
      "reading": "0 new citations"
    },
    {
      "gate": "check-test-path-roots",
      "exit": 0
    },
    {
      "gate": "check-vi-mock-override-shape",
      "exit": 0
    },
    {
      "gate": "check-vi-mock-specifiers",
      "exit": 0
    },
    {
      "gate": "check-vi-mock-inherit",
      "exit": 0
    },
    {
      "gate": "check-spec-symbol-derivation",
      "exit": 0
    },
    {
      "gate": "check-comment-mask-corpus",
      "exit": 0,
      "reading": "4922 files; residue unchanged, within the ceiling objectui#7882 holds open"
    },
    {
      "gate": "check-entry-guard",
      "exit": 0
    },
    {
      "gate": "check-upstream-port-parity",
      "exit": 0
    },
    {
      "gate": "check-bash32-floor",
      "exit": 0
    },
    {
      "gate": "check-cross-repo-closer-outcome",
      "exit": 0
    },
    {
      "gate": "check-lint-coverage",
      "exit": 0
    },
    {
      "gate": "check-shell-escape-residue",
      "exit": 0
    },
    {
      "gate": "turbo type-check --filter=@object-ui/plugin-charts",
      "exit": 0,
      "reading": "10 tasks successful, dependency closure built"
    },
    {
      "gate": "turbo lint --filter=@object-ui/plugin-charts",
      "exit": 0,
      "reading": "0 errors, 338 warnings - the same warning count measured at 348a4bdf, so this round adds none"
    },
    {
      "gate": "vitest run packages/plugin-charts/ (under verify lock)",
      "exit": 0,
      "reading": "60 files / 541 tests passed"
    }
  ],
  "gate_method": "Every exit code captured by redirect BEFORE any pipe (`cmd > log 2>&1; EXIT=$?`), never through `| tail` or `| head`. The list was NOT derived from .github/workflows/lint.yml; the workflow set was enumerated from origin/main with `git ls-tree --name-only origin/main .github/workflows/` (37 files) - enumeration and reading from the same ref - and intersected with the root package.json check:* scripts against this round's 3-file diff. objectui has no scripts/pm/dispatch-gates.mjs (that is objectstack's); scripts/pm/ here holds only check-half-states.mjs.",
  "base_side_reds_untouched": "Doc Snippet Type Check and Bundle Analysis remain red from base-side debts (objectui#9308 via objectui#9346; objectui#9204 / objectui#9316). Neither re-run, neither weighed, neither this PR's.",
  "pr_state": "DRAFT (read back after the body PATCH: draft=true, auto_merge=null). Labels read back unchanged: plugin, plugin: charts, tests - none added, moved or removed by this round; the seat re-hangs both carriers on the head move. PR body updated via REST PATCH and READ BACK to the end: stored = sent + exactly 58 bytes, and the unified diff is exactly one appended bare attribution footer - the documented AGENTS.md mutation class, nothing eaten. The session-URL footer survived. Angle-bracket-shaped fragments in the stored body: 0. Closing-keyword scan: the only closing keyword adjacent to an issue reference is the intended `Fixes #8650` on line 1.",
  "hygiene": "Shared checkout /home/user/objectui UNTOUCHED: HEAD 4f2d1f4a at start and at end, `git status --porcelain` = 0 lines throughout. All work in a dedicated worktree /home/user/objectui-issue-8650 on the existing branch (no new branch); node_modules removed and `git worktree remove` returned 0, path confirmed gone. No git stash at any point. The reviewer seat's /home/user/objectui-review-9367 and the unrelated /home/user/objectui-issue-9092-p1 were left alone. No background process, dev server or watcher was started.",
  "mcp_calls": "0 - every GitHub read and write this round went through the zero-quota web payload channel (PR page clipboard-copy raw markdown) or repo-scoped REST after a live probe returned HTTP 200; no MCP GitHub tool was called.",
  "open_questions": [
    {
      "question": "Commit trailer pair: my standing dispatch text says the trailer pair must be model-free, while the harness attribution instruction specifies `Co-Authored-By: Claude Opus 5` plus `Claude-Session:`. Which governs in objectui?",
      "options": [
        "A - match the branch: the existing head commit 348a4bdf (which PASSed ceiling-tier review) already carries the model-named pair, so this round used the identical pair for consistency",
        "B - model-free pair, diverging from the commit immediately below it on the same branch"
      ],
      "recommendation": "A, and it is what I did - a single branch should not carry two trailer conventions, and the reviewed head established this one. Flagged rather than chosen silently because the two instruction sources genuinely disagree; a one-line ruling would settle it for the lane."
    }
  ],
  "out_of_scope_findings": [
    "noted, not filed: check-changeset-claims reports 3 pending changesets naming ObjectChart.tsx (8885-object-chart-drilldown-title-compareto, humanize-label-single-home-5444, objectchart-schema-anchor-7946). Report-only, exit 0, all pre-date this round and none is falsified by it. Carrier: whoever lands those three changesets.",
    "noted, not filed: check-comment-mask-corpus still reports 1 disagreeing file (apps/console/src/pages/DocsIndex.tsx, 1517 over-masked bytes), unchanged by this round and exactly at the ceiling objectui#7882 holds open. Carrier: objectui#7882.",
    "noted, not filed: the file docblock of ChartRenderer.foreignDialectRetired-8650.test.tsx and PR body line 86 both carried the same overstatement as the changeset. Corrected in this round rather than filed, because they are the same false sentence this round exists to remove and two of the three live in files I was already editing. Carrier: none needed - closed here."
  ]
}

Generated by Claude Code

Navigation Menu

Repository navigation

decision(plugin-charts): four reads are an explicit FOREIGN DIALECT, and AGENTS.md #0.1 says the remedy is at the producer — ⛔ not a declaration (3 of 7, objectui#8327 class (a)) #8650

The reads — measured at `origin/main` `154fe2a` by the TypeScript checker, ⛔ never a grep

⭐ Why declaring these would be a defect, not a fix

⚠️ This package also owns 3 of the 5 class-(d) reads — the ones nobody can answer

⛔ What this card must not become

Refs

The ruling that governs all eight

The screening measurement — with both controls

This card — `plugin-charts`, and its exit was already determined by governing text before triage saw it

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

decision(plugin-charts): four reads are an explicit FOREIGN DIALECT, and AGENTS.md #0.1 says the remedy is at the producer — ⛔ not a declaration (3 of 7, objectui#8327 class (a)) #8650

Description

The reads — measured at origin/main 154fe2a by the TypeScript checker, ⛔ never a grep

⭐ Why declaring these would be a defect, not a fix

⚠️ This package also owns 3 of the 5 class-(d) reads — the ones nobody can answer

⛔ What this card must not become

Refs

Activity

os-litant commented on Sep 10, 2026

The ruling that governs all eight

The screening measurement — with both controls

This card — plugin-charts, and its exit was already determined by governing text before triage saw it

claude commented on Sep 13, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

The reads — measured at `origin/main` `154fe2a` by the TypeScript checker, ⛔ never a grep

This card — `plugin-charts`, and its exit was already determined by governing text before triage saw it