Repository navigation
ERROR Bad substitution: JSON.stringify #87
Description
hi, i ran a command and received the patch but i couldn't accept/reject it due to this "bad substitution" error.
running it with default model, node 22 (with fnm as node env manager) in warp terminal. i will try in other terminal apps too.
is this due to model response or related to the package? the patch as far as i can see is correct (it's a new file creation).
Activity
HamedMP commentedon Apr 16, 2025
interestingly i don't see where this error is generated in the code, seems the error message is coming from the api
bolinfest commentedon Apr 16, 2025
@HamedMP Thanks for the report! If it's not sensitive, could you share the argument to the
apply-patchcall?I suspect this is happening here:
https://github.com/ljharb/shell-quote/blob/b19fc77e66871eee10a9978d54c27d802a1da99b/parse.js#L121-L132
So it seems likely that there is something like
${JSON.stringify}in the argument tobash -lc << 'EOF' *** Begin...andparse()from theshell-quotemodule is interpreting that as an environment variable substitution rather than a literal.Looking into a repro and a fix...
bolinfest commentedon Apr 16, 2025
@HamedMP we just pushed version
0.1.2504161551of@openai/codexwhich I believe should fix this, so give it a shot?HamedMP commentedon Apr 17, 2025
thanks for the update, i'll give it a try.
p.s. that i couldn't directly update it, uninstalled and reinstalled it to make it work
chore(repo): checkpoint local changes before merging patch-approval f…
Merge local worktree branch: fix(tui/approvals): avoid duplicate patc…
Removes computeAutoApproval() and tightens up canAutoApprove() as the…
fix(gui): cover long user messages in Storybook (openai#87)