Bug fix: Allow empty title field after tokenization - #24
Merged
Conversation
Signed-off-by: Mahita Mahesh <mahitam@amazon.com>
mahitamahesh
marked this pull request as ready for review
November 10, 2022 17:43
msfroh
approved these changes
Nov 10, 2022
| @@ -111,6 +111,10 @@ public SearchHits transform(final SearchHits hits, | |||
| List<String> tokenizedTitle = null; | |||
| if (queryParserResult.getTitleFieldName() != null) { | |||
| tokenizedTitle = textTokenizer.tokenize(docSourceMap.get(queryParserResult.getTitleFieldName()).toString()); | |||
Collaborator
There was a problem hiding this comment.
I just checked and confirmed that the return value from tokenize is never null: https://github.com/opensearch-project/search-relevance/blob/main/src/main/java/org/opensearch/search/relevance/transformer/kendraintelligentranking/preprocess/TextTokenizer.java#L39
msfroh
pushed a commit
that referenced
this pull request
Nov 23, 2022
Signed-off-by: Mahita Mahesh <mahitam@amazon.com> Signed-off-by: Mahita Mahesh <mahitam@amazon.com> Co-authored-by: Mahita Mahesh <mahitam@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If there are no tokens from tokenizing the title field, pass null to Kendra instead of empty list.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.