Add a Docker quickstart script for demo / test - #25
Merged
Conversation
mahitamahesh
approved these changes
Nov 11, 2022
rstrahan
reviewed
Nov 14, 2022
rstrahan
reviewed
Nov 14, 2022
rstrahan
reviewed
Nov 14, 2022
msfroh
force-pushed
the
quickstart-script
branch
6 times, most recently
from
November 15, 2022 05:06
038a3ef to
b82691d
Compare
rstrahan
reviewed
Nov 16, 2022
msfroh
force-pushed
the
quickstart-script
branch
from
November 17, 2022 06:55
b82691d to
135a590
Compare
|
Brilliant!! Will test it tomorrow (later today!)
Thanks!!
Sent from Workspace ONE Boxer
On Nov 17, 2022 2:02 AM, msfroh ***@***.***> wrote:
@msfroh commented on this pull request.
________________________________
In helpers/search_processing_kendra_quickstart.sh<opensearch-project/search-relevance#25 (comment)>:
+ ports:
+ - 9200:9200
+ - 9600:9600
+ networks:
+ - opensearch-net
+ opensearch-dashboard:
+ image: opensearchproject/opensearch-dashboards:${OPENSEARCH_VERSION}
+ container_name: opensearch-dashboards
+ ports:
+ - 5601:5601
+ environment:
+ OPENSEARCH_HOSTS: '["https://opensearch-node:9200"]'
+ networks:
+ - opensearch-net
+EOF
+docker-compose up
I added some (hopefully) helpful text at the end.
It got a little long, so it outputs the text to a README file and then outputs that, with the last instruction being "If you ever want to read this text again, I've written it <working_directory>/README".
I covered your 4 suggestions, pointed to the docs for indexing, and explained how to add Kendra ranking to a query. I'm open to other ideas for things that might be useful.
—
Reply to this email directly, view it on GitHub<opensearch-project/search-relevance#25 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACTSFHWOVVM2OJ3DQXCY7YDWIXJ4BANCNFSM6AAAAAAR5FGU2E>.
You are receiving this because you commented.Message ID: ***@***.***>
|
msfroh
force-pushed
the
quickstart-script
branch
3 times, most recently
from
November 17, 2022 09:50
01d2a4f to
da51964
Compare
rstrahan
reviewed
Nov 17, 2022
rstrahan
reviewed
Nov 17, 2022
msfroh
force-pushed
the
quickstart-script
branch
from
November 18, 2022 00:03
da51964 to
c0b0a08
Compare
msfroh
marked this pull request as ready for review
November 18, 2022 01:36
msfroh
marked this pull request as draft
November 18, 2022 01:37
Collaborator
Author
|
Oops -- I marked this as "ready for review", but I want to hold off until we have a released plugin zip. The default plugin zip location is still a 404. |
msfroh
force-pushed
the
quickstart-script
branch
3 times, most recently
from
November 22, 2022 01:44
22ccbb1 to
59b0a21
Compare
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
=============================================
+ Coverage 40.58% 60.43% +19.85%
- Complexity 92 155 +63
=============================================
Files 27 29 +2
Lines 722 867 +145
Branches 98 119 +21
=============================================
+ Hits 293 524 +231
+ Misses 404 304 -100
- Partials 25 39 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Adding a Bash script to simplify setting up and launching local Docker containers with OpenSearch (with this plugin installed) and OpenSearch Dashboards, with the plugin configured to connect to Kendra ranking service. Signed-off-by: Michael Froh <froh@amazon.com>
Previously, between runs of the script, any indexed data would be lost. With this change, users can (optionally) mount a persistent volume to hold the search index, so it can be reused by future containers. Signed-off-by: Michael Froh <froh@amazon.com>
Signed-off-by: Michael Froh <froh@amazon.com>
msfroh
force-pushed
the
quickstart-script
branch
from
November 23, 2022 21:25
59b0a21 to
6875000
Compare
msfroh
marked this pull request as ready for review
November 23, 2022 21:25
macohen
approved these changes
Nov 23, 2022
macohen
left a comment
Collaborator
There was a problem hiding this comment.
We should plan to deprecate this after the 2.5 release is out and replace it with instructions for plugin installation.
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit b069fc9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a Bash script to simplify setting up and launching local Docker containers with OpenSearch (with this plugin installed) and OpenSearch Dashboards, with the plugin configured to connect to Kendra ranking service.
Signed-off-by: Michael Froh froh@amazon.com
Description
Bash script does the following:
Dockerfilethat uses the OpenSearch 2.4.0 base image and installs this plugin.Dockerfileand tag it (asopensearch-with-ranking-plugin).docker-compose.ymlthat launches two nodes:docker-compose upto bring up both nodes.NOTE: I have tested this on a couple of hosts (running Linux and Mac OS) with temporary and long-lived AWS credentials. I still need to test it on an EC2 instance using instance profile credentials.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.