Skip to content

Enabling Windows Build and Jacoco Reporting - #28

Merged
msfroh merged 11 commits into
opensearch-project:mainfrom
macohen:main
Nov 21, 2022
Merged

Enabling Windows Build and Jacoco Reporting#28
msfroh merged 11 commits into
opensearch-project:mainfrom
macohen:main

Conversation

@macohen

@macohen macohen commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

Description

Enabling the Windows build in CI.yml and ensuring we generate unit test coverage reports.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

macohen and others added 6 commits November 17, 2022 10:33
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
@macohen
macohen requested a review from a team November 17, 2022 20:16
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@2f28dc5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage        ?   19.69%           
  Complexity      ?       49           
=======================================
  Files           ?       27           
  Lines           ?      721           
  Branches        ?       97           
=======================================
  Hits            ?      142           
  Misses          ?      571           
  Partials        ?        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

added test that adds 1 more line of coverage. :|

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
@msfroh
msfroh merged commit 929570c into opensearch-project:main Nov 21, 2022
msfroh pushed a commit that referenced this pull request Nov 23, 2022
* adding codecov and windows build commands
* output jacoco test reports
* enabling jacoco test report output in build.gradle
* adding dependabot check at a daily interval
* added test that adds 1 more line of coverage. :|
* fixing dependabot configurations
* fixing tests - adding 1 line coverage - woohoo
* removed spotlessCheck

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants