Skip to content

Build against 2.4.0 (without -SNAPSHOT) - #29

Merged
macohen merged 1 commit into
opensearch-project:mainfrom
msfroh:search-processor-2.4
Nov 17, 2022
Merged

Build against 2.4.0 (without -SNAPSHOT)#29
macohen merged 1 commit into
opensearch-project:mainfrom
msfroh:search-processor-2.4

Conversation

@msfroh

@msfroh msfroh commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

Since 2.4.0 is released, we no longer need to build against -SNAPSHOT.

Signed-off-by: Michael Froh froh@amazon.com

Description

Just removes -SNAPSHOT from the OpenSearch version, so we build against the 2.4.0 release.

Issues Resolved

Relates to #27

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Since 2.4.0 is released, we no longer need to build against -SNAPSHOT.

Signed-off-by: Michael Froh <froh@amazon.com>
@msfroh
msfroh requested a review from a team November 17, 2022 22:51

@macohen macohen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the size of this PR. Awesome!

@macohen
macohen merged commit 8b34c02 into opensearch-project:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants