Add test coverage for SearchActionFilter - #30
Merged
Conversation
Signed-off-by: Michael Froh <froh@amazon.com>
macohen
reviewed
Nov 22, 2022
macohen
reviewed
Nov 22, 2022
macohen
reviewed
Nov 22, 2022
macohen
left a comment
macohen
left a comment
Collaborator
There was a problem hiding this comment.
Just had a few questions, but looks good overall.
msfroh
changed the title
msfroh
marked this pull request as ready for review
November 22, 2022 18:19
macohen
approved these changes
Nov 22, 2022
msfroh
added a commit
that referenced
this pull request
Nov 23, 2022
Signed-off-by: Michael Froh <froh@amazon.com>
mingshl
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Froh froh@amazon.com
Description
Adds unit tests for SearchActionFilter class (plus OpenSearchClient as collateral impact).
Issues Resolved
#31 won't actually be "resolved", but this contributes.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.