Modifying logic to generate passages from search result document - #33
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
============================================
+ Coverage 56.87% 60.43% +3.56%
- Complexity 129 155 +26
============================================
Files 28 29 +1
Lines 800 867 +67
Branches 105 119 +14
============================================
+ Hits 455 524 +69
+ Misses 308 304 -4
- Partials 37 39 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mahitamahesh
force-pushed
the
passage-splitting
branch
from
November 23, 2022 17:50
ca79171 to
6b089f0
Compare
mahitamahesh
marked this pull request as ready for review
November 23, 2022 17:54
msfroh
reviewed
Nov 23, 2022
| if (token == null) { | ||
| return null; | ||
| } | ||
| return token.replaceAll(PUNCTUATIONS_REGEX_PATTERN, ""); |
Collaborator
There was a problem hiding this comment.
Can you compile the regex once into a static final Pattern, and replace this with:
PUNCTUATIONS_REGEX.matcher(token).replaceAll("");
As written, this will compile the regex on every token.
Contributor
Author
There was a problem hiding this comment.
Ah! I changed the one above and missed this one.. thanks for catching!
Signed-off-by: Mahita Mahesh <mahitam@amazon.com>
mahitamahesh
force-pushed
the
passage-splitting
branch
from
November 23, 2022 18:18
6b089f0 to
7577099
Compare
msfroh
approved these changes
Nov 23, 2022
msfroh
pushed a commit
that referenced
this pull request
Nov 23, 2022
Signed-off-by: Mahita Mahesh <mahitam@amazon.com>
mingshl
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mahita Mahesh mahitam@amazon.com
Description
Compared to the previous logic, this change adds:
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.