Skip to content

Fix permissions for PR Stats action - #67

Merged
macohen merged 1 commit into
opensearch-project:mainfrom
manuelmhtr:fix-pr-stats
Dec 23, 2022
Merged

Fix permissions for PR Stats action#67
macohen merged 1 commit into
opensearch-project:mainfrom
manuelmhtr:fix-pr-stats

Conversation

@manuelmhtr

@manuelmhtr manuelmhtr commented Dec 23, 2022

Copy link
Copy Markdown
Contributor

Description

The pull-request-stats action is configured correctly but lacks permission to comment on the pull request description.

This pull request sets write permission for pull-requests on this action.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@manuelmhtr
manuelmhtr requested a review from a team December 23, 2022 22:56
Signed-off-by: Manuel de la Torre <manuelmhtr@gmail.com>

@macohen macohen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@macohen
macohen merged commit 493d74e into opensearch-project:main Dec 23, 2022
@macohen

macohen commented Dec 23, 2022

Copy link
Copy Markdown
Collaborator

fixes #67 and #66

@manuelmhtr
manuelmhtr deleted the fix-pr-stats branch December 23, 2022 23:19
@noCharger noCharger added the backport 2.x Backport to 2.x branch label Jan 4, 2023
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Jan 4, 2023
Signed-off-by: Manuel de la Torre <manuelmhtr@gmail.com>

Signed-off-by: Manuel de la Torre <manuelmhtr@gmail.com>
(cherry picked from commit 493d74e)
noCharger pushed a commit that referenced this pull request Jan 4, 2023
Signed-off-by: Manuel de la Torre <manuelmhtr@gmail.com>

Signed-off-by: Manuel de la Torre <manuelmhtr@gmail.com>
(cherry picked from commit 493d74e)

Co-authored-by: Manuel de la Torre <manuelmhtr@gmail.com>
@mingshl mingshl added bug Something isn't working infrastructure A change to infrastructure, testing, CI/CD, pipelines, etc. and removed bug Something isn't working labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch infrastructure A change to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants