Skip to content

Update log statements in quickstart helper script - #79

Merged
msfroh merged 1 commit into
opensearch-project:mainfrom
kevinawskendra:log-update
Jan 10, 2023
Merged

Update log statements in quickstart helper script#79
msfroh merged 1 commit into
opensearch-project:mainfrom
kevinawskendra:log-update

Conversation

@mahitamahesh

@mahitamahesh mahitamahesh commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Signed-off-by: Mahita Mahesh mahitam@amazon.com

Description

Updating two log statements in quickstart helper script to make argument validation clearer.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mahita Mahesh <mahitam@amazon.com>
@mahitamahesh
mahitamahesh requested a review from a team January 10, 2023 17:47
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #79 (6382c01) into main (657ebe5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #79   +/-   ##
=========================================
  Coverage     65.52%   65.52%           
  Complexity      172      172           
=========================================
  Files            29       29           
  Lines           879      879           
  Branches        119      119           
=========================================
  Hits            576      576           
  Misses          254      254           
  Partials         49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@msfroh
msfroh merged commit 2308941 into opensearch-project:main Jan 10, 2023
@mingshl mingshl added the backport 2.x Backport to 2.x branch label Jan 18, 2023
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Jan 18, 2023
Signed-off-by: Mahita Mahesh <mahitam@amazon.com>

Signed-off-by: Mahita Mahesh <mahitam@amazon.com>
Co-authored-by: Mahita Mahesh <mahitam@amazon.com>
(cherry picked from commit 2308941)
noCharger pushed a commit that referenced this pull request Jan 18, 2023
Signed-off-by: Mahita Mahesh <mahitam@amazon.com>

Signed-off-by: Mahita Mahesh <mahitam@amazon.com>
Co-authored-by: Mahita Mahesh <mahitam@amazon.com>
(cherry picked from commit 2308941)

Co-authored-by: mahitamahesh <mahitamahesh@gmail.com>
@mingshl mingshl added the enhancement change or upgrade that increases software capabilities beyond original client specifications label Jan 24, 2023
@mingshl mingshl mentioned this pull request Jan 26, 2023
5 tasks
@mingshl mingshl added feature introduce a net new unit of functionality of a software system that satisfies a requirement and removed enhancement change or upgrade that increases software capabilities beyond original client specifications labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch feature introduce a net new unit of functionality of a software system that satisfies a requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants