Skip to content

Revert Click 6 regressions for chain and deprecate chain #1323

Closed

Description

@mitsuhiko

With Click 6.0 we landed a change that was supposed to fix chain (0a2919f). In the process it got worse and broke a bunch of non chain uses.

We should back out that change and instead deprecate chain. I do not believe there is a way to make chain work with the current argument parsing and execution behavior.

The reason for this is that click really wants to delegate the parsing of subcommands with the remainder of the command line but this breaks in the light of chaining. I would need to look into the exact implementation again but last time I investigated this it looked like a fundamental issue we cannot fix with the current design.

Activity

  1. direnter commented on Jun 1, 2019

    @direnter

    Is there a way to mimic chain functionality using traditional Click methods?

  2. jtrakk commented on Jul 19, 2019

    @jtrakk
  3. davidism commented on Aug 13, 2020

    @davidism
    Member

    @jcrotts did some research and determined that the changes from 6 were already reverted and released in 6.1. After looking over the issues again, we've decided not to remove chain. Putting aside the broad issue of possibly rewriting the parser or pipeline, the open issues appear to be solvable, so we'll continue to address them for now.

  4. locked as resolved and limited conversation to collaborators on Nov 13, 2020
  5. added
    parsingParsing, parameters, commands, chaining, context
    and removed on Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    parsingParsing, parameters, commands, chaining, context

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions