running tests in parallel with tox p fails #2899

Activity

1. Rowlando13 commented on May 12, 2025

   

   Rowlando13

   on May 12, 2025

   Member

   More actions

   Shouldn't it fail? Don't some test s use click's testing which is not thread safe.
2. davidism commented on May 12, 2025

   

   davidism

   on May 12, 2025

   MemberAuthor

   More actions

   It worked until the changes to the pager, and only fail on the pager test. I made sure everything ran correctly with tox p in all projects, it makes pre-checking a PR way faster.
3. Rowlando13 commented on May 12, 2025

   

   Rowlando13

   on May 12, 2025

   Member

   More actions

   I agree. What did you do? I was just planning on looking some tests
4. Rowlando13 commented on May 12, 2025

   

   Rowlando13

   on May 12, 2025

   Last edited by kdeldycke

   Member

   More actions

   There are multiple instances of this:

   def test_file_args(runner):
       @click.command()
       @click.argument("input", type=click.File("rb"))
       @click.argument("output", type=click.File("wb"))
       def inout(input, output):
           while True:
               chunk = input.read(1024)
               if not chunk:
                   break
               output.write(chunk)
   
       with runner.isolated_filesystem():
           result = runner.invoke(inout, ["-", "hello.txt"], input="Hey!")
           assert result.output == ""
           assert result.exit_code == 0
           with open("hello.txt", "rb") as f:
               assert f.read() == b"Hey!"
   
           result = runner.invoke(inout, ["hello.txt", "-"])
           assert result.output == "Hey!"
           assert result.exit_code == 0

   Seems like the isolated_filesystem() would not be thread safe.
5. kdeldycke

   added this to the 8.4.1 milestone on May 21, 2026
6. kdeldycke

   added

   bug

   test runnerCliRunner and Click's test utilities featureCliRunner and Click's test utilities feature

   on May 21, 2026
7. davidism commented on May 22, 2026

   

   davidism

   on May 22, 2026

   MemberAuthor

   More actions

   Seems to work now.
8. davidism

   closed this as completedon May 22, 2026
9. davidism

   reopened this on May 22, 2026
10. davidism

    modified the milestones: 8.4.1, 8.5.0 on May 22, 2026
11. kdeldycke

    linked a pull request that will close this issuefix: Skip flaky pager test on macOS with free-threaded Python 3.14t #3470on May 22, 2026
12. kdeldycke commented on May 22, 2026

    

    kdeldycke

    on May 22, 2026

    Collaborator

    More actions

    Running tests in parallel with tox p fails, meaning I have to run all local test envs serially right now. It seems that the detected terminal environment is different in parallel mode, causing the pager tests to fail.

    FAILED tests/test_utils.py::test_echo_via_pager[test0-cat] - AssertionError: Unexpected pager output in test case 'Plain string argument'
    

    This part has been already fixed by #3238 which is available in Click 8.3.3.
13. kdeldycke

    linked a pull request that will close this issueFix pager test flackiness and add stress tests for `echo_via_pager` #3499on May 22, 2026
14. kdeldycke commented on May 22, 2026

    

    kdeldycke

    on May 22, 2026

    Collaborator

    More actions

    Seems like the isolated_filesystem() would not be thread safe.

    It is not. So I move this concern to a dedicated issue at: #3501

    That way this current issue can be marked as closed and addressed in Click 8.4.2 once #3499 is merged, as it will make the tests properly running in parallels, as the original issue suggested.
15. kdeldycke

    modified the milestones: 8.5.0, 8.4.2 on May 22, 2026
16. kdeldycke

    added a commit that references this issue on May 27, 2026

    Fix pager test race by raising before yield

    ...

    7eb57cf
17. Rowlando13

    closed this as completedon May 29, 2026
18. github-actions

    locked as resolved and limited conversation to collaborators on Jul 24, 2026