Repository navigation
Click Processing Pipeline Rewrite #590
Description
Click evolved unfortunately really badly the last two releases because the internal logic just grew too complex and it's totally not sound. This needs to be cleaned up but I'm not yet sure how.
Click needs to somehow become a pipeline that is clearly separated to be able to work better. Starting with parsing, handling of value callbacks and then invoking the callbacks. Maybe we need to split this pipeline into more steps where we can have args that are not yet processed by callbacks somehow?
Some effects of the current broken handling:
- CLI: "flask" command help doesn't list custom commands flask#1124 (auto help does not invoke callbacks)
- chain is broken. There is a failing testcase in the repo
Activity
mitsuhiko commentedon May 26, 2016
I'm not entirely sure how we ended up on this point but it was probably a bad design from the start and it got more and more eroded over time. I will need to write down the exact effects this causes but essentially we badly mix parsing with invoking so if something needs to "inverse" the order things get really out of hand. For instance
--helpinternally is a huge hack right now. This also shows up in a few situations now outside as people have discovered.--appoption is not processed for the default help rendering (removed now in Flask)--configflags that can override some settings that might affect the execution of Click because there is no good hook point.